AtHeartEngineer/devise
1
1
Fork 0
mirror of https://github.com/heartcombo/devise.git synced 2026-01-09 15:47:59 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update tests to use safe redirects

Browse Source
This commit is contained in:
Leonardo Tegon
2019-01-22 17:21:32 -02:00
parent c000b58c56
commit c116542c28
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/controllers/passwords_controller_test.rb
View File

@@ -25,7 +25,7 @@ class PasswordsControllerTest < Devise::ControllerTestCase
end end
test 'redirect accordingly if after_resetting_password_path_for is overridden' do test 'redirect accordingly if after_resetting_password_path_for is overridden' do
custom_path = "http://custom.path/" custom_path = "/custom-path/"
Devise::PasswordsController.any_instance.stubs(:after_resetting_password_path_for).with(@user).returns(custom_path) Devise::PasswordsController.any_instance.stubs(:after_resetting_password_path_for).with(@user).returns(custom_path)
put_update_with_params put_update_with_params

2
test/controllers/sessions_controller_test.rb
View File

@@ -36,7 +36,7 @@ class SessionsControllerTest < Devise::ControllerTestCase
test "#create delete the url stored in the session if the requested format is navigational" do test "#create delete the url stored in the session if the requested format is navigational" do
request.env["devise.mapping"] = Devise.mappings[:user] request.env["devise.mapping"] = Devise.mappings[:user]
request.session["user_return_to"] = 'foo.bar' request.session["user_return_to"] = '/foo.bar'
user = create_user user = create_user
user.confirm user.confirm

8
test/failure_app_test.rb
View File

@@ -82,7 +82,7 @@ class FailureTest < ActiveSupport::TestCase
end end
test 'returns to the default redirect location considering subdomain' do test 'returns to the default redirect location considering subdomain' do
call_failure('warden.options' => { scope: :subdomain_user }) call_failure('warden.options' => { scope: :subdomain_user }, 'REQUEST_URI' => 'http://sub.test.host/', 'HTTP_HOST' => 'sub.test.host')
assert_equal 302, @response.first assert_equal 302, @response.first
assert_equal 'You need to sign in or sign up before continuing.', @request.flash[:alert] assert_equal 'You need to sign in or sign up before continuing.', @request.flash[:alert]
assert_equal 'http://sub.test.host/subdomain_users/sign_in', @response.second['Location'] assert_equal 'http://sub.test.host/subdomain_users/sign_in', @response.second['Location']
@@ -105,7 +105,7 @@ class FailureTest < ActiveSupport::TestCase
test 'returns to the root path considering subdomain if no session path is available' do test 'returns to the root path considering subdomain if no session path is available' do
swap Devise, router_name: :fake_app do swap Devise, router_name: :fake_app do
call_failure app: FailureWithSubdomain call_failure app: FailureWithSubdomain, 'REQUEST_URI' => 'http://sub.test.host/', 'HTTP_HOST' => 'sub.test.host'
assert_equal 302, @response.first assert_equal 302, @response.first
assert_equal 'You need to sign in or sign up before continuing.', @request.flash[:alert] assert_equal 'You need to sign in or sign up before continuing.', @request.flash[:alert]
assert_equal 'http://sub.test.host/', @response.second['Location'] assert_equal 'http://sub.test.host/', @response.second['Location']
@@ -130,7 +130,7 @@ class FailureTest < ActiveSupport::TestCase
test 'returns to the default redirect location considering the relative url root and subdomain' do test 'returns to the default redirect location considering the relative url root and subdomain' do
swap Rails.application.config, relative_url_root: "/sample" do swap Rails.application.config, relative_url_root: "/sample" do
call_failure('warden.options' => { scope: :subdomain_user }) call_failure('warden.options' => { scope: :subdomain_user }, 'REQUEST_URI' => 'http://sub.test.host/', 'HTTP_HOST' => 'sub.test.host')
assert_equal 302, @response.first assert_equal 302, @response.first
assert_equal 'http://sub.test.host/sample/subdomain_users/sign_in', @response.second['Location'] assert_equal 'http://sub.test.host/sample/subdomain_users/sign_in', @response.second['Location']
end end
@@ -148,7 +148,7 @@ class FailureTest < ActiveSupport::TestCase
test "returns to the default redirect location considering action_controller's relative url root and subdomain" do test "returns to the default redirect location considering action_controller's relative url root and subdomain" do
swap Rails.application.config.action_controller, relative_url_root: "/sample" do swap Rails.application.config.action_controller, relative_url_root: "/sample" do
call_failure('warden.options' => { scope: :subdomain_user }) call_failure('warden.options' => { scope: :subdomain_user }, 'REQUEST_URI' => 'http://sub.test.host/', 'HTTP_HOST' => 'sub.test.host')
assert_equal 302, @response.first assert_equal 302, @response.first
assert_equal 'http://sub.test.host/sample/subdomain_users/sign_in', @response.second['Location'] assert_equal 'http://sub.test.host/sample/subdomain_users/sign_in', @response.second['Location']
end end