From e9c534d363cc9d552662049b38582eead87bedd6 Mon Sep 17 00:00:00 2001 From: Carlos Antonio da Silva Date: Mon, 5 Jan 2026 18:10:32 -0300 Subject: [PATCH] Fix "Test is missing assertions" warnings `test_set_null_fields_on_migrations` ./devise/test/models_test.rb:87 `test_does_not_crash_when_the_last_request_at_is_a_String` ./devise/test/integration/timeoutable_test.rb:191 `test_defined_Warden_after_authentication_callback_should_not_be_called_when_sign_in_is_called` ./devise/test/test/controller_helpers_test.rb:114 `test_defined_Warden_before_logout_callback_should_not_be_called_when_sign_out_is_called` ./devise/test/test/controller_helpers_test.rb:128 --- test/integration/timeoutable_test.rb | 6 ++++-- test/models_test.rb | 2 +- test/test/controller_helpers_test.rb | 4 ++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/test/integration/timeoutable_test.rb b/test/integration/timeoutable_test.rb index d7e31ba6..73c716e6 100644 --- a/test/integration/timeoutable_test.rb +++ b/test/integration/timeoutable_test.rb @@ -191,7 +191,9 @@ class SessionTimeoutTest < Devise::IntegrationTest test 'does not crash when the last_request_at is a String' do user = sign_in_as_user - get edit_form_user_path(user, last_request_at: Time.now.utc.to_s) - get users_path + assert_nothing_raised do + get edit_form_user_path(user, last_request_at: Time.now.utc.to_s) + get users_path + end end end diff --git a/test/models_test.rb b/test/models_test.rb index 16acb92c..e2aced9e 100644 --- a/test/models_test.rb +++ b/test/models_test.rb @@ -90,7 +90,7 @@ class ActiveRecordTest < ActiveSupport::TestCase def send_devise_notification(*); end end - klass.create! + assert_nothing_raised { klass.create! } end end diff --git a/test/test/controller_helpers_test.rb b/test/test/controller_helpers_test.rb index 7ba9f3c6..a158e875 100644 --- a/test/test/controller_helpers_test.rb +++ b/test/test/controller_helpers_test.rb @@ -112,7 +112,7 @@ class TestControllerHelpersTest < Devise::ControllerTestCase end test "defined Warden after_authentication callback should not be called when sign_in is called" do - begin + assert_nothing_raised do Warden::Manager.after_authentication do |user, auth, opts| flunk "callback was called while it should not" end @@ -126,7 +126,7 @@ class TestControllerHelpersTest < Devise::ControllerTestCase end test "defined Warden before_logout callback should not be called when sign_out is called" do - begin + assert_nothing_raised do Warden::Manager.before_logout do |user, auth, opts| flunk "callback was called while it should not" end