mirror of
https://github.com/OffchainLabs/prysm.git
synced 2026-01-08 04:54:05 -05:00
Add static analyzer to discourage use of panic() (#15075)
* Implement static analysis to prevent panics * Add nopanic to nogo * Fix violations and add exclusions Fix violations and add exclusions for all * Changelog fragment * Use pass.Report instead of pass.Reportf * Remove strings.ToLower for checking init method name * Add exclusion for herumi init * Move api/client/beacon template function to init and its own file * Fix nopanic testcase
This commit is contained in:
@@ -27,11 +27,12 @@ func (pq priorityQueue) Swap(i, j int) {
|
||||
pq[j].index = j
|
||||
}
|
||||
|
||||
// Push a LeakyBucket to priorityQueue
|
||||
func (pq *priorityQueue) Push(x interface{}) {
|
||||
n := len(*pq)
|
||||
b, ok := x.(*LeakyBucket)
|
||||
if !ok {
|
||||
panic(fmt.Sprintf("%T", x))
|
||||
panic(fmt.Sprintf("%T", x)) // lint:nopanic -- This method should be improved. High risk for misuse!
|
||||
}
|
||||
b.index = n
|
||||
*pq = append(*pq, b)
|
||||
|
||||
Reference in New Issue
Block a user