Add golang.org/x/tools modernize static analyzer and fix violations (#15946)

* Ran gopls modernize to fix everything

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...

* Override rules_go provided dependency for golang.org/x/tools to v0.38.0.

To update this, checked out rules_go, then ran `bazel run //go/tools/releaser -- upgrade-dep -mirror=false org_golang_x_tools` and copied the patches.

* Fix buildtag violations and ignore buildtag violations in external

* Introduce modernize analyzer package.

* Add modernize "any" analyzer.

* Fix violations of any analyzer

* Add modernize "appendclipped" analyzer.

* Fix violations of appendclipped

* Add modernize "bloop" analyzer.

* Add modernize "fmtappendf" analyzer.

* Add modernize "forvar" analyzer.

* Add modernize "mapsloop" analyzer.

* Add modernize "minmax" analyzer.

* Fix violations of minmax analyzer

* Add modernize "omitzero" analyzer.

* Add modernize "rangeint" analyzer.

* Fix violations of rangeint.

* Add modernize "reflecttypefor" analyzer.

* Fix violations of reflecttypefor analyzer.

* Add modernize "slicescontains" analyzer.

* Add modernize "slicessort" analyzer.

* Add modernize "slicesdelete" analyzer. This is disabled by default for now. See https://go.dev/issue/73686.

* Add modernize "stringscutprefix" analyzer.

* Add modernize "stringsbuilder" analyzer.

* Fix violations of stringsbuilder analyzer.

* Add modernize "stringsseq" analyzer.

* Add modernize "testingcontext" analyzer.

* Add modernize "waitgroup" analyzer.

* Changelog fragment

* gofmt

* gazelle

* Add modernize "newexpr" analyzer.

* Disable newexpr until go1.26

* Add more details in WORKSPACE on how to update the override

* @nalepae feedback on min()

* gofmt

* Fix violations of forvar

monitoring/journald/journalhook_linux.go

@@ -49,7 +49,7 @@ func stringifyKey(key string) string {
 }
 
 // Journal wants strings but logrus takes anything.
-func stringifyEntries(data map[string]interface{}) map[string]string {
+func stringifyEntries(data map[string]any) map[string]string {
 	entries := make(map[string]string)
 	for k, v := range data {
 		key := stringifyKey(k)

monitoring/journald/journalhook_linux_test.go

@@ -3,7 +3,7 @@ package journald
 import "testing"
 
 func TestStringifyEntries(t *testing.T) {
-	input := map[string]interface{}{
+	input := map[string]any{
 		"foo":     "bar",
 		"baz":     123,
 		"foo-foo": "x",

monitoring/prometheus/content_negotiation.go

@@ -20,7 +20,7 @@ type generatedResponse struct {
 	Err string `json:"error"`
 
 	// Data is response output, if any.
-	Data interface{} `json:"data"`
+	Data any `json:"data"`
 }
 
 // negotiateContentType parses "Accept:" header and returns preferred content type string.

monitoring/prometheus/logrus_collector_test.go

@@ -17,9 +17,9 @@ import (
 )
 
 type logger interface {
-	Info(args ...interface{})
-	Warn(args ...interface{})
-	Error(args ...interface{})
+	Info(args ...any)
+	Warn(args ...any)
+	Error(args ...any)
 }
 
 func TestLogrusCollector(t *testing.T) {

monitoring/tracing/recovery_interceptor_option.go

@@ -13,7 +13,7 @@ import (
 
 // RecoveryHandlerFunc is a function that recovers from the panic `p` by returning an `error`.
 // The context can be used to extract request scoped metadata and context values.
-func RecoveryHandlerFunc(ctx context.Context, p interface{}) error {
+func RecoveryHandlerFunc(ctx context.Context, p any) error {
 	span := trace.FromContext(ctx)
 	if span != nil {
 		span.SetAttributes(trace.StringAttribute("stack", string(debug.Stack())))