Add golang.org/x/tools modernize static analyzer and fix violations (#15946)

* Ran gopls modernize to fix everything

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...

* Override rules_go provided dependency for golang.org/x/tools to v0.38.0.

To update this, checked out rules_go, then ran `bazel run //go/tools/releaser -- upgrade-dep -mirror=false org_golang_x_tools` and copied the patches.

* Fix buildtag violations and ignore buildtag violations in external

* Introduce modernize analyzer package.

* Add modernize "any" analyzer.

* Fix violations of any analyzer

* Add modernize "appendclipped" analyzer.

* Fix violations of appendclipped

* Add modernize "bloop" analyzer.

* Add modernize "fmtappendf" analyzer.

* Add modernize "forvar" analyzer.

* Add modernize "mapsloop" analyzer.

* Add modernize "minmax" analyzer.

* Fix violations of minmax analyzer

* Add modernize "omitzero" analyzer.

* Add modernize "rangeint" analyzer.

* Fix violations of rangeint.

* Add modernize "reflecttypefor" analyzer.

* Fix violations of reflecttypefor analyzer.

* Add modernize "slicescontains" analyzer.

* Add modernize "slicessort" analyzer.

* Add modernize "slicesdelete" analyzer. This is disabled by default for now. See https://go.dev/issue/73686.

* Add modernize "stringscutprefix" analyzer.

* Add modernize "stringsbuilder" analyzer.

* Fix violations of stringsbuilder analyzer.

* Add modernize "stringsseq" analyzer.

* Add modernize "testingcontext" analyzer.

* Add modernize "waitgroup" analyzer.

* Changelog fragment

* gofmt

* gazelle

* Add modernize "newexpr" analyzer.

* Disable newexpr until go1.26

* Add more details in WORKSPACE on how to update the override

* @nalepae feedback on min()

* gofmt

* Fix violations of forvar

third_party/hid/usb.go

@@ -46,7 +46,7 @@ type DeviceInfo struct {
 	Interface int
 
 	// Raw low level libusb endpoint data for simplified communication
-	rawDevice interface{}
+	rawDevice any
 	rawPort   *uint8 // Pointer to differentiate between unset and port 0
 	rawReader *uint8 // Pointer to differentiate between unset and endpoint 0
 	rawWriter *uint8 // Pointer to differentiate between unset and endpoint 0

third_party/hid/usb_test.go

@@ -25,12 +25,12 @@ import (
 // Tests that HID enumeration can be called concurrently from multiple threads.
 func TestThreadedEnumerateHid(t *testing.T) {
 	var pend sync.WaitGroup
-	for i := 0; i < 8; i++ {
+	for i := range 8 {
 		pend.Add(1)
 
 		go func(index int) {
 			defer pend.Done()
-			for j := 0; j < 512; j++ {
+			for j := range 512 {
 				if _, err := EnumerateHid(uint16(index), 0); err != nil {
 					t.Errorf("thread %d, iter %d: failed to enumerate: %v", index, j, err)
 				}
@@ -48,12 +48,12 @@ func TestThreadedEnumerateRaw(t *testing.T) {
 	}
 	// Yay, we can actually test this
 	var pend sync.WaitGroup
-	for i := 0; i < 8; i++ {
+	for i := range 8 {
 		pend.Add(1)
 
 		go func(index int) {
 			defer pend.Done()
-			for j := 0; j < 512; j++ {
+			for j := range 512 {
 				if _, err := EnumerateRaw(uint16(index), 0); err != nil {
 					t.Errorf("thread %d, iter %d: failed to enumerate: %v", index, j, err)
 				}
@@ -70,12 +70,12 @@ func TestThreadedEnumerate(t *testing.T) {
 		t.Skip("Linux on Travis doesn't have usbfs, skipping test")
 	}
 	var pend sync.WaitGroup
-	for i := 0; i < 8; i++ {
+	for i := range 8 {
 		pend.Add(1)
 
 		go func(index int) {
 			defer pend.Done()
-			for j := 0; j < 512; j++ {
+			for j := range 512 {
 				if _, err := Enumerate(uint16(index), 0); err != nil {
 					t.Errorf("thread %d, iter %d: failed to enumerate: %v", index, j, err)
 				}