AtHeartEngineer/prysm
1
0
Fork 0
mirror of https://github.com/OffchainLabs/prysm.git synced 2026-01-08 21:08:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Deprecate --init-sync-no-verify, make it the default (#4179)

Browse Source 
* deprecated --init-sync-no-verify, make it the default
* Merge branch 'master' into deprecate-init-sync-verify-flag
* add more flag info
* Merge branch 'deprecate-init-sync-verify-flag' of github.com:prysmaticlabs/prysm into deprecate-init-sync-verify-flag
* gofmt
* Merge refs/heads/master into deprecate-init-sync-verify-flag
* Merge refs/heads/master into deprecate-init-sync-verify-flag
This commit is contained in:
Preston Van Loon
2019-12-03 10:46:04 -08:00
committed by prylabs-bulldozer[bot]
parent 28c4f28d32
commit 32245a9062
2 changed files with 17 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
shared/featureconfig/config.go
View File

@@ -86,8 +86,10 @@ func ConfigureBeaconChain(ctx *cli.Context) {
log.Warn("Enabled unsafe eth1 data vote cache") log.Warn("Enabled unsafe eth1 data vote cache")
cfg.EnableEth1DataVoteCache = true cfg.EnableEth1DataVoteCache = true
} }
if ctx.GlobalBool(InitSyncNoVerifyFlag.Name) { if ctx.GlobalBool(initSyncVerifyEverythingFlag.Name) {
log.Warn("Initial syncing without verifying block's contents") log.Warn("Initial syncing with verifying all block's content signatures.")
cfg.InitSyncNoVerify = false
} else {
cfg.InitSyncNoVerify = true cfg.InitSyncNoVerify = true
} }
if ctx.GlobalBool(NewCacheFlag.Name) { if ctx.GlobalBool(NewCacheFlag.Name) {

19
shared/featureconfig/flags.go
View File

@@ -45,11 +45,6 @@ var (
Name: "enable-active-count-cache", Name: "enable-active-count-cache",
Usage: "Enable unsafe cache mechanism. See https://github.com/prysmaticlabs/prysm/issues/3106", Usage: "Enable unsafe cache mechanism. See https://github.com/prysmaticlabs/prysm/issues/3106",
} }
// InitSyncNoVerifyFlag enables the initial sync no verify configuration.
InitSyncNoVerifyFlag = cli.BoolFlag{
Name: "init-sync-no-verify",
Usage: "Initial sync to finalized check point w/o verifying block's signature, RANDAO and attestation's aggregated signatures",
}
// NewCacheFlag enables the node to use the new caching scheme. // NewCacheFlag enables the node to use the new caching scheme.
NewCacheFlag = cli.BoolFlag{ NewCacheFlag = cli.BoolFlag{
Name: "new-cache", Name: "new-cache",
@@ -81,6 +76,12 @@ var (
Name: "prune-states", Name: "prune-states",
Usage: "Prune epoch boundary states before last finalized check point", Usage: "Prune epoch boundary states before last finalized check point",
} }
initSyncVerifyEverythingFlag = cli.BoolFlag{
Name: "initial-sync-verify-all-signatures",
Usage: "Initial sync to finalized checkpoint with verifying block's signature, RANDAO " +
"and attestation's aggregated signatures. Without this flag, only the proposer " +
"signature is verified until the node reaches the end of the finalized chain.",
}
) )
// Deprecated flags list. // Deprecated flags list.
@@ -112,6 +113,11 @@ var (
Usage: deprecatedUsage, Usage: deprecatedUsage,
Hidden: true, Hidden: true,
} }
deprecatedInitSyncNoVerifyFlag = cli.BoolFlag{
Name: "init-sync-no-verify",
Usage: deprecatedUsage,
Hidden: true,
}
) )
var deprecatedFlags = []cli.Flag{ var deprecatedFlags = []cli.Flag{
@@ -120,6 +126,7 @@ var deprecatedFlags = []cli.Flag{
deprecatedScatterFlag, deprecatedScatterFlag,
deprecatedPruneFinalizedStatesFlag, deprecatedPruneFinalizedStatesFlag,
deprecatedOptimizeProcessEpoch, deprecatedOptimizeProcessEpoch,
deprecatedInitSyncNoVerifyFlag,
} }
// ValidatorFlags contains a list of all the feature flags that apply to the validator client. // ValidatorFlags contains a list of all the feature flags that apply to the validator client.
@@ -134,7 +141,7 @@ var BeaconChainFlags = append(deprecatedFlags, []cli.Flag{
writeSSZStateTransitionsFlag, writeSSZStateTransitionsFlag,
EnableAttestationCacheFlag, EnableAttestationCacheFlag,
EnableEth1DataVoteCacheFlag, EnableEth1DataVoteCacheFlag,
InitSyncNoVerifyFlag, initSyncVerifyEverythingFlag,
NewCacheFlag, NewCacheFlag,
SkipBLSVerifyFlag, SkipBLSVerifyFlag,
enableBackupWebhookFlag, enableBackupWebhookFlag,