From 47922fe7d8f4c07a3e7982cc0172d7825afa1e3f Mon Sep 17 00:00:00 2001 From: Nishant Das Date: Mon, 10 Feb 2025 23:01:23 +0800 Subject: [PATCH] Remove Unused assignment (#14906) * Remove unused boolean assignment * Changelog * Remove debug line --- beacon-chain/state/state-native/setters_consolidation.go | 1 - beacon-chain/state/state-native/setters_deposits.go | 1 - beacon-chain/state/state-native/setters_participation.go | 4 ---- changelog/nisdas_remove_useless_assignment.md | 3 +++ 4 files changed, 3 insertions(+), 6 deletions(-) create mode 100644 changelog/nisdas_remove_useless_assignment.md diff --git a/beacon-chain/state/state-native/setters_consolidation.go b/beacon-chain/state/state-native/setters_consolidation.go index c4fd6f45de..2eb09bbf8c 100644 --- a/beacon-chain/state/state-native/setters_consolidation.go +++ b/beacon-chain/state/state-native/setters_consolidation.go @@ -53,7 +53,6 @@ func (b *BeaconState) SetPendingConsolidations(val []*ethpb.PendingConsolidation b.pendingConsolidations = val b.markFieldAsDirty(types.PendingConsolidations) - b.rebuildTrie[types.PendingConsolidations] = true return nil } diff --git a/beacon-chain/state/state-native/setters_deposits.go b/beacon-chain/state/state-native/setters_deposits.go index 21635d81c5..dcb1655a10 100644 --- a/beacon-chain/state/state-native/setters_deposits.go +++ b/beacon-chain/state/state-native/setters_deposits.go @@ -53,7 +53,6 @@ func (b *BeaconState) SetPendingDeposits(val []*ethpb.PendingDeposit) error { b.pendingDeposits = val b.markFieldAsDirty(types.PendingDeposits) - b.rebuildTrie[types.PendingDeposits] = true return nil } diff --git a/beacon-chain/state/state-native/setters_participation.go b/beacon-chain/state/state-native/setters_participation.go index 6017d67769..92750d95c0 100644 --- a/beacon-chain/state/state-native/setters_participation.go +++ b/beacon-chain/state/state-native/setters_participation.go @@ -22,7 +22,6 @@ func (b *BeaconState) SetPreviousParticipationBits(val []byte) error { b.previousEpochParticipation = val b.markFieldAsDirty(types.PreviousEpochParticipationBits) - b.rebuildTrie[types.PreviousEpochParticipationBits] = true return nil } @@ -41,7 +40,6 @@ func (b *BeaconState) SetCurrentParticipationBits(val []byte) error { b.currentEpochParticipation = val b.markFieldAsDirty(types.CurrentEpochParticipationBits) - b.rebuildTrie[types.CurrentEpochParticipationBits] = true return nil } @@ -126,7 +124,6 @@ func (b *BeaconState) ModifyPreviousParticipationBits(mutator func(val []byte) ( defer b.lock.Unlock() b.previousEpochParticipation = participation b.markFieldAsDirty(types.PreviousEpochParticipationBits) - b.rebuildTrie[types.PreviousEpochParticipationBits] = true return nil } @@ -161,6 +158,5 @@ func (b *BeaconState) ModifyCurrentParticipationBits(mutator func(val []byte) ([ defer b.lock.Unlock() b.currentEpochParticipation = participation b.markFieldAsDirty(types.CurrentEpochParticipationBits) - b.rebuildTrie[types.CurrentEpochParticipationBits] = true return nil } diff --git a/changelog/nisdas_remove_useless_assignment.md b/changelog/nisdas_remove_useless_assignment.md new file mode 100644 index 0000000000..041e51ed26 --- /dev/null +++ b/changelog/nisdas_remove_useless_assignment.md @@ -0,0 +1,3 @@ +### Fixed + +- We remove the unused `rebuildTrie` assignments for fields which do not use them. \ No newline at end of file