AtHeartEngineer/prysm
1
0
Fork 0
mirror of https://github.com/OffchainLabs/prysm.git synced 2026-01-09 21:38:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

Code cleanup (#9992)

Browse Source 
* Value assigned to a variable is never read before being overwritten

* The result of append is not used anywhere

* Suspicious assignment of range-loop vars detected

* Unused method receiver detected

* Revert "Auxiliary commit to revert individual files from 54edcb445484a2e5d79612e19af8e949b8861253"

This reverts commit bbd1e1beabf7b0c5cfc4f514dcc820062ad6c063.

* Method modifies receiver

* Fix test

* Duplicate imports detected

* Incorrectly formatted error string

* Types of function parameters can be combined

* One more "Unused method receiver detected"

* Unused parameter detected in function
This commit is contained in:
Radosław Kapka
2021-12-07 18:52:39 +01:00
committed by GitHub
parent 1eff00fb33
commit 5569a68452
152 changed files with 817 additions and 896 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
crypto/keystore/keystore.go
View File

@@ -53,7 +53,7 @@ type Keystore struct {
}
// GetKey from file using the filename path and a decryption password.
func (ks Keystore) GetKey(filename, password string) (*Key, error) {
func (_ Keystore) GetKey(filename, password string) (*Key, error) {
// Load the key from the keystore and decrypt its contents
// #nosec G304
keyJSON, err := ioutil.ReadFile(filename)
@@ -65,7 +65,7 @@ func (ks Keystore) GetKey(filename, password string) (*Key, error) {
// GetKeys from directory using the prefix to filter relevant files
// and a decryption password.
func (ks Keystore) GetKeys(directory, filePrefix, password string, warnOnFail bool) (map[string]*Key, error) {
func (_ Keystore) GetKeys(directory, filePrefix, password string, warnOnFail bool) (map[string]*Key, error) {
// Load the key from the keystore and decrypt its contents
// #nosec G304
files, err := ioutil.ReadDir(directory)

4
crypto/rand/rand.go
View File

@@ -43,7 +43,7 @@ var lock sync.RWMutex
var _ mrand.Source64 = (*source)(nil) /* #nosec G404 */
// Seed does nothing when crypto/rand is used as source.
func (s *source) Seed(_ int64) {}
func (_ *source) Seed(_ int64) {}
// Int63 returns uniformly-distributed random (as in CSPRNG) int64 value within [0, 1<<63) range.
// Panics if random generator reader cannot return data.
@@ -53,7 +53,7 @@ func (s *source) Int63() int64 {
// Uint64 returns uniformly-distributed random (as in CSPRNG) uint64 value within [0, 1<<64) range.
// Panics if random generator reader cannot return data.
func (s *source) Uint64() (val uint64) {
func (_ *source) Uint64() (val uint64) {
lock.RLock()
defer lock.RUnlock()
if err := binary.Read(rand.Reader, binary.BigEndian, &val); err != nil {