Make the multi-value slice permanent (#15414)

* Remove Old State Paths

* Changelog

* Gazelle

* Lint

* Fix State Tests

* fix tests, update native state code

* move ErrOutOfBounds error from consensus types to mvslice

* fix TestStreamEvents_OperationsEvents

* add missing gc to fuzz tests

* more test fixes

* build fix

---------

Co-authored-by: nisdas <nishdas93@gmail.com>

config/features/config.go

@@ -40,7 +40,6 @@ const disabledFeatureFlag = "Disabled feature flag"
 // Flags is a struct to represent which features the client will perform on runtime.
 type Flags struct {
 	// Feature related flags.
-	EnableExperimentalState             bool // EnableExperimentalState turns on the latest and greatest (but potentially unstable) changes to the beacon state.
 	WriteSSZStateTransitions            bool // WriteSSZStateTransitions to tmp directory.
 	EnablePeerScorer                    bool // EnablePeerScorer enables experimental peer scoring in p2p.
 	EnableLightClient                   bool // EnableLightClient enables light client APIs.
@@ -189,12 +188,6 @@ func ConfigureBeaconChain(ctx *cli.Context) error {
 		return err
 	}
 
-	cfg.EnableExperimentalState = true
-	if ctx.Bool(disableExperimentalState.Name) {
-		logEnabled(disableExperimentalState)
-		cfg.EnableExperimentalState = false
-	}
-
 	if ctx.Bool(writeSSZStateTransitionsFlag.Name) {
 		logEnabled(writeSSZStateTransitionsFlag)
 		cfg.WriteSSZStateTransitions = true

config/features/deprecated_flags.go

@@ -103,6 +103,11 @@ var (
 		Usage:  deprecatedUsage,
 		Hidden: true,
 	}
+	deprecatedDisableExperimentalState = &cli.BoolFlag{
+		Name:   "disable-experimental-state",
+		Usage:  deprecatedUsage,
+		Hidden: true,
+	}
 )
 
 // Deprecated flags for both the beacon node and validator client.
@@ -124,6 +129,7 @@ var deprecatedFlags = []cli.Flag{
 	deprecatedInteropGenesisTimeFlag,
 	deprecatedEnableQuic,
 	deprecatedAttestTimely,
+	deprecatedDisableExperimentalState,
 }
 
 var upcomingDeprecation = []cli.Flag{

config/features/flags.go

@@ -33,10 +33,6 @@ var (
 		Name:  "dev",
 		Usage: "Enables experimental features still in development. These features may not be stable.",
 	}
-	disableExperimentalState = &cli.BoolFlag{
-		Name:  "disable-experimental-state",
-		Usage: "Turns off the latest and greatest changes to the beacon state. Disabling this is safe to do after the feature has been enabled.",
-	}
 	writeSSZStateTransitionsFlag = &cli.BoolFlag{
 		Name:  "interop-write-ssz-state-transitions",
 		Usage: "Writes SSZ states to disk after attempted state transitio.",
@@ -240,7 +236,6 @@ var E2EValidatorFlags = []string{
 // BeaconChainFlags contains a list of all the feature flags that apply to the beacon-chain client.
 var BeaconChainFlags = combinedFlags([]cli.Flag{
 	devModeFlag,
-	disableExperimentalState,
 	writeSSZStateTransitionsFlag,
 	saveInvalidBlockTempFlag,
 	saveInvalidBlobTempFlag,