Flip --enable-experimental-state to opt-out. (#14398)

This commit is contained in:
Preston Van Loon
2024-08-29 15:42:32 -05:00
committed by GitHub
parent 3015eea4e3
commit 93e6bd7929
4 changed files with 15 additions and 8 deletions

View File

@@ -172,9 +172,10 @@ func ConfigureBeaconChain(ctx *cli.Context) error {
return err
}
if ctx.Bool(enableExperimentalState.Name) {
logEnabled(enableExperimentalState)
cfg.EnableExperimentalState = true
cfg.EnableExperimentalState = true
if ctx.Bool(disableExperimentalState.Name) {
logEnabled(disableExperimentalState)
cfg.EnableExperimentalState = false
}
if ctx.Bool(writeSSZStateTransitionsFlag.Name) {

View File

@@ -57,6 +57,11 @@ var (
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedEnableExperimentalState = &cli.BoolFlag{
Name: "enable-experimental-state",
Usage: deprecatedUsage,
Hidden: true,
}
)
// Deprecated flags for both the beacon node and validator client.
@@ -71,6 +76,7 @@ var deprecatedFlags = []cli.Flag{
deprecatedDisableEIP4881,
deprecatedVerboseSigVerification,
deprecatedEnableDebugRPCEndpoints,
deprecatedEnableExperimentalState,
}
// deprecatedBeaconFlags contains flags that are still used by other components

View File

@@ -28,9 +28,9 @@ var (
Name: "dev",
Usage: "Enables experimental features still in development. These features may not be stable.",
}
enableExperimentalState = &cli.BoolFlag{
Name: "enable-experimental-state",
Usage: "Turns on the latest and greatest (but potentially unstable) changes to the beacon state.",
disableExperimentalState = &cli.BoolFlag{
Name: "disable-experimental-state",
Usage: "Turns off the latest and greatest changes to the beacon state. Disabling this is safe to do after the feature has been enabled.",
}
writeSSZStateTransitionsFlag = &cli.BoolFlag{
Name: "interop-write-ssz-state-transitions",
@@ -174,7 +174,6 @@ var (
// devModeFlags holds list of flags that are set when development mode is on.
var devModeFlags = []cli.Flag{
enableExperimentalState,
backfill.EnableExperimentalBackfill,
EnableQUIC,
}
@@ -201,7 +200,7 @@ var E2EValidatorFlags = []string{
// BeaconChainFlags contains a list of all the feature flags that apply to the beacon-chain client.
var BeaconChainFlags = append(deprecatedBeaconFlags, append(deprecatedFlags, []cli.Flag{
devModeFlag,
enableExperimentalState,
disableExperimentalState,
writeSSZStateTransitionsFlag,
saveInvalidBlockTempFlag,
saveInvalidBlobTempFlag,