remove eip6110flag for validator index cache (#14173)

* using fork instead of eip6110flag for validator index cache

* updating validator indicies on initialize from poroto unsafe

* fixing bad version check

* attempting to fix unit test

* reverting test changes

* changing incorrect initialization

* updating comment

* radek's comment'

config/features/config.go

@@ -74,9 +74,8 @@ type Flags struct {
 	// BlobSaveFsync requires blob saving to block on fsync to ensure blobs are durably persisted before passing DA.
 	BlobSaveFsync bool
 
-	SaveInvalidBlock           bool // SaveInvalidBlock saves invalid block to temp.
-	SaveInvalidBlob            bool // SaveInvalidBlob saves invalid blob to temp.
-	EIP6110ValidatorIndexCache bool // EIP6110ValidatorIndexCache specifies whether to use the new validator index cache.
+	SaveInvalidBlock bool // SaveInvalidBlock saves invalid block to temp.
+	SaveInvalidBlob  bool // SaveInvalidBlob saves invalid blob to temp.
 
 	// KeystoreImportDebounceInterval specifies the time duration the validator waits to reload new keys if they have
 	// changed on disk. This feature is for advanced use cases only.
@@ -256,11 +255,6 @@ func ConfigureBeaconChain(ctx *cli.Context) error {
 		cfg.EnableQUIC = true
 	}
 
-	if ctx.IsSet(eip6110ValidatorCache.Name) {
-		logEnabled(eip6110ValidatorCache)
-		cfg.EIP6110ValidatorIndexCache = true
-	}
-
 	cfg.AggregateIntervals = [3]time.Duration{aggregateFirstInterval.Value, aggregateSecondInterval.Value, aggregateThirdInterval.Value}
 	Init(cfg)
 	return nil

config/features/flags.go

@@ -166,11 +166,6 @@ var (
 		Name:  "enable-quic",
 		Usage: "Enables connection using the QUIC protocol for peers which support it.",
 	}
-	// eip6110ValidatorCache is a flag for enabling the EIP-6110 validator cache.
-	eip6110ValidatorCache = &cli.BoolFlag{
-		Name:  "eip6110-validator-cache",
-		Usage: "Enables the EIP-6110 validator cache.",
-	}
 )
 
 // devModeFlags holds list of flags that are set when development mode is on.
@@ -228,7 +223,6 @@ var BeaconChainFlags = append(deprecatedBeaconFlags, append(deprecatedFlags, []c
 	EnableLightClient,
 	BlobSaveFsync,
 	EnableQUIC,
-	eip6110ValidatorCache,
 }...)...)
 
 // E2EBeaconChainFlags contains a list of the beacon chain feature flags to be tested in E2E.