Default to the portable version of blst (#12720)

* Default to the portable version of blst

* Update based on review comments

---------

Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
This commit is contained in:
Justin Traglia
2023-09-29 15:35:15 -05:00
committed by GitHub
parent fb19ee8895
commit b667c68c87
3 changed files with 7 additions and 7 deletions

View File

@@ -15,7 +15,7 @@ coverage --define=coverage_enabled=1
# Stamp binaries with git information # Stamp binaries with git information
build --workspace_status_command=./hack/workspace_status.sh build --workspace_status_command=./hack/workspace_status.sh
build --define blst_disabled=false --define blst_modern=true build --define blst_disabled=false
run --define blst_disabled=false run --define blst_disabled=false
build:blst_disabled --define blst_disabled=true build:blst_disabled --define blst_disabled=true

View File

@@ -75,14 +75,14 @@ jobs:
- name: Build - name: Build
# Use blst tag to allow go and bazel builds for blst. # Use blst tag to allow go and bazel builds for blst.
run: go build -v ./... run: go build -v ./...
env: env:
CGO_CFLAGS: "-O -D__BLST_PORTABLE__" CGO_CFLAGS: "-O2 -D__BLST_PORTABLE__"
# fuzz leverage go tag based stubs at compile time. # fuzz leverage go tag based stubs at compile time.
# Building and testing with these tags should be checked and enforced at pre-submit. # Building and testing with these tags should be checked and enforced at pre-submit.
- name: Test for fuzzing - name: Test for fuzzing
run: go test -tags=fuzz,develop ./... -test.run=^Fuzz run: go test -tags=fuzz,develop ./... -test.run=^Fuzz
env: env:
CGO_CFLAGS: "-O -D__BLST_PORTABLE__" CGO_CFLAGS: "-O2 -D__BLST_PORTABLE__"
# Tests run via Bazel for now... # Tests run via Bazel for now...
# - name: Test # - name: Test

View File

@@ -23,7 +23,7 @@ go_library(
"-D__BLST_CGO__", "-D__BLST_CGO__",
"-Ibindings", "-Ibindings",
"-Isrc", "-Isrc",
"-O", "-O2",
] + select({ ] + select({
"@io_bazel_rules_go//go/platform:amd64": [ "@io_bazel_rules_go//go/platform:amd64": [
"-mno-avx", "-mno-avx",
@@ -86,7 +86,7 @@ cc_library(
"build/assembly.S", "build/assembly.S",
], ],
copts = [ copts = [
"-O", "-O2",
] + select({ ] + select({
"@io_bazel_rules_go//go/platform:amd64": [ "@io_bazel_rules_go//go/platform:amd64": [
"-mno-avx", "-mno-avx",