From b748c04a6790343ff2f69c0a1d9ac1c9b501d977 Mon Sep 17 00:00:00 2001 From: Manu NALEPA Date: Wed, 17 Dec 2025 23:51:35 +0100 Subject: [PATCH] Pending aggregates: When multiple aggregated attestations only differing by the aggregator index are in the pending queue, only process one of them. --- beacon-chain/sync/pending_attestations_queue.go | 3 --- beacon-chain/sync/pending_attestations_queue_test.go | 5 ----- 2 files changed, 8 deletions(-) diff --git a/beacon-chain/sync/pending_attestations_queue.go b/beacon-chain/sync/pending_attestations_queue.go index 831bcbcbac..1f8a800185 100644 --- a/beacon-chain/sync/pending_attestations_queue.go +++ b/beacon-chain/sync/pending_attestations_queue.go @@ -402,9 +402,6 @@ func pendingAggregatesAreEqual(a, b ethpb.SignedAggregateAttAndProof) bool { if a.Version() != b.Version() { return false } - if a.AggregateAttestationAndProof().GetAggregatorIndex() != b.AggregateAttestationAndProof().GetAggregatorIndex() { - return false - } aAtt := a.AggregateAttestationAndProof().AggregateVal() bAtt := b.AggregateAttestationAndProof().AggregateVal() if aAtt.GetData().Slot != bAtt.GetData().Slot { diff --git a/beacon-chain/sync/pending_attestations_queue_test.go b/beacon-chain/sync/pending_attestations_queue_test.go index 2e5b743469..472fdc8eca 100644 --- a/beacon-chain/sync/pending_attestations_queue_test.go +++ b/beacon-chain/sync/pending_attestations_queue_test.go @@ -918,11 +918,6 @@ func Test_pendingAggregatesAreEqual(t *testing.T) { b := ðpb.SignedAggregateAttestationAndProofElectra{Message: ðpb.AggregateAttestationAndProofElectra{AggregatorIndex: 1}} assert.Equal(t, false, pendingAggregatesAreEqual(a, b)) }) - t.Run("different aggregator index", func(t *testing.T) { - a := ðpb.SignedAggregateAttestationAndProof{Message: ðpb.AggregateAttestationAndProof{AggregatorIndex: 1}} - b := ðpb.SignedAggregateAttestationAndProof{Message: ðpb.AggregateAttestationAndProof{AggregatorIndex: 2}} - assert.Equal(t, false, pendingAggregatesAreEqual(a, b)) - }) t.Run("different slot", func(t *testing.T) { a := ðpb.SignedAggregateAttestationAndProof{ Message: ðpb.AggregateAttestationAndProof{