AtHeartEngineer/prysm
1
0
Fork 0
mirror of https://github.com/OffchainLabs/prysm.git synced 2026-01-08 04:54:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

core: refactor signing and domain methods from helper to core/signing pkg (#9520)

Browse Source 
* Move domain function and all signing root functions from beacon-chain/core/helpers to beacon-chain/core

* @terencechain suggestion to put these methods under core/signing
This commit is contained in:
Preston Van Loon
2021-09-27 11:19:20 -05:00
committed by GitHub
parent 3e640fe79f
commit ee0a453b7b
104 changed files with 477 additions and 368 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
contracts/deposit/BUILD.bazel
View File

@@ -11,7 +11,7 @@ go_library(
importpath = "github.com/prysmaticlabs/prysm/contracts/deposit",
visibility = ["//visibility:public"],
deps = [
"//beacon-chain/core/helpers:go_default_library",
"//beacon-chain/core/signing:go_default_library",
"//config/features:go_default_library",
"//config/params:go_default_library",
"//crypto/bls:go_default_library",
@@ -40,7 +40,7 @@ go_test(
],
deps = [
":go_default_library",
"//beacon-chain/core/helpers:go_default_library",
"//beacon-chain/core/signing:go_default_library",
"//config/params:go_default_library",
"//container/trie:go_default_library",
"//crypto/bls:go_default_library",

6
contracts/deposit/deposit.go
View File

@@ -4,7 +4,7 @@ package deposit
import (
"github.com/pkg/errors"
"github.com/prysmaticlabs/prysm/beacon-chain/core/helpers"
"github.com/prysmaticlabs/prysm/beacon-chain/core/signing"
"github.com/prysmaticlabs/prysm/config/features"
"github.com/prysmaticlabs/prysm/config/params"
"github.com/prysmaticlabs/prysm/crypto/bls"
@@ -38,7 +38,7 @@ func DepositInput(depositKey, withdrawalKey bls.SecretKey, amountInGwei uint64)
return nil, [32]byte{}, err
}
domain, err := helpers.ComputeDomain(
domain, err := signing.ComputeDomain(
params.BeaconConfig().DomainDeposit,
nil, /*forkVersion*/
nil, /*genesisValidatorsRoot*/
@@ -109,7 +109,7 @@ func VerifyDepositSignature(dd *ethpb.Deposit_Data, domain []byte) error {
return errors.Wrap(err, "could not get container root")
}
if !sig.Verify(publicKey, ctrRoot[:]) {
return helpers.ErrSigFailedToVerify
return signing.ErrSigFailedToVerify
}
return nil
}

8
contracts/deposit/deposit_test.go
View File

@@ -3,7 +3,7 @@ package deposit_test
import (
"testing"
"github.com/prysmaticlabs/prysm/beacon-chain/core/helpers"
"github.com/prysmaticlabs/prysm/beacon-chain/core/signing"
"github.com/prysmaticlabs/prysm/config/params"
"github.com/prysmaticlabs/prysm/contracts/deposit"
"github.com/prysmaticlabs/prysm/crypto/bls"
@@ -32,7 +32,7 @@ func TestDepositInput_GeneratesPb(t *testing.T) {
}
sr, err := testData.HashTreeRoot()
require.NoError(t, err)
domain, err := helpers.ComputeDomain(
domain, err := signing.ComputeDomain(
params.BeaconConfig().DomainDeposit,
nil, /*forkVersion*/
nil, /*genesisValidatorsRoot*/
@@ -47,7 +47,7 @@ func TestVerifyDepositSignature_ValidSig(t *testing.T) {
deposits, _, err := util.DeterministicDepositsAndKeys(1)
require.NoError(t, err)
dep := deposits[0]
domain, err := helpers.ComputeDomain(
domain, err := signing.ComputeDomain(
params.BeaconConfig().DomainDeposit,
params.BeaconConfig().GenesisForkVersion,
params.BeaconConfig().ZeroHash[:],
@@ -61,7 +61,7 @@ func TestVerifyDepositSignature_InvalidSig(t *testing.T) {
deposits, _, err := util.DeterministicDepositsAndKeys(1)
require.NoError(t, err)
dep := deposits[0]
domain, err := helpers.ComputeDomain(
domain, err := signing.ComputeDomain(
params.BeaconConfig().DomainDeposit,
params.BeaconConfig().GenesisForkVersion,
params.BeaconConfig().ZeroHash[:],