From f3774edeb10a250a6ee342bd1266d15baa9dbdfc Mon Sep 17 00:00:00 2001 From: Zach Zundel Date: Sat, 22 Sep 2018 16:07:03 -0600 Subject: [PATCH] Pending TODO Script Checker in Codebase (#540) * TODO script * Add todo to Travis * Remove blame from todo check * Print failing todo comments * Fail on failure * Fix todo checker * Don't install godeps * *actually* don't install godeps --- .travis.yml | 6 ++++++ scripts/check-todo.sh | 10 ++++++++++ 2 files changed, 16 insertions(+) create mode 100755 scripts/check-todo.sh diff --git a/.travis.yml b/.travis.yml index 1b1ce39b67..a876448d53 100644 --- a/.travis.yml +++ b/.travis.yml @@ -10,6 +10,12 @@ matrix: script: - go get github.com/alecthomas/gometalinter && gometalinter --install && gometalinter ./... --deadline=10m --exclude=client/internal/client_helper.go + - os: linux + env: + - todos + install: true # Skip installing go packages + script: + - ./scripts/check-todo.sh - os: linux env: - coverage diff --git a/scripts/check-todo.sh b/scripts/check-todo.sh new file mode 100755 index 0000000000..5345882c54 --- /dev/null +++ b/scripts/check-todo.sh @@ -0,0 +1,10 @@ +#!/bin/bash + +# Continuous integration script to check that TODOs are in the correct format +OUTPUT="$(grep -PrinH '(?&2; + echo "$OUTPUT" >&2; + exit 1; +fi