Fix staticcheck violations (#13301)

* Fix violations of sa2002

* Fix violations of sa4005

* Fix violations of sa4010

* Fix violations for sa4023

* Comment on commented static checks
This commit is contained in:
Preston Van Loon
2023-12-08 07:07:52 -06:00
committed by GitHub
parent f537a98fcd
commit ff99616833
5 changed files with 17 additions and 16 deletions

View File

@@ -104,7 +104,7 @@ STATICCHECK_ANALYZERS = [
"sa1016",
"sa1017",
"sa1018",
# "sa1019",
# "sa1019", # TODO: Fix all uses of deprecated things.
"sa1020",
"sa1021",
"sa1023",
@@ -117,7 +117,7 @@ STATICCHECK_ANALYZERS = [
"sa1030",
"sa2000",
"sa2001",
# "sa2002",
"sa2002",
"sa2003",
"sa3000",
"sa3001",
@@ -125,11 +125,11 @@ STATICCHECK_ANALYZERS = [
"sa4001",
"sa4003",
"sa4004",
# "sa4005",
# "sa4006",
"sa4005",
# "sa4006", # TODO: Fix violations of unused arguments.
"sa4008",
"sa4009",
# "sa4010",
"sa4010",
"sa4011",
"sa4012",
"sa4013",
@@ -142,7 +142,7 @@ STATICCHECK_ANALYZERS = [
"sa4020",
"sa4021",
"sa4022",
# "sa4023",
"sa4023",
"sa4024",
"sa4025",
"sa4026",