Files
prysm/nogo_config.json
Preston Van Loon 2fd6bd8150 Add golang.org/x/tools modernize static analyzer and fix violations (#15946)
* Ran gopls modernize to fix everything

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...

* Override rules_go provided dependency for golang.org/x/tools to v0.38.0.

To update this, checked out rules_go, then ran `bazel run //go/tools/releaser -- upgrade-dep -mirror=false org_golang_x_tools` and copied the patches.

* Fix buildtag violations and ignore buildtag violations in external

* Introduce modernize analyzer package.

* Add modernize "any" analyzer.

* Fix violations of any analyzer

* Add modernize "appendclipped" analyzer.

* Fix violations of appendclipped

* Add modernize "bloop" analyzer.

* Add modernize "fmtappendf" analyzer.

* Add modernize "forvar" analyzer.

* Add modernize "mapsloop" analyzer.

* Add modernize "minmax" analyzer.

* Fix violations of minmax analyzer

* Add modernize "omitzero" analyzer.

* Add modernize "rangeint" analyzer.

* Fix violations of rangeint.

* Add modernize "reflecttypefor" analyzer.

* Fix violations of reflecttypefor analyzer.

* Add modernize "slicescontains" analyzer.

* Add modernize "slicessort" analyzer.

* Add modernize "slicesdelete" analyzer. This is disabled by default for now. See https://go.dev/issue/73686.

* Add modernize "stringscutprefix" analyzer.

* Add modernize "stringsbuilder" analyzer.

* Fix violations of stringsbuilder analyzer.

* Add modernize "stringsseq" analyzer.

* Add modernize "testingcontext" analyzer.

* Add modernize "waitgroup" analyzer.

* Changelog fragment

* gofmt

* gazelle

* Add modernize "newexpr" analyzer.

* Disable newexpr until go1.26

* Add more details in WORKSPACE on how to update the override

* @nalepae feedback on min()

* gofmt

* Fix violations of forvar
2025-11-14 01:27:22 +00:00

321 lines
8.0 KiB
JSON

{
"unsafeptr": {
"exclude_files": {
"external/.*": "Unsafe third party code",
"rules_go_work-.*": "Third party code"
}
},
"unreachable": {
"exclude_files": {
"runtime/messagehandler/messagehandler_test.go": "Necessary panic before return for test",
"external/.*": "Unreachable third party code"
}
},
"lostcancel": {
"exclude_files": {
"validator/client/runner.go": "No need to cancel right when goroutines begin",
"external/.*": "Third party code"
}
},
"nilness": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code"
}
},
"pkgfact": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code"
}
},
"stdmethods": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"copylocks": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"composites": {
"exclude_files": {
"external/.*": "Third party code",
".*testmain\\.go$": "Fuzz"
}
},
"cgocall": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"assign": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"structtag": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"maligned": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code",
"config/params/config.go": "This config struct needs to be organized for now",
"shared/featureconfig/config.go": "This config struct needs to be organized for now",
"proto/.*": "Excluding protobuf objects for now",
".*_mock.go": "Excluding generated mock files"
}
},
"errcheck": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code",
"shared/mock/.*\\.go": "Mocks are OK",
".*/.*mock\\.go": "Mocks are OK",
".*testmain\\.go$": "Fuzz",
"proto/.*": "Generated protobuf related code",
"tools/analyzers/properpermissions/testdata/.*": "Analyzer breaks rules"
}
},
"featureconfig": {
"only_files": {
".*_test\\.go": "Only tests"
}
},
"interfacechecker": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code",
".*/.*_test\\.go": "Tests are OK to ignore this check for"
}
},
"logruswitherror": {
"exclude_files": {
"external/.*": "Third party code",
".*/testmain.go": "Generated/test code"
}
},
"cryptorand": {
"only_files": {
"beacon-chain/.*": "",
"shared/.*": "",
"slasher/.*": "",
"validator/.*": ""
},
"exclude_files": {
".*/.*_test\\.go": "Tests are OK to use weak crypto",
"external/.*": "Third party code",
"crypto/rand/rand\\.go": "Abstracts CSPRNGs for common use",
"shared/aggregation/testing/bitlistutils.go": "Test-only package"
}
},
"comparesame": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code",
"tools/analyzers/comparesame/testdata/compare_len.go": "Analyzer testdata has to break rules"
}
},
"shadowpredecl": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code",
"tools/analyzers/shadowpredecl/testdata/shadow.go": "Analyzer testdata has to break rules"
}
},
"recursivelock": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code",
"tools/analyzers/recursivelock/testdata/.*": "Analyzer testdata has to break rules"
}
},
"nop": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code",
"tools/analyzers/nop/testdata/no_op.go": "Analyzer testdata has to break rules"
}
},
"slicedirect": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code",
"tools/analyzers/slicedirect/testdata/slice.go": "Analyzer testdata has to break rules"
}
},
"ineffassign": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code",
".*\\.pb.*.go": "Generated code is ok",
".*\\.ssz\\.go": "Generated code is ok"
}
},
"properpermissions": {
"only_files": {
"beacon-chain/.*": "",
"slasher/.*": "",
"shared/.*": "",
"validator/.*": ""
},
"exclude_files": {
".*_test\\.go": "Tests are ok",
"io/file/fileutil.go": "Package which defines the proper rules",
"validator/web/site_data.go": "Generated web ui assets"
}
},
"uintcast": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code",
".*_test\\.go": "Tests are ok"
}
},
"gocognit": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code",
".*\\.pb.*.go": "Generated code is ok",
".*\\.ssz\\.go": "Generated code is ok",
".*_test\\.go": "Tests are ok (for now)",
"tools/analyzers/ineffassign/ineffassign\\.go": "3rd party code with a massive switch statement"
}
},
"shift": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code"
}
},
"reflectvaluecompare": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code"
}
},
"unusedwrite": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code"
}
},
"stringintconv": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code"
}
},
"loopclosure": {
"exclude_files": {
"external/com_github_ethereum_go_ethereum/.*": "Unsafe third party code",
"rules_go_work-.*": "Third party code"
}
},
"buildtag": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"any": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"appendclipped": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"fmtappendf": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"forvar": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"mapsloop": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"minmax": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"newexpr": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"omitzero": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"rangeint": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"reflecttypefor": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"slicescontains": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"slicessort": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"stringsbuilder": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"stringscutprefix": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"stringsseq": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"waitgroup": {
"exclude_files": {
"external/.*": "Third party code"
}
},
"nopanic": {
"exclude_files": {
"validator/web/site_data.go": "generated code",
".*/.*_test\\.go": "Tests are OK",
".*/main\\.go": "main methods are OK",
"external/.*": "Third party code"
}
},
"logcapitalization": {
"exclude_files": {
"external/.*": "Third party code",
"rules_go_work-.*": "Third party code",
".*/.*_test\\.go": "Test logs can be less formal",
"tools/analyzers/logcapitalization/testdata/.*": "Analyzer testdata has to break rules"
}
}
}