mirror of
https://github.com/OffchainLabs/prysm.git
synced 2026-01-09 21:38:05 -05:00
149e220b61
* Validator custody: Update to the latest specfication. * Update beacon-chain/blockchain/process_block.go Co-authored-by: terence <terence@prysmaticlabs.com> * Fix James' comment. * Fix James' comment. * Fix James' comment. --------- Co-authored-by: terence <terence@prysmaticlabs.com> Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
875 lines
32 KiB
Go
875 lines
32 KiB
Go
package sync
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"fmt"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/OffchainLabs/prysm/v6/async/abool"
|
|
mock "github.com/OffchainLabs/prysm/v6/beacon-chain/blockchain/testing"
|
|
"github.com/OffchainLabs/prysm/v6/beacon-chain/core/feed"
|
|
"github.com/OffchainLabs/prysm/v6/beacon-chain/core/feed/operation"
|
|
"github.com/OffchainLabs/prysm/v6/beacon-chain/core/helpers"
|
|
"github.com/OffchainLabs/prysm/v6/beacon-chain/core/signing"
|
|
dbtest "github.com/OffchainLabs/prysm/v6/beacon-chain/db/testing"
|
|
"github.com/OffchainLabs/prysm/v6/beacon-chain/operations/attestations"
|
|
"github.com/OffchainLabs/prysm/v6/beacon-chain/p2p/peers"
|
|
p2ptest "github.com/OffchainLabs/prysm/v6/beacon-chain/p2p/testing"
|
|
"github.com/OffchainLabs/prysm/v6/beacon-chain/startup"
|
|
mockSync "github.com/OffchainLabs/prysm/v6/beacon-chain/sync/initial-sync/testing"
|
|
lruwrpr "github.com/OffchainLabs/prysm/v6/cache/lru"
|
|
fieldparams "github.com/OffchainLabs/prysm/v6/config/fieldparams"
|
|
"github.com/OffchainLabs/prysm/v6/config/params"
|
|
"github.com/OffchainLabs/prysm/v6/consensus-types/primitives"
|
|
"github.com/OffchainLabs/prysm/v6/crypto/bls"
|
|
"github.com/OffchainLabs/prysm/v6/encoding/bytesutil"
|
|
ethpb "github.com/OffchainLabs/prysm/v6/proto/prysm/v1alpha1"
|
|
"github.com/OffchainLabs/prysm/v6/proto/prysm/v1alpha1/attestation"
|
|
"github.com/OffchainLabs/prysm/v6/testing/assert"
|
|
"github.com/OffchainLabs/prysm/v6/testing/require"
|
|
"github.com/OffchainLabs/prysm/v6/testing/util"
|
|
prysmTime "github.com/OffchainLabs/prysm/v6/time"
|
|
"github.com/ethereum/go-ethereum/p2p/enr"
|
|
pubsub "github.com/libp2p/go-libp2p-pubsub"
|
|
pubsubpb "github.com/libp2p/go-libp2p-pubsub/pb"
|
|
"github.com/libp2p/go-libp2p/core/network"
|
|
"github.com/prysmaticlabs/go-bitfield"
|
|
logTest "github.com/sirupsen/logrus/hooks/test"
|
|
)
|
|
|
|
var verifierLimit = 1000
|
|
|
|
func TestProcessPendingAtts_NoBlockRequestBlock(t *testing.T) {
|
|
hook := logTest.NewGlobal()
|
|
db := dbtest.SetupDB(t)
|
|
p1 := p2ptest.NewTestP2P(t)
|
|
p2 := p2ptest.NewTestP2P(t)
|
|
p1.Connect(p2)
|
|
assert.Equal(t, 1, len(p1.BHost.Network().Peers()), "Expected peers to be connected")
|
|
p1.Peers().Add(new(enr.Record), p2.PeerID(), nil, network.DirOutbound)
|
|
p1.Peers().SetConnectionState(p2.PeerID(), peers.Connected)
|
|
p1.Peers().SetChainState(p2.PeerID(), ðpb.StatusV2{})
|
|
|
|
chain := &mock.ChainService{Genesis: prysmTime.Now(), FinalizedCheckPoint: ðpb.Checkpoint{}}
|
|
r := &Service{
|
|
cfg: &config{p2p: p1, beaconDB: db, chain: chain, clock: startup.NewClock(chain.Genesis, chain.ValidatorsRoot)},
|
|
blkRootToPendingAtts: make(map[[32]byte][]ethpb.SignedAggregateAttAndProof),
|
|
chainStarted: abool.New(),
|
|
}
|
|
|
|
a := ðpb.AggregateAttestationAndProof{Aggregate: ðpb.Attestation{Data: ðpb.AttestationData{Target: ðpb.Checkpoint{Root: make([]byte, 32)}}}}
|
|
r.blkRootToPendingAtts[[32]byte{'A'}] = []ethpb.SignedAggregateAttAndProof{ðpb.SignedAggregateAttestationAndProof{Message: a}}
|
|
require.NoError(t, r.processPendingAtts(t.Context()))
|
|
require.LogsContain(t, hook, "Requesting block by root")
|
|
}
|
|
|
|
func TestProcessPendingAtts_HasBlockSaveUnAggregatedAtt(t *testing.T) {
|
|
hook := logTest.NewGlobal()
|
|
db := dbtest.SetupDB(t)
|
|
p1 := p2ptest.NewTestP2P(t)
|
|
validators := uint64(256)
|
|
|
|
beaconState, privKeys := util.DeterministicGenesisState(t, validators)
|
|
|
|
sb := util.NewBeaconBlock()
|
|
util.SaveBlock(t, t.Context(), db, sb)
|
|
root, err := sb.Block.HashTreeRoot()
|
|
require.NoError(t, err)
|
|
|
|
aggBits := bitfield.NewBitlist(8)
|
|
aggBits.SetBitAt(1, true)
|
|
att := ðpb.Attestation{
|
|
Data: ðpb.AttestationData{
|
|
BeaconBlockRoot: root[:],
|
|
Source: ðpb.Checkpoint{Epoch: 0, Root: bytesutil.PadTo([]byte("hello-world"), 32)},
|
|
Target: ðpb.Checkpoint{Epoch: 0, Root: root[:]},
|
|
},
|
|
AggregationBits: aggBits,
|
|
}
|
|
|
|
committee, err := helpers.BeaconCommitteeFromState(t.Context(), beaconState, att.Data.Slot, att.Data.CommitteeIndex)
|
|
assert.NoError(t, err)
|
|
attestingIndices, err := attestation.AttestingIndices(att, committee)
|
|
require.NoError(t, err)
|
|
attesterDomain, err := signing.Domain(beaconState.Fork(), 0, params.BeaconConfig().DomainBeaconAttester, beaconState.GenesisValidatorsRoot())
|
|
require.NoError(t, err)
|
|
hashTreeRoot, err := signing.ComputeSigningRoot(att.Data, attesterDomain)
|
|
assert.NoError(t, err)
|
|
for _, i := range attestingIndices {
|
|
att.Signature = privKeys[i].Sign(hashTreeRoot[:]).Marshal()
|
|
}
|
|
|
|
aggregateAndProof := ðpb.AggregateAttestationAndProof{
|
|
Aggregate: att,
|
|
}
|
|
|
|
require.NoError(t, beaconState.SetGenesisTime(time.Now()))
|
|
|
|
chain := &mock.ChainService{Genesis: time.Now(),
|
|
State: beaconState,
|
|
FinalizedCheckPoint: ðpb.Checkpoint{
|
|
Root: aggregateAndProof.Aggregate.Data.BeaconBlockRoot,
|
|
Epoch: 0,
|
|
},
|
|
}
|
|
|
|
done := make(chan *feed.Event, 1)
|
|
defer close(done)
|
|
opn := mock.NewEventFeedWrapper()
|
|
sub := opn.Subscribe(done)
|
|
defer sub.Unsubscribe()
|
|
ctx, cancel := context.WithCancel(t.Context())
|
|
r := &Service{
|
|
ctx: ctx,
|
|
cfg: &config{
|
|
p2p: p1,
|
|
beaconDB: db,
|
|
chain: chain,
|
|
clock: startup.NewClock(chain.Genesis, chain.ValidatorsRoot),
|
|
attPool: attestations.NewPool(),
|
|
attestationNotifier: &mock.SimpleNotifier{Feed: opn},
|
|
},
|
|
blkRootToPendingAtts: make(map[[32]byte][]ethpb.SignedAggregateAttAndProof),
|
|
seenUnAggregatedAttestationCache: lruwrpr.New(10),
|
|
signatureChan: make(chan *signatureVerifier, verifierLimit),
|
|
}
|
|
go r.verifierRoutine()
|
|
|
|
s, err := util.NewBeaconState()
|
|
require.NoError(t, err)
|
|
require.NoError(t, r.cfg.beaconDB.SaveState(t.Context(), s, root))
|
|
|
|
r.blkRootToPendingAtts[root] = []ethpb.SignedAggregateAttAndProof{ðpb.SignedAggregateAttestationAndProof{Message: aggregateAndProof}}
|
|
require.NoError(t, r.processPendingAtts(t.Context()))
|
|
|
|
var wg sync.WaitGroup
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
for {
|
|
select {
|
|
case received := <-done:
|
|
// make sure a single att was sent
|
|
require.Equal(t, operation.UnaggregatedAttReceived, int(received.Type))
|
|
return
|
|
case <-ctx.Done():
|
|
return
|
|
}
|
|
}
|
|
}()
|
|
atts := r.cfg.attPool.UnaggregatedAttestations()
|
|
assert.Equal(t, 1, len(atts), "Did not save unaggregated att")
|
|
assert.DeepEqual(t, att, atts[0], "Incorrect saved att")
|
|
assert.Equal(t, 0, len(r.cfg.attPool.AggregatedAttestations()), "Did save aggregated att")
|
|
require.LogsContain(t, hook, "Verified and saved pending attestations to pool")
|
|
wg.Wait()
|
|
cancel()
|
|
}
|
|
|
|
func TestProcessPendingAtts_HasBlockSaveUnAggregatedAttElectra(t *testing.T) {
|
|
hook := logTest.NewGlobal()
|
|
db := dbtest.SetupDB(t)
|
|
p1 := p2ptest.NewTestP2P(t)
|
|
validators := uint64(256)
|
|
|
|
beaconState, privKeys := util.DeterministicGenesisStateElectra(t, validators)
|
|
|
|
sb := util.NewBeaconBlockElectra()
|
|
util.SaveBlock(t, t.Context(), db, sb)
|
|
root, err := sb.Block.HashTreeRoot()
|
|
require.NoError(t, err)
|
|
|
|
att := ðpb.SingleAttestation{
|
|
Data: ðpb.AttestationData{
|
|
BeaconBlockRoot: root[:],
|
|
Source: ðpb.Checkpoint{Epoch: 0, Root: bytesutil.PadTo([]byte("hello-world"), 32)},
|
|
Target: ðpb.Checkpoint{Epoch: 0, Root: root[:]},
|
|
},
|
|
}
|
|
aggregateAndProof := ðpb.AggregateAttestationAndProofSingle{
|
|
Aggregate: att,
|
|
}
|
|
|
|
committee, err := helpers.BeaconCommitteeFromState(t.Context(), beaconState, att.Data.Slot, att.Data.CommitteeIndex)
|
|
assert.NoError(t, err)
|
|
att.AttesterIndex = committee[0]
|
|
attesterDomain, err := signing.Domain(beaconState.Fork(), 0, params.BeaconConfig().DomainBeaconAttester, beaconState.GenesisValidatorsRoot())
|
|
require.NoError(t, err)
|
|
hashTreeRoot, err := signing.ComputeSigningRoot(att.Data, attesterDomain)
|
|
assert.NoError(t, err)
|
|
att.Signature = privKeys[committee[0]].Sign(hashTreeRoot[:]).Marshal()
|
|
|
|
require.NoError(t, beaconState.SetGenesisTime(time.Now()))
|
|
|
|
chain := &mock.ChainService{Genesis: time.Now(),
|
|
State: beaconState,
|
|
FinalizedCheckPoint: ðpb.Checkpoint{
|
|
Root: aggregateAndProof.Aggregate.Data.BeaconBlockRoot,
|
|
Epoch: 0,
|
|
},
|
|
}
|
|
done := make(chan *feed.Event, 1)
|
|
defer close(done)
|
|
opn := mock.NewEventFeedWrapper()
|
|
sub := opn.Subscribe(done)
|
|
defer sub.Unsubscribe()
|
|
ctx, cancel := context.WithCancel(t.Context())
|
|
r := &Service{
|
|
ctx: ctx,
|
|
cfg: &config{
|
|
p2p: p1,
|
|
beaconDB: db,
|
|
chain: chain,
|
|
clock: startup.NewClock(chain.Genesis, chain.ValidatorsRoot),
|
|
attPool: attestations.NewPool(),
|
|
attestationNotifier: &mock.SimpleNotifier{Feed: opn},
|
|
},
|
|
blkRootToPendingAtts: make(map[[32]byte][]ethpb.SignedAggregateAttAndProof),
|
|
seenUnAggregatedAttestationCache: lruwrpr.New(10),
|
|
signatureChan: make(chan *signatureVerifier, verifierLimit),
|
|
}
|
|
go r.verifierRoutine()
|
|
|
|
s, err := util.NewBeaconStateElectra()
|
|
require.NoError(t, err)
|
|
require.NoError(t, r.cfg.beaconDB.SaveState(t.Context(), s, root))
|
|
|
|
r.blkRootToPendingAtts[root] = []ethpb.SignedAggregateAttAndProof{ðpb.SignedAggregateAttestationAndProofSingle{Message: aggregateAndProof}}
|
|
require.NoError(t, r.processPendingAtts(t.Context()))
|
|
var wg sync.WaitGroup
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
for {
|
|
select {
|
|
case received := <-done:
|
|
// make sure a single att was sent
|
|
require.Equal(t, operation.SingleAttReceived, int(received.Type))
|
|
return
|
|
case <-ctx.Done():
|
|
return
|
|
}
|
|
}
|
|
}()
|
|
atts := r.cfg.attPool.UnaggregatedAttestations()
|
|
require.Equal(t, 1, len(atts), "Did not save unaggregated att")
|
|
assert.DeepEqual(t, att.ToAttestationElectra(committee), atts[0], "Incorrect saved att")
|
|
assert.Equal(t, 0, len(r.cfg.attPool.AggregatedAttestations()), "Did save aggregated att")
|
|
require.LogsContain(t, hook, "Verified and saved pending attestations to pool")
|
|
wg.Wait()
|
|
cancel()
|
|
}
|
|
|
|
func TestProcessPendingAtts_HasBlockSaveUnAggregatedAttElectra_VerifyAlreadySeen(t *testing.T) {
|
|
// Setup configuration and fork version schedule.
|
|
params.SetupTestConfigCleanup(t)
|
|
cfg := params.BeaconConfig()
|
|
fvs := map[[fieldparams.VersionLength]byte]primitives.Epoch{
|
|
bytesutil.ToBytes4(cfg.GenesisForkVersion): 1,
|
|
bytesutil.ToBytes4(cfg.AltairForkVersion): 2,
|
|
bytesutil.ToBytes4(cfg.BellatrixForkVersion): 3,
|
|
bytesutil.ToBytes4(cfg.CapellaForkVersion): 4,
|
|
bytesutil.ToBytes4(cfg.DenebForkVersion): 5,
|
|
bytesutil.ToBytes4(cfg.FuluForkVersion): 6,
|
|
bytesutil.ToBytes4(cfg.ElectraForkVersion): 0,
|
|
}
|
|
cfg.ForkVersionSchedule = fvs
|
|
params.OverrideBeaconConfig(cfg)
|
|
|
|
// Initialize logging, database, and P2P components.
|
|
hook := logTest.NewGlobal()
|
|
db := dbtest.SetupDB(t)
|
|
p1 := p2ptest.NewTestP2P(t)
|
|
validators := uint64(256)
|
|
|
|
// Create genesis state and associated keys.
|
|
beaconState, privKeys := util.DeterministicGenesisStateElectra(t, validators)
|
|
require.NoError(t, beaconState.SetSlot(1))
|
|
|
|
// Create and save a new Beacon block.
|
|
sb := util.NewBeaconBlockElectra()
|
|
util.SaveBlock(t, t.Context(), db, sb)
|
|
|
|
// Save state with block root.
|
|
root, err := sb.Block.HashTreeRoot()
|
|
require.NoError(t, err)
|
|
|
|
// Build a new attestation and its aggregate proof.
|
|
att := ðpb.SingleAttestation{
|
|
CommitteeId: 8, // choose a non 0
|
|
Data: ðpb.AttestationData{
|
|
Slot: 1,
|
|
BeaconBlockRoot: root[:],
|
|
Source: ðpb.Checkpoint{Epoch: 0, Root: make([]byte, fieldparams.RootLength)},
|
|
Target: ðpb.Checkpoint{Epoch: 0, Root: root[:]},
|
|
CommitteeIndex: 0,
|
|
},
|
|
}
|
|
aggregateAndProof := ðpb.AggregateAttestationAndProofSingle{
|
|
Aggregate: att,
|
|
}
|
|
|
|
// Retrieve the beacon committee and set the attester index.
|
|
committee, err := helpers.BeaconCommitteeFromState(t.Context(), beaconState, att.Data.Slot, att.CommitteeId)
|
|
assert.NoError(t, err)
|
|
att.AttesterIndex = committee[0]
|
|
|
|
// Compute attester domain and signature.
|
|
attesterDomain, err := signing.Domain(beaconState.Fork(), 0, params.BeaconConfig().DomainBeaconAttester, beaconState.GenesisValidatorsRoot())
|
|
require.NoError(t, err)
|
|
hashTreeRoot, err := signing.ComputeSigningRoot(att.Data, attesterDomain)
|
|
assert.NoError(t, err)
|
|
att.SetSignature(privKeys[committee[0]].Sign(hashTreeRoot[:]).Marshal())
|
|
|
|
// Set the genesis time.
|
|
require.NoError(t, beaconState.SetGenesisTime(time.Now()))
|
|
|
|
// Setup the chain service mock.
|
|
chain := &mock.ChainService{
|
|
Genesis: time.Now(),
|
|
State: beaconState,
|
|
FinalizedCheckPoint: ðpb.Checkpoint{
|
|
Root: aggregateAndProof.Aggregate.Data.BeaconBlockRoot,
|
|
Epoch: 0,
|
|
},
|
|
}
|
|
|
|
// Setup event feed and subscription.
|
|
done := make(chan *feed.Event, 1)
|
|
defer close(done)
|
|
opn := mock.NewEventFeedWrapper()
|
|
sub := opn.Subscribe(done)
|
|
defer sub.Unsubscribe()
|
|
|
|
// Create context and service configuration.
|
|
ctx, cancel := context.WithCancel(t.Context())
|
|
defer cancel()
|
|
r := &Service{
|
|
ctx: ctx,
|
|
cfg: &config{
|
|
initialSync: &mockSync.Sync{IsSyncing: false},
|
|
p2p: p1,
|
|
beaconDB: db,
|
|
chain: chain,
|
|
clock: startup.NewClock(chain.Genesis.Add(time.Duration(-1*int(params.BeaconConfig().SecondsPerSlot))*time.Second), chain.ValidatorsRoot),
|
|
attPool: attestations.NewPool(),
|
|
attestationNotifier: &mock.SimpleNotifier{Feed: opn},
|
|
},
|
|
blkRootToPendingAtts: make(map[[32]byte][]ethpb.SignedAggregateAttAndProof),
|
|
seenUnAggregatedAttestationCache: lruwrpr.New(10),
|
|
signatureChan: make(chan *signatureVerifier, verifierLimit),
|
|
}
|
|
go r.verifierRoutine()
|
|
|
|
// Save a new beacon state and link it with the block root.
|
|
s, err := util.NewBeaconStateElectra()
|
|
require.NoError(t, err)
|
|
require.NoError(t, r.cfg.beaconDB.SaveState(t.Context(), s, root))
|
|
|
|
// Add the pending attestation.
|
|
r.blkRootToPendingAtts[root] = []ethpb.SignedAggregateAttAndProof{
|
|
ðpb.SignedAggregateAttestationAndProofSingle{Message: aggregateAndProof},
|
|
}
|
|
require.NoError(t, r.processPendingAtts(t.Context()))
|
|
|
|
// Verify that the event feed receives the expected attestation.
|
|
var wg sync.WaitGroup
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
for {
|
|
select {
|
|
case received := <-done:
|
|
// Ensure a single attestation event was sent.
|
|
require.Equal(t, operation.SingleAttReceived, int(received.Type))
|
|
return
|
|
case <-ctx.Done():
|
|
return
|
|
}
|
|
}
|
|
}()
|
|
|
|
// Verify unaggregated attestations are saved correctly.
|
|
atts := r.cfg.attPool.UnaggregatedAttestations()
|
|
require.Equal(t, 1, len(atts), "Did not save unaggregated att")
|
|
assert.DeepEqual(t, att.ToAttestationElectra(committee), atts[0], "Incorrect saved att")
|
|
assert.Equal(t, 0, len(r.cfg.attPool.AggregatedAttestations()), "Did save aggregated att")
|
|
require.LogsContain(t, hook, "Verified and saved pending attestations to pool")
|
|
|
|
// Encode the attestation for pubsub and decode the message.
|
|
buf := new(bytes.Buffer)
|
|
_, err = p1.Encoding().EncodeGossip(buf, att)
|
|
require.NoError(t, err)
|
|
digest, err := r.currentForkDigest()
|
|
require.NoError(t, err)
|
|
topic := fmt.Sprintf("/eth2/%x/beacon_attestation_1", digest)
|
|
m := &pubsub.Message{
|
|
Message: &pubsubpb.Message{
|
|
Data: buf.Bytes(),
|
|
Topic: &topic,
|
|
},
|
|
}
|
|
_, err = r.decodePubsubMessage(m)
|
|
require.NoError(t, err)
|
|
|
|
// Validate the pubsub message and ignore it as it should already been seen.
|
|
res, err := r.validateCommitteeIndexBeaconAttestation(ctx, "", m)
|
|
require.NoError(t, err)
|
|
require.Equal(t, pubsub.ValidationIgnore, res)
|
|
|
|
// Wait for the event to complete.
|
|
wg.Wait()
|
|
cancel()
|
|
}
|
|
|
|
func TestProcessPendingAtts_NoBroadcastWithBadSignature(t *testing.T) {
|
|
db := dbtest.SetupDB(t)
|
|
p1 := p2ptest.NewTestP2P(t)
|
|
|
|
s, _ := util.DeterministicGenesisState(t, 256)
|
|
chain := &mock.ChainService{
|
|
State: s,
|
|
Genesis: prysmTime.Now(), FinalizedCheckPoint: ðpb.Checkpoint{Root: make([]byte, 32)}}
|
|
r := &Service{
|
|
cfg: &config{
|
|
p2p: p1,
|
|
beaconDB: db,
|
|
chain: chain,
|
|
clock: startup.NewClock(chain.Genesis, chain.ValidatorsRoot),
|
|
attPool: attestations.NewPool(),
|
|
},
|
|
blkRootToPendingAtts: make(map[[32]byte][]ethpb.SignedAggregateAttAndProof),
|
|
}
|
|
|
|
priv, err := bls.RandKey()
|
|
require.NoError(t, err)
|
|
a := ðpb.AggregateAttestationAndProof{
|
|
Aggregate: ðpb.Attestation{
|
|
Signature: priv.Sign([]byte("foo")).Marshal(),
|
|
AggregationBits: bitfield.Bitlist{0x02},
|
|
Data: util.HydrateAttestationData(ðpb.AttestationData{}),
|
|
},
|
|
SelectionProof: make([]byte, fieldparams.BLSSignatureLength),
|
|
}
|
|
|
|
b := util.NewBeaconBlock()
|
|
r32, err := b.Block.HashTreeRoot()
|
|
require.NoError(t, err)
|
|
util.SaveBlock(t, t.Context(), r.cfg.beaconDB, b)
|
|
require.NoError(t, r.cfg.beaconDB.SaveState(t.Context(), s, r32))
|
|
|
|
r.blkRootToPendingAtts[r32] = []ethpb.SignedAggregateAttAndProof{ðpb.SignedAggregateAttestationAndProof{Message: a, Signature: make([]byte, fieldparams.BLSSignatureLength)}}
|
|
require.NoError(t, r.processPendingAtts(t.Context()))
|
|
|
|
assert.Equal(t, false, p1.BroadcastCalled.Load(), "Broadcasted bad aggregate")
|
|
// Clear pool.
|
|
err = r.cfg.attPool.DeleteUnaggregatedAttestation(a.Aggregate)
|
|
require.NoError(t, err)
|
|
|
|
validators := uint64(256)
|
|
|
|
_, privKeys := util.DeterministicGenesisState(t, validators)
|
|
aggBits := bitfield.NewBitlist(8)
|
|
aggBits.SetBitAt(1, true)
|
|
att := ðpb.Attestation{
|
|
Data: ðpb.AttestationData{
|
|
BeaconBlockRoot: r32[:],
|
|
Source: ðpb.Checkpoint{Epoch: 0, Root: bytesutil.PadTo([]byte("hello-world"), 32)},
|
|
Target: ðpb.Checkpoint{Epoch: 0, Root: r32[:]},
|
|
},
|
|
AggregationBits: aggBits,
|
|
}
|
|
committee, err := helpers.BeaconCommitteeFromState(t.Context(), s, att.Data.Slot, att.Data.CommitteeIndex)
|
|
assert.NoError(t, err)
|
|
attestingIndices, err := attestation.AttestingIndices(att, committee)
|
|
require.NoError(t, err)
|
|
attesterDomain, err := signing.Domain(s.Fork(), 0, params.BeaconConfig().DomainBeaconAttester, s.GenesisValidatorsRoot())
|
|
require.NoError(t, err)
|
|
hashTreeRoot, err := signing.ComputeSigningRoot(att.Data, attesterDomain)
|
|
assert.NoError(t, err)
|
|
for _, i := range attestingIndices {
|
|
att.Signature = privKeys[i].Sign(hashTreeRoot[:]).Marshal()
|
|
}
|
|
|
|
// Arbitrary aggregator index for testing purposes.
|
|
aggregatorIndex := committee[0]
|
|
sszSlot := primitives.SSZUint64(att.Data.Slot)
|
|
sig, err := signing.ComputeDomainAndSign(s, 0, &sszSlot, params.BeaconConfig().DomainSelectionProof, privKeys[aggregatorIndex])
|
|
require.NoError(t, err)
|
|
aggregateAndProof := ðpb.AggregateAttestationAndProof{
|
|
SelectionProof: sig,
|
|
Aggregate: att,
|
|
AggregatorIndex: aggregatorIndex,
|
|
}
|
|
aggreSig, err := signing.ComputeDomainAndSign(s, 0, aggregateAndProof, params.BeaconConfig().DomainAggregateAndProof, privKeys[aggregatorIndex])
|
|
require.NoError(t, err)
|
|
|
|
require.NoError(t, s.SetGenesisTime(time.Now()))
|
|
ctx, cancel := context.WithCancel(t.Context())
|
|
chain2 := &mock.ChainService{Genesis: time.Now(),
|
|
State: s,
|
|
FinalizedCheckPoint: ðpb.Checkpoint{
|
|
Root: aggregateAndProof.Aggregate.Data.BeaconBlockRoot,
|
|
Epoch: 0,
|
|
}}
|
|
r = &Service{
|
|
ctx: ctx,
|
|
cfg: &config{
|
|
p2p: p1,
|
|
beaconDB: db,
|
|
chain: chain2,
|
|
clock: startup.NewClock(chain2.Genesis, chain2.ValidatorsRoot),
|
|
attPool: attestations.NewPool(),
|
|
attestationNotifier: &mock.MockOperationNotifier{},
|
|
},
|
|
blkRootToPendingAtts: make(map[[32]byte][]ethpb.SignedAggregateAttAndProof),
|
|
seenUnAggregatedAttestationCache: lruwrpr.New(10),
|
|
signatureChan: make(chan *signatureVerifier, verifierLimit),
|
|
}
|
|
go r.verifierRoutine()
|
|
|
|
r.blkRootToPendingAtts[r32] = []ethpb.SignedAggregateAttAndProof{ðpb.SignedAggregateAttestationAndProof{Message: aggregateAndProof, Signature: aggreSig}}
|
|
require.NoError(t, r.processPendingAtts(t.Context()))
|
|
|
|
assert.Equal(t, true, p1.BroadcastCalled.Load(), "Could not broadcast the good aggregate")
|
|
cancel()
|
|
}
|
|
|
|
func TestProcessPendingAtts_HasBlockSaveAggregatedAtt(t *testing.T) {
|
|
hook := logTest.NewGlobal()
|
|
db := dbtest.SetupDB(t)
|
|
p1 := p2ptest.NewTestP2P(t)
|
|
validators := uint64(256)
|
|
|
|
beaconState, privKeys := util.DeterministicGenesisState(t, validators)
|
|
|
|
sb := util.NewBeaconBlock()
|
|
util.SaveBlock(t, t.Context(), db, sb)
|
|
root, err := sb.Block.HashTreeRoot()
|
|
require.NoError(t, err)
|
|
|
|
aggBits := bitfield.NewBitlist(validators / uint64(params.BeaconConfig().SlotsPerEpoch))
|
|
aggBits.SetBitAt(0, true)
|
|
aggBits.SetBitAt(1, true)
|
|
att := ðpb.Attestation{
|
|
Data: ðpb.AttestationData{
|
|
BeaconBlockRoot: root[:],
|
|
Source: ðpb.Checkpoint{Epoch: 0, Root: bytesutil.PadTo([]byte("hello-world"), 32)},
|
|
Target: ðpb.Checkpoint{Epoch: 0, Root: root[:]},
|
|
},
|
|
AggregationBits: aggBits,
|
|
}
|
|
|
|
committee, err := helpers.BeaconCommitteeFromState(t.Context(), beaconState, att.Data.Slot, att.Data.CommitteeIndex)
|
|
assert.NoError(t, err)
|
|
attestingIndices, err := attestation.AttestingIndices(att, committee)
|
|
require.NoError(t, err)
|
|
attesterDomain, err := signing.Domain(beaconState.Fork(), 0, params.BeaconConfig().DomainBeaconAttester, beaconState.GenesisValidatorsRoot())
|
|
require.NoError(t, err)
|
|
hashTreeRoot, err := signing.ComputeSigningRoot(att.Data, attesterDomain)
|
|
assert.NoError(t, err)
|
|
sigs := make([]bls.Signature, len(attestingIndices))
|
|
for i, indice := range attestingIndices {
|
|
sig := privKeys[indice].Sign(hashTreeRoot[:])
|
|
sigs[i] = sig
|
|
}
|
|
att.Signature = bls.AggregateSignatures(sigs).Marshal()
|
|
|
|
// Arbitrary aggregator index for testing purposes.
|
|
aggregatorIndex := committee[0]
|
|
sszUint := primitives.SSZUint64(att.Data.Slot)
|
|
sig, err := signing.ComputeDomainAndSign(beaconState, 0, &sszUint, params.BeaconConfig().DomainSelectionProof, privKeys[aggregatorIndex])
|
|
require.NoError(t, err)
|
|
aggregateAndProof := ðpb.AggregateAttestationAndProof{
|
|
SelectionProof: sig,
|
|
Aggregate: att,
|
|
AggregatorIndex: aggregatorIndex,
|
|
}
|
|
aggreSig, err := signing.ComputeDomainAndSign(beaconState, 0, aggregateAndProof, params.BeaconConfig().DomainAggregateAndProof, privKeys[aggregatorIndex])
|
|
require.NoError(t, err)
|
|
|
|
require.NoError(t, beaconState.SetGenesisTime(time.Now()))
|
|
|
|
chain := &mock.ChainService{Genesis: time.Now(),
|
|
DB: db,
|
|
State: beaconState,
|
|
FinalizedCheckPoint: ðpb.Checkpoint{
|
|
Root: aggregateAndProof.Aggregate.Data.BeaconBlockRoot,
|
|
Epoch: 0,
|
|
}}
|
|
ctx, cancel := context.WithCancel(t.Context())
|
|
r := &Service{
|
|
ctx: ctx,
|
|
cfg: &config{
|
|
p2p: p1,
|
|
beaconDB: db,
|
|
chain: chain,
|
|
clock: startup.NewClock(chain.Genesis, chain.ValidatorsRoot),
|
|
attPool: attestations.NewPool(),
|
|
},
|
|
blkRootToPendingAtts: make(map[[32]byte][]ethpb.SignedAggregateAttAndProof),
|
|
seenAggregatedAttestationCache: lruwrpr.New(10),
|
|
signatureChan: make(chan *signatureVerifier, verifierLimit),
|
|
}
|
|
go r.verifierRoutine()
|
|
s, err := util.NewBeaconState()
|
|
require.NoError(t, err)
|
|
require.NoError(t, r.cfg.beaconDB.SaveState(t.Context(), s, root))
|
|
|
|
r.blkRootToPendingAtts[root] = []ethpb.SignedAggregateAttAndProof{ðpb.SignedAggregateAttestationAndProof{Message: aggregateAndProof, Signature: aggreSig}}
|
|
require.NoError(t, r.processPendingAtts(t.Context()))
|
|
|
|
assert.Equal(t, 1, len(r.cfg.attPool.AggregatedAttestations()), "Did not save aggregated att")
|
|
assert.DeepEqual(t, att, r.cfg.attPool.AggregatedAttestations()[0], "Incorrect saved att")
|
|
atts := r.cfg.attPool.UnaggregatedAttestations()
|
|
assert.Equal(t, 0, len(atts), "Did save aggregated att")
|
|
require.LogsContain(t, hook, "Verified and saved pending attestations to pool")
|
|
cancel()
|
|
}
|
|
|
|
func TestValidatePendingAtts_CanPruneOldAtts(t *testing.T) {
|
|
s := &Service{
|
|
blkRootToPendingAtts: make(map[[32]byte][]ethpb.SignedAggregateAttAndProof),
|
|
}
|
|
|
|
// 100 Attestations per block root.
|
|
r1 := [32]byte{'A'}
|
|
r2 := [32]byte{'B'}
|
|
r3 := [32]byte{'C'}
|
|
|
|
for i := primitives.Slot(0); i < 100; i++ {
|
|
s.savePendingAtt(ðpb.SignedAggregateAttestationAndProof{
|
|
Message: ðpb.AggregateAttestationAndProof{
|
|
AggregatorIndex: primitives.ValidatorIndex(i),
|
|
Aggregate: ðpb.Attestation{
|
|
Data: ðpb.AttestationData{Slot: i, BeaconBlockRoot: r1[:]}}}})
|
|
s.savePendingAtt(ðpb.SignedAggregateAttestationAndProof{
|
|
Message: ðpb.AggregateAttestationAndProof{
|
|
AggregatorIndex: primitives.ValidatorIndex(i*2 + i),
|
|
Aggregate: ðpb.Attestation{
|
|
Data: ðpb.AttestationData{Slot: i, BeaconBlockRoot: r2[:]}}}})
|
|
s.savePendingAtt(ðpb.SignedAggregateAttestationAndProof{
|
|
Message: ðpb.AggregateAttestationAndProof{
|
|
AggregatorIndex: primitives.ValidatorIndex(i*3 + i),
|
|
Aggregate: ðpb.Attestation{
|
|
Data: ðpb.AttestationData{Slot: i, BeaconBlockRoot: r3[:]}}}})
|
|
}
|
|
|
|
assert.Equal(t, 100, len(s.blkRootToPendingAtts[r1]), "Did not save pending atts")
|
|
assert.Equal(t, 100, len(s.blkRootToPendingAtts[r2]), "Did not save pending atts")
|
|
assert.Equal(t, 100, len(s.blkRootToPendingAtts[r3]), "Did not save pending atts")
|
|
|
|
// Set current slot to 50, it should prune 19 attestations. (50 - 31)
|
|
s.validatePendingAtts(t.Context(), 50)
|
|
assert.Equal(t, 81, len(s.blkRootToPendingAtts[r1]), "Did not delete pending atts")
|
|
assert.Equal(t, 81, len(s.blkRootToPendingAtts[r2]), "Did not delete pending atts")
|
|
assert.Equal(t, 81, len(s.blkRootToPendingAtts[r3]), "Did not delete pending atts")
|
|
|
|
// Set current slot to 100 + slot_duration, it should prune all the attestations.
|
|
s.validatePendingAtts(t.Context(), 100+params.BeaconConfig().SlotsPerEpoch)
|
|
assert.Equal(t, 0, len(s.blkRootToPendingAtts[r1]), "Did not delete pending atts")
|
|
assert.Equal(t, 0, len(s.blkRootToPendingAtts[r2]), "Did not delete pending atts")
|
|
assert.Equal(t, 0, len(s.blkRootToPendingAtts[r3]), "Did not delete pending atts")
|
|
|
|
// Verify the keys are deleted.
|
|
assert.Equal(t, 0, len(s.blkRootToPendingAtts), "Did not delete block keys")
|
|
}
|
|
|
|
func TestValidatePendingAtts_NoDuplicatingAtts(t *testing.T) {
|
|
s := &Service{
|
|
blkRootToPendingAtts: make(map[[32]byte][]ethpb.SignedAggregateAttAndProof),
|
|
}
|
|
|
|
r1 := [32]byte{'A'}
|
|
r2 := [32]byte{'B'}
|
|
s.savePendingAtt(ðpb.SignedAggregateAttestationAndProof{
|
|
Message: ðpb.AggregateAttestationAndProof{
|
|
AggregatorIndex: 1,
|
|
Aggregate: ðpb.Attestation{
|
|
Data: ðpb.AttestationData{Slot: 1, BeaconBlockRoot: r1[:]}}}})
|
|
s.savePendingAtt(ðpb.SignedAggregateAttestationAndProof{
|
|
Message: ðpb.AggregateAttestationAndProof{
|
|
AggregatorIndex: 2,
|
|
Aggregate: ðpb.Attestation{
|
|
Data: ðpb.AttestationData{Slot: 2, BeaconBlockRoot: r2[:]}}}})
|
|
s.savePendingAtt(ðpb.SignedAggregateAttestationAndProof{
|
|
Message: ðpb.AggregateAttestationAndProof{
|
|
AggregatorIndex: 2,
|
|
Aggregate: ðpb.Attestation{
|
|
Data: ðpb.AttestationData{Slot: 2, BeaconBlockRoot: r2[:]}}}})
|
|
|
|
assert.Equal(t, 1, len(s.blkRootToPendingAtts[r1]), "Did not save pending atts")
|
|
assert.Equal(t, 1, len(s.blkRootToPendingAtts[r2]), "Did not save pending atts")
|
|
}
|
|
|
|
func TestSavePendingAtts_BeyondLimit(t *testing.T) {
|
|
s := &Service{
|
|
blkRootToPendingAtts: make(map[[32]byte][]ethpb.SignedAggregateAttAndProof),
|
|
}
|
|
|
|
for i := 0; i < pendingAttsLimit; i++ {
|
|
s.savePendingAtt(ðpb.SignedAggregateAttestationAndProof{
|
|
Message: ðpb.AggregateAttestationAndProof{
|
|
AggregatorIndex: primitives.ValidatorIndex(i),
|
|
Aggregate: ðpb.Attestation{
|
|
Data: ðpb.AttestationData{Slot: 1, BeaconBlockRoot: bytesutil.Bytes32(uint64(i))}}}})
|
|
}
|
|
r1 := [32]byte(bytesutil.Bytes32(0))
|
|
r2 := [32]byte(bytesutil.Bytes32(uint64(pendingAttsLimit) - 1))
|
|
|
|
assert.Equal(t, 1, len(s.blkRootToPendingAtts[r1]), "Did not save pending atts")
|
|
assert.Equal(t, 1, len(s.blkRootToPendingAtts[r2]), "Did not save pending atts")
|
|
|
|
for i := pendingAttsLimit; i < pendingAttsLimit+20; i++ {
|
|
s.savePendingAtt(ðpb.SignedAggregateAttestationAndProof{
|
|
Message: ðpb.AggregateAttestationAndProof{
|
|
AggregatorIndex: primitives.ValidatorIndex(i),
|
|
Aggregate: ðpb.Attestation{
|
|
Data: ðpb.AttestationData{Slot: 1, BeaconBlockRoot: bytesutil.Bytes32(uint64(i))}}}})
|
|
}
|
|
|
|
r1 = [32]byte(bytesutil.Bytes32(uint64(pendingAttsLimit)))
|
|
r2 = [32]byte(bytesutil.Bytes32(uint64(pendingAttsLimit) + 10))
|
|
|
|
assert.Equal(t, 0, len(s.blkRootToPendingAtts[r1]), "Saved pending atts")
|
|
assert.Equal(t, 0, len(s.blkRootToPendingAtts[r2]), "Saved pending atts")
|
|
}
|
|
|
|
func Test_attsAreEqual_Committee(t *testing.T) {
|
|
t.Run("Phase 0 equal", func(t *testing.T) {
|
|
att1 := ðpb.SignedAggregateAttestationAndProof{
|
|
Message: ðpb.AggregateAttestationAndProof{
|
|
Aggregate: ðpb.Attestation{
|
|
Data: ðpb.AttestationData{
|
|
CommitteeIndex: 0}}}}
|
|
att2 := ðpb.SignedAggregateAttestationAndProof{
|
|
Message: ðpb.AggregateAttestationAndProof{
|
|
Aggregate: ðpb.Attestation{
|
|
Data: ðpb.AttestationData{
|
|
CommitteeIndex: 0}}}}
|
|
assert.Equal(t, true, attsAreEqual(att1, att2))
|
|
})
|
|
t.Run("Phase 0 not equal", func(t *testing.T) {
|
|
att1 := ðpb.SignedAggregateAttestationAndProof{
|
|
Message: ðpb.AggregateAttestationAndProof{
|
|
Aggregate: ðpb.Attestation{
|
|
Data: ðpb.AttestationData{
|
|
CommitteeIndex: 0}}}}
|
|
att2 := ðpb.SignedAggregateAttestationAndProof{
|
|
Message: ðpb.AggregateAttestationAndProof{
|
|
Aggregate: ðpb.Attestation{
|
|
Data: ðpb.AttestationData{
|
|
CommitteeIndex: 1}}}}
|
|
assert.Equal(t, false, attsAreEqual(att1, att2))
|
|
})
|
|
t.Run("Electra equal", func(t *testing.T) {
|
|
cb1 := primitives.NewAttestationCommitteeBits()
|
|
cb1.SetBitAt(0, true)
|
|
att1 := ðpb.SignedAggregateAttestationAndProofElectra{
|
|
Message: ðpb.AggregateAttestationAndProofElectra{
|
|
Aggregate: ðpb.AttestationElectra{
|
|
Data: ðpb.AttestationData{},
|
|
CommitteeBits: cb1,
|
|
}}}
|
|
cb2 := primitives.NewAttestationCommitteeBits()
|
|
cb2.SetBitAt(0, true)
|
|
att2 := ðpb.SignedAggregateAttestationAndProofElectra{
|
|
Message: ðpb.AggregateAttestationAndProofElectra{
|
|
Aggregate: ðpb.AttestationElectra{
|
|
Data: ðpb.AttestationData{},
|
|
CommitteeBits: cb2,
|
|
}}}
|
|
assert.Equal(t, true, attsAreEqual(att1, att2))
|
|
})
|
|
t.Run("Electra not equal", func(t *testing.T) {
|
|
cb1 := primitives.NewAttestationCommitteeBits()
|
|
cb1.SetBitAt(0, true)
|
|
att1 := ðpb.SignedAggregateAttestationAndProofElectra{
|
|
Message: ðpb.AggregateAttestationAndProofElectra{
|
|
Aggregate: ðpb.AttestationElectra{
|
|
Data: ðpb.AttestationData{},
|
|
CommitteeBits: cb1,
|
|
}}}
|
|
cb2 := primitives.NewAttestationCommitteeBits()
|
|
cb2.SetBitAt(1, true)
|
|
att2 := ðpb.SignedAggregateAttestationAndProofElectra{
|
|
Message: ðpb.AggregateAttestationAndProofElectra{
|
|
Aggregate: ðpb.AttestationElectra{
|
|
Data: ðpb.AttestationData{},
|
|
CommitteeBits: cb2,
|
|
}}}
|
|
assert.Equal(t, false, attsAreEqual(att1, att2))
|
|
})
|
|
t.Run("Single and Electra not equal", func(t *testing.T) {
|
|
cb := primitives.NewAttestationCommitteeBits()
|
|
cb.SetBitAt(0, true)
|
|
att1 := ðpb.SignedAggregateAttestationAndProofElectra{
|
|
Message: ðpb.AggregateAttestationAndProofElectra{
|
|
Aggregate: ðpb.AttestationElectra{
|
|
Data: ðpb.AttestationData{},
|
|
CommitteeBits: cb,
|
|
}}}
|
|
att2 := ðpb.SignedAggregateAttestationAndProofSingle{
|
|
Message: ðpb.AggregateAttestationAndProofSingle{
|
|
Aggregate: ðpb.SingleAttestation{
|
|
CommitteeId: 0,
|
|
AttesterIndex: 0,
|
|
Data: ðpb.AttestationData{},
|
|
},
|
|
},
|
|
}
|
|
assert.Equal(t, false, attsAreEqual(att1, att2))
|
|
})
|
|
t.Run("Single equal", func(t *testing.T) {
|
|
att1 := ðpb.SignedAggregateAttestationAndProofSingle{
|
|
Message: ðpb.AggregateAttestationAndProofSingle{
|
|
Aggregate: ðpb.SingleAttestation{
|
|
CommitteeId: 0,
|
|
AttesterIndex: 0,
|
|
Data: ðpb.AttestationData{},
|
|
},
|
|
},
|
|
}
|
|
att2 := ðpb.SignedAggregateAttestationAndProofSingle{
|
|
Message: ðpb.AggregateAttestationAndProofSingle{
|
|
Aggregate: ðpb.SingleAttestation{
|
|
CommitteeId: 0,
|
|
AttesterIndex: 0,
|
|
Data: ðpb.AttestationData{},
|
|
},
|
|
},
|
|
}
|
|
assert.Equal(t, true, attsAreEqual(att1, att2))
|
|
})
|
|
t.Run("Single not equal", func(t *testing.T) {
|
|
// Same AttesterIndex but different CommitteeId
|
|
att1 := ðpb.SignedAggregateAttestationAndProofSingle{
|
|
Message: ðpb.AggregateAttestationAndProofSingle{
|
|
Aggregate: ðpb.SingleAttestation{
|
|
CommitteeId: 0,
|
|
AttesterIndex: 0,
|
|
Data: ðpb.AttestationData{},
|
|
},
|
|
},
|
|
}
|
|
att2 := ðpb.SignedAggregateAttestationAndProofSingle{
|
|
Message: ðpb.AggregateAttestationAndProofSingle{
|
|
Aggregate: ðpb.SingleAttestation{
|
|
CommitteeId: 1,
|
|
AttesterIndex: 0,
|
|
Data: ðpb.AttestationData{},
|
|
},
|
|
},
|
|
}
|
|
assert.Equal(t, false, attsAreEqual(att1, att2))
|
|
|
|
// Same CommitteeId but different AttesterIndex
|
|
att2.Message.Aggregate.CommitteeId = 0
|
|
att2.Message.Aggregate.AttesterIndex = 1
|
|
assert.Equal(t, false, attsAreEqual(att1, att2))
|
|
})
|
|
}
|