Files
prysm/validator/accounts/wallet/wallet_test.go
james-prysm 539b981ac3 Web3signer: persistent public keys (#13682)
* WIP

* broken and still wip

* more wip improving saving

* wip

* removing cyclic dependency

* gaz

* fixes

* fixing more tests and how files load

* fixing wallet tests

* fixing test

* updating keymanager tests

* improving how the web3signer keymanager works

* WIP

* updated keymanager to read from file

* gaz

* reuse readkeyfile function and add in duplicate keys check

* adding in locks to increase safety

* refactored how saving keys work, more tests needed:

* fix test

* fix tests

* adding unit tests and cleaning up locks

* fixing tests

* tests were not fixed properly

* removing unneeded files

* Update cmd/validator/accounts/wallet_utils.go

Co-authored-by: Sammy Rosso <15244892+saolyn@users.noreply.github.com>

* Update validator/accounts/wallet/wallet.go

Co-authored-by: Sammy Rosso <15244892+saolyn@users.noreply.github.com>

* review feedback

* updating flags and e2e

* deepsource fix

* resolving feedback

* removing fatal test for now

* addressing manu's feedback

* gofmt

* fixing tests

* fixing unit tests

* more idomatic feedback

* updating log files

* updating based on preston's suggestion

* improving logs and event triggers

* addressing comments from manu

* truncating was not triggering key file reload

* fixing unit test

* removing wrong dependency

* fix another broken unit test

* fixing bad pathing on file

* handle errors in test

* fixing testdata dependency

* resolving deepsource and comment around logs

* removing unneeded buffer

* reworking ux of web3signer file, unit tests to come

* adding unit tests for file change retries

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Sammy Rosso <15244892+saolyn@users.noreply.github.com>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Sammy Rosso <15244892+saolyn@users.noreply.github.com>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Sammy Rosso <15244892+saolyn@users.noreply.github.com>

* updating based on review feedback

* missed err check

* adding some aliases to make running easier

* Update validator/keymanager/remote-web3signer/log.go

Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* radek's review

* Update validator/keymanager/remote-web3signer/internal/client.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* Update validator/keymanager/remote-web3signer/keymanager.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

* addressing more review feedback and linting

* fixing tests

* adding log

* adding 1 more test

* improving logs

---------

Co-authored-by: Sammy Rosso <15244892+saolyn@users.noreply.github.com>
Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
2024-06-26 15:36:32 +00:00

181 lines
6.0 KiB
Go

package wallet_test
import (
"context"
"flag"
"io"
"os"
"path/filepath"
"reflect"
"testing"
"github.com/ethereum/go-ethereum/common/hexutil"
"github.com/prysmaticlabs/prysm/v5/cmd/validator/flags"
"github.com/prysmaticlabs/prysm/v5/config/params"
"github.com/prysmaticlabs/prysm/v5/testing/assert"
"github.com/prysmaticlabs/prysm/v5/testing/require"
"github.com/prysmaticlabs/prysm/v5/validator/accounts/iface"
"github.com/prysmaticlabs/prysm/v5/validator/accounts/wallet"
"github.com/prysmaticlabs/prysm/v5/validator/keymanager"
remoteweb3signer "github.com/prysmaticlabs/prysm/v5/validator/keymanager/remote-web3signer"
"github.com/sirupsen/logrus"
"github.com/urfave/cli/v2"
)
func init() {
logrus.SetLevel(logrus.DebugLevel)
logrus.SetOutput(io.Discard)
}
func Test_Exists_RandomFiles(t *testing.T) {
path := filepath.Join(t.TempDir(), "wallet")
exists, err := wallet.Exists(path)
require.Equal(t, false, exists)
require.NoError(t, err)
require.NoError(t, os.MkdirAll(path+"/direct", params.BeaconIoConfig().ReadWriteExecutePermissions), "Failed to create directory")
exists, err = wallet.Exists(path)
require.NoError(t, err)
require.Equal(t, true, exists)
}
func Test_IsValid_RandomFiles(t *testing.T) {
path := filepath.Join(t.TempDir(), "wallet")
valid, err := wallet.IsValid(path)
require.NoError(t, err)
require.Equal(t, false, valid)
require.NoError(t, os.MkdirAll(path, params.BeaconIoConfig().ReadWriteExecutePermissions), "Failed to create directory")
valid, err = wallet.IsValid(path)
require.ErrorContains(t, "no wallet found", err)
require.Equal(t, false, valid)
walletDir := filepath.Join(path, "direct")
require.NoError(t, os.MkdirAll(walletDir, params.BeaconIoConfig().ReadWriteExecutePermissions), "Failed to create directory")
valid, err = wallet.IsValid(path)
require.NoError(t, err)
require.Equal(t, true, valid)
}
func TestWallet_InitializeKeymanager_web3Signer_HappyPath(t *testing.T) {
app := cli.App{}
set := flag.NewFlagSet("test", 0)
newDir := filepath.Join(t.TempDir(), "new")
set.String(flags.WalletDirFlag.Name, newDir, "")
w := wallet.NewWalletForWeb3Signer(cli.NewContext(&app, set, nil))
ctx := context.Background()
root, err := hexutil.Decode("0x270d43e74ce340de4bca2b1936beca0f4f5408d9e78aec4850920baf659d5b69")
require.NoError(t, err)
config := iface.InitKeymanagerConfig{
ListenForChanges: false,
Web3SignerConfig: &remoteweb3signer.SetupConfig{
BaseEndpoint: "http://localhost:8545",
GenesisValidatorsRoot: root,
},
}
km, err := w.InitializeKeymanager(ctx, config)
require.NoError(t, err)
assert.NotNil(t, km)
}
func TestWallet_InitializeKeymanager_web3Signer_nilConfig(t *testing.T) {
app := cli.App{}
set := flag.NewFlagSet("test", 0)
newDir := filepath.Join(t.TempDir(), "new")
set.String(flags.WalletDirFlag.Name, newDir, "")
w := wallet.NewWalletForWeb3Signer(cli.NewContext(&app, set, nil))
ctx := context.Background()
config := iface.InitKeymanagerConfig{
ListenForChanges: false,
Web3SignerConfig: nil,
}
km, err := w.InitializeKeymanager(ctx, config)
assert.NotNil(t, err)
assert.Equal(t, nil, km)
}
func TestOpenOrCreateNewWallet(t *testing.T) {
walletDir := filepath.Join(t.TempDir(), "wallet")
newDir := filepath.Join(t.TempDir(), "new")
passwordFileDir := filepath.Join(t.TempDir(), "passwordFile")
require.NoError(t, os.MkdirAll(passwordFileDir, params.BeaconIoConfig().ReadWriteExecutePermissions))
passwordFilePath1 := filepath.Join(passwordFileDir, "password1.txt")
passwordFilePath2 := filepath.Join(passwordFileDir, "password2.txt")
type args struct {
cliCtx *cli.Context
}
tests := []struct {
name string
args args
want *wallet.Wallet
wantErr bool
}{
{
name: "New Wallet",
args: args{
cliCtx: func() *cli.Context {
app := cli.App{}
set := flag.NewFlagSet("test", 0)
require.NoError(t, os.MkdirAll(newDir, 0700))
require.NoError(t, os.WriteFile(passwordFilePath1, []byte("newnewnew"), os.ModePerm))
set.String(flags.WalletDirFlag.Name, newDir, "") // don't set it
set.String(flags.KeymanagerKindFlag.Name, keymanager.Local.String(), "")
set.String(flags.WalletPasswordFileFlag.Name, passwordFilePath1, "")
assert.NoError(t, set.Set(flags.KeymanagerKindFlag.Name, keymanager.Local.String()))
assert.NoError(t, set.Set(flags.WalletPasswordFileFlag.Name, passwordFilePath1))
return cli.NewContext(&app, set, nil)
}(),
},
want: wallet.New(&wallet.Config{
WalletDir: newDir,
KeymanagerKind: keymanager.Local,
WalletPassword: "newnewnew",
}),
},
{
name: "Existing Wallet",
args: args{
cliCtx: func() *cli.Context {
app := cli.App{}
set := flag.NewFlagSet("test", 0)
set.String(flags.WalletDirFlag.Name, walletDir, "")
set.String(flags.KeymanagerKindFlag.Name, keymanager.Local.String(), "")
set.String(flags.WalletPasswordFileFlag.Name, passwordFilePath2, "")
require.NoError(t, os.WriteFile(passwordFilePath2, []byte("existing"), os.ModePerm))
w := wallet.New(&wallet.Config{
WalletDir: walletDir,
KeymanagerKind: keymanager.Local,
WalletPassword: "existing",
})
require.NoError(t, w.SaveWallet())
assert.NoError(t, set.Set(flags.WalletDirFlag.Name, walletDir))
assert.NoError(t, set.Set(flags.KeymanagerKindFlag.Name, keymanager.Local.String()))
assert.NoError(t, set.Set(flags.WalletPasswordFileFlag.Name, passwordFilePath2))
return cli.NewContext(&app, set, nil)
}(),
},
want: wallet.New(&wallet.Config{
WalletDir: walletDir,
KeymanagerKind: keymanager.Local,
WalletPassword: "existing",
}),
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got, err := wallet.OpenOrCreateNewWallet(tt.args.cliCtx)
if (err != nil) != tt.wantErr {
t.Errorf("OpenOrCreateNewWallet() error = %v, wantErr %v", err, tt.wantErr)
return
}
if !reflect.DeepEqual(got, tt.want) {
t.Errorf("OpenOrCreateNewWallet() got = %v, want %v", got, tt.want)
}
})
}
}