Files
prysm/beacon-chain/state/state-native/setters_payload_header_test.go
Preston Van Loon 2fd6bd8150 Add golang.org/x/tools modernize static analyzer and fix violations (#15946)
* Ran gopls modernize to fix everything

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...

* Override rules_go provided dependency for golang.org/x/tools to v0.38.0.

To update this, checked out rules_go, then ran `bazel run //go/tools/releaser -- upgrade-dep -mirror=false org_golang_x_tools` and copied the patches.

* Fix buildtag violations and ignore buildtag violations in external

* Introduce modernize analyzer package.

* Add modernize "any" analyzer.

* Fix violations of any analyzer

* Add modernize "appendclipped" analyzer.

* Fix violations of appendclipped

* Add modernize "bloop" analyzer.

* Add modernize "fmtappendf" analyzer.

* Add modernize "forvar" analyzer.

* Add modernize "mapsloop" analyzer.

* Add modernize "minmax" analyzer.

* Fix violations of minmax analyzer

* Add modernize "omitzero" analyzer.

* Add modernize "rangeint" analyzer.

* Fix violations of rangeint.

* Add modernize "reflecttypefor" analyzer.

* Fix violations of reflecttypefor analyzer.

* Add modernize "slicescontains" analyzer.

* Add modernize "slicessort" analyzer.

* Add modernize "slicesdelete" analyzer. This is disabled by default for now. See https://go.dev/issue/73686.

* Add modernize "stringscutprefix" analyzer.

* Add modernize "stringsbuilder" analyzer.

* Fix violations of stringsbuilder analyzer.

* Add modernize "stringsseq" analyzer.

* Add modernize "testingcontext" analyzer.

* Add modernize "waitgroup" analyzer.

* Changelog fragment

* gofmt

* gazelle

* Add modernize "newexpr" analyzer.

* Disable newexpr until go1.26

* Add more details in WORKSPACE on how to update the override

* @nalepae feedback on min()

* gofmt

* Fix violations of forvar
2025-11-14 01:27:22 +00:00

115 lines
3.8 KiB
Go

package state_native_test
import (
"fmt"
"testing"
state_native "github.com/OffchainLabs/prysm/v7/beacon-chain/state/state-native"
"github.com/OffchainLabs/prysm/v7/consensus-types/blocks"
"github.com/OffchainLabs/prysm/v7/consensus-types/interfaces"
"github.com/OffchainLabs/prysm/v7/runtime/version"
"github.com/OffchainLabs/prysm/v7/testing/require"
"github.com/OffchainLabs/prysm/v7/testing/util"
)
func TestSetLatestExecutionPayloadHeader(t *testing.T) {
versionOffset := version.Bellatrix // PayloadHeader only applies in Bellatrix and beyond.
payloads := []interfaces.ExecutionData{
func() interfaces.ExecutionData {
e := util.NewBeaconBlockBellatrix().Block.Body.ExecutionPayload
ee, err := blocks.WrappedExecutionPayload(e)
require.NoError(t, err)
return ee
}(),
func() interfaces.ExecutionData {
e := util.NewBeaconBlockCapella().Block.Body.ExecutionPayload
ee, err := blocks.WrappedExecutionPayloadCapella(e)
require.NoError(t, err)
return ee
}(),
func() interfaces.ExecutionData {
e := util.NewBeaconBlockDeneb().Block.Body.ExecutionPayload
ee, err := blocks.WrappedExecutionPayloadDeneb(e)
require.NoError(t, err)
return ee
}(),
func() interfaces.ExecutionData {
e := util.NewBeaconBlockElectra().Block.Body.ExecutionPayload
ee, err := blocks.WrappedExecutionPayloadDeneb(e)
require.NoError(t, err)
return ee
}(),
}
payloadHeaders := []interfaces.ExecutionData{
func() interfaces.ExecutionData {
e := util.NewBlindedBeaconBlockBellatrix().Block.Body.ExecutionPayloadHeader
ee, err := blocks.WrappedExecutionPayloadHeader(e)
require.NoError(t, err)
return ee
}(),
func() interfaces.ExecutionData {
e := util.NewBlindedBeaconBlockCapella().Block.Body.ExecutionPayloadHeader
ee, err := blocks.WrappedExecutionPayloadHeaderCapella(e)
require.NoError(t, err)
return ee
}(),
func() interfaces.ExecutionData {
e := util.NewBlindedBeaconBlockDeneb().Message.Body.ExecutionPayloadHeader
ee, err := blocks.WrappedExecutionPayloadHeaderDeneb(e)
require.NoError(t, err)
return ee
}(),
func() interfaces.ExecutionData {
e := util.NewBlindedBeaconBlockElectra().Message.Body.ExecutionPayloadHeader
ee, err := blocks.WrappedExecutionPayloadHeaderDeneb(e)
require.NoError(t, err)
return ee
}(),
}
t.Run("can set payload", func(t *testing.T) {
for i, p := range payloads {
t.Run(version.String(i+versionOffset), func(t *testing.T) {
s := state_native.EmptyStateFromVersion(t, i+versionOffset)
require.NoError(t, s.SetLatestExecutionPayloadHeader(p))
})
}
})
t.Run("can set payload header", func(t *testing.T) {
for i, ph := range payloadHeaders {
t.Run(version.String(i+versionOffset), func(t *testing.T) {
s := state_native.EmptyStateFromVersion(t, i+versionOffset)
require.NoError(t, s.SetLatestExecutionPayloadHeader(ph))
})
}
})
t.Run("mismatched type version returns error", func(t *testing.T) {
require.Equal(t, len(payloads), len(payloadHeaders), "This test will fail if the payloads and payload headers are not same length")
for i := range payloads {
for j := range payloads {
if i == j {
continue
}
// Skip Deneb-Electra combinations
if i == len(payloads)-1 && j == len(payloads)-2 {
continue
}
if i == len(payloads)-2 && j == len(payloads)-1 {
continue
}
t.Run(fmt.Sprintf("%s state with %s payload", version.String(i+versionOffset), version.String(j+versionOffset)), func(t *testing.T) {
s := state_native.EmptyStateFromVersion(t, i+versionOffset)
p := payloads[j]
require.ErrorContains(t, "wrong state version", s.SetLatestExecutionPayloadHeader(p))
ph := payloadHeaders[j]
require.ErrorContains(t, "wrong state version", s.SetLatestExecutionPayloadHeader(ph))
})
}
}
})
}