Commit Graph

19351 Commits

Author SHA1 Message Date
Charlie Somerville
5799f9a063 convert DateTime to Time before quoting in database 2014-05-14 16:32:07 +10:00
Charlie Somerville
b29a709afd cve-2014-0130 2014-05-12 10:55:01 +10:00
Charlie Somerville
29c0decb37 Merge pull request #66 from github/3-0-github-perf
Bring a few perf patches to 3-0-github from 2-3-github
2014-05-01 19:25:13 +10:00
Charlie Somerville
d1b7819eed short-circuit String#blank? if empty 2014-05-01 18:09:13 +10:00
Charlie Somerville
b22e96751d use faster regex for String#blank?
Calculating -------------------------------------
              before      2687 i/100ms
               after      3867 i/100ms
-------------------------------------------------
              before    27978.4 (±2.0%) i/s -     142411 in   5.092192s
               after    40533.0 (±2.8%) i/s -     204951 in   5.060652s
2014-05-01 18:05:11 +10:00
Charlie Somerville
68528d9c0e avoid html_safe? method call 2014-05-01 18:02:09 +10:00
Charlie Somerville
c9561099cd apply the newlines pending patch 2014-05-01 17:55:12 +10:00
Charlie Somerville
7d14c436ba Merge pull request #65 from github/3-0-github+faster-attr-lookup
[3.0] Faster attr lookup
2014-04-29 19:57:15 +10:00
Charlie Somerville
1aed8fbf40 don't bother checking for respond_to? here 2014-04-29 19:06:19 +10:00
Charlie Somerville
cab18f1607 allocate less objects 2014-04-29 19:06:19 +10:00
Charlie Somerville
7a04473603 Fewer object allocations
Conflicts:
	activemodel/lib/active_model/attribute_methods.rb
2014-04-29 19:06:19 +10:00
Charlie Somerville
e6fab3aba1 Cheaper attribute_method_matchers
Conflicts:
	activemodel/lib/active_model/attribute_methods.rb
2014-04-29 19:06:19 +10:00
Jeremy Kemper
3f0f6047ab Fix require for class_attribute 2014-04-29 19:06:19 +10:00
Charlie Somerville
5bfa1a0eb4 Merge pull request #62 from github/3-0-github+has_many-count-with-distinct
Fix weird unique has_many count bug we're seeing
2014-04-24 17:11:05 +10:00
Charlie Somerville
67709ccc58 properly set distinct if select_values starts with DISTINCT 2014-04-23 20:05:00 +10:00
Charlie Somerville
fd102d2987 add failing test for weird has_many :uniq count bug we're seeing 2014-04-23 18:19:25 +10:00
Charlie Somerville
494fc9ea8a fix flakey logger test 2014-04-11 16:37:54 +10:00
Charlie Somerville
de6c5564e4 check in Gemfile.lock 2014-04-11 16:35:06 +10:00
Charlie Somerville
3542d3d623 delegate pluck to scoped
cc @rsanheim
2014-04-10 17:20:30 +10:00
Charlie Somerville
b714de3f2b Merge pull request #55 from github/3-0-github+pluck
Backport pluck to 3-0-github
2014-04-10 15:58:34 +10:00
Charlie Somerville
3cf7ccde48 backport pluck to 3-0-github 2014-04-10 15:52:38 +10:00
Dirkjan Bussink
ad50d74a13 Merge pull request #54 from github/dbussink/bump-rails30-exception
Don't rescue toplevel Exception
2014-04-02 12:40:54 +00:00
Dirkjan Bussink
117dc4a85a Don't rescue toplevel Exception 2014-03-31 13:46:20 +02:00
Charlie Somerville
be36d0222b Merge pull request #52 from github/3-0-github-byteslice-cache
Use byteslice instead of slice in fragment_for
2014-03-31 19:15:33 +11:00
Charlie Somerville
1064e75c63 use byteslice instead of slice in fragment_for 2014-03-31 19:11:18 +11:00
Charlie Somerville
787f31dd95 Merge pull request #50 from github/3-0-github+ci
Run tests for 3-0-github in CI
2014-03-31 14:08:42 +11:00
Charlie Somerville
063f7ec6d9 delete debugging code 2014-03-20 13:48:55 +11:00
Charlie Somerville
512cc3fde1 in fact forget the railties tests 2014-03-20 13:44:04 +11:00
Charlie Somerville
a544354455 just test on sqlite3 2014-03-19 23:18:55 +11:00
Charlie Somerville
f973bd7a37 god rails is a shit show 2014-03-19 23:16:26 +11:00
Charlie Somerville
eedf2e0df5 add some skips and small tweaks to get tests passing 2014-03-19 22:57:30 +11:00
Charlie Somerville
478459b602 fix activesupport tests 2014-03-19 21:54:45 +11:00
Charlie Somerville
8405a07588 fix actionmailer tests 2014-03-19 21:42:36 +11:00
Charlie Somerville
8069888f39 some respond_to? fixes 2014-03-19 21:28:37 +11:00
Charlie Somerville
0d1e06e91a don't pass nil elements into Hash[] 2014-03-19 21:28:25 +11:00
Charlie Somerville
b7fdf446b3 raise on respond_to changes 2014-03-19 21:11:52 +11:00
Charlie Somerville
6a5c4448bf respond_to? 2014-03-19 21:11:45 +11:00
Charlie Somerville
7824f7fe96 respond_to? fix 2014-03-19 20:13:22 +11:00
Charlie Somerville
cc24b24b00 nil is now encoded as <blah nil="true"/> 2014-03-19 19:55:22 +11:00
Charlie Somerville
997fe9a94e fix for ruby 2.0+ respond_to? changes 2014-03-19 19:54:35 +11:00
Charlie Somerville
9527562a4a add pry to gemfile to aid debugging 2014-03-19 19:54:11 +11:00
Charlie Somerville
db8c48caf7 add magic encoding comments to files with dodgy chars 2014-03-19 19:14:34 +11:00
Charlie Somerville
60eb2e5586 delete troublesome platforms 2014-03-19 19:08:56 +11:00
Charlie Somerville
12b11ea207 announce what ruby version we're running 2014-03-19 19:07:46 +11:00
Charlie Somerville
0d0a061f27 add script/cibuild 2014-03-19 19:02:21 +11:00
Charlie Somerville
66f4a900c6 vendor gems 2014-03-19 19:00:48 +11:00
Charlie Somerville
5f31e732ce Merge pull request #49 from github/3-0-kill-backtick-monkey-patch
[3.0] Kill Object#` monkey patch
2014-02-23 23:20:55 +11:00
Charlie Somerville
04f3d5048e kill Object#` monkey patch 2014-02-23 23:19:13 +11:00
Aman Gupta
bfe82ff609 add RouteSet#recognize_path(path, :extras => params) for forward-compat with rails4 2014-02-17 18:42:50 -08:00
Charlie Somerville
5ce29715d5 backport rails 3.2 ActiveSupport::MessageVerifier 2014-02-07 11:31:09 +11:00