AtHeartEngineer/specs
1
0
Fork 0
mirror of https://github.com/vacp2p/specs.git synced 2026-01-09 15:28:03 -05:00
Code Issues Packages Projects Releases Wiki Activity

rendezvous: Change ttl and limit to uint64 (#338)

Browse Source 
To be meaningful, TTL has to be a positive integer hence the use of
an signed integer does not bring any value and only introduces
unnecessary error handling.

Limiting the number of responses makes only sense if it is a positive
integer.
This commit is contained in:
Thomas Eizinger
2021-06-28 19:00:48 +10:00
committed by GitHub
parent a27dd9e97e
commit ed021a9980
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
rendezvous/README.md
View File

@@ -2,7 +2,7 @@
| Lifecycle Stage | Maturity | Status | Latest Revision |
|-----------------|---------------|--------|-----------------|
| 1A | Working Draft | Active | r1, 2019-01-18 |
| 1A | Working Draft | Active | r2, 2021-06-24 |
Authors: [@vyzo]
@@ -214,13 +214,13 @@ message Message {
message Register {
optional string ns = 1;
optional bytes signedPeerRecord = 2;
optional int64 ttl = 3; // in seconds
optional uint64 ttl = 3; // in seconds
}
message RegisterResponse {
optional ResponseStatus status = 1;
optional string statusText = 2;
optional int64 ttl = 3; // in seconds
optional uint64 ttl = 3; // in seconds
}
message Unregister {
@@ -230,7 +230,7 @@ message Message {
message Discover {
optional string ns = 1;
optional int64 limit = 2;
optional uint64 limit = 2;
optional bytes cookie = 3;
}