AtHeartEngineer/specs
1
0
Fork 0
mirror of https://github.com/vacp2p/specs.git synced 2026-01-09 07:17:56 -05:00
Code Issues Packages Projects Releases Wiki Activity

relay/DCUtR: Make message type field required (#375)

Browse Source 
The `type` field of the DCUtR message definition should not be
`optional`, as a message without a `Type` is useless. Instead it should
be `required`.

See also circuit relay v2 specification using `required` for `type`.

```protobuf
message HopMessage {
  enum Type {
    RESERVE = 0;
    CONNECT = 1;
    STATUS = 2;
  }

  required Type type = 1;
```

```protobuf
message StopMessage {
  enum Type {
    CONNECT = 0;
    STATUS = 1;
  }

  required Type type = 1;
```
This commit is contained in:
Max Inden
2021-11-22 21:18:31 +01:00
committed by GitHub
parent 6c2b0bd002
commit ef4c029568
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
relay/DCUtR.md
View File

@@ -2,7 +2,7 @@
| Lifecycle Stage | Maturity | Status | Latest Revision |
|-----------------|---------------|--------|--------------------|
| 1A | Working Draft | Active | r0, 2021-08-17 |
| 1A | Working Draft | Active | r1, 2021-11-20 |
Authors: [@vyzo]
@@ -135,7 +135,7 @@ message HolePunch {
SYNC = 300;
}
optional Type type=1;
required Type type=1;
repeated bytes ObsAddrs = 2;
}