From f5c5829ef9753ef8b8a15d36725c59f0e9af897e Mon Sep 17 00:00:00 2001 From: cce <51567+cce@users.noreply.github.com> Date: Sat, 15 Jul 2023 22:51:59 -0400 Subject: [PATCH] fix(pubsub): remove "Implementation note" about setting `message_id_fn` (#557) --- pubsub/README.md | 9 --------- 1 file changed, 9 deletions(-) diff --git a/pubsub/README.md b/pubsub/README.md index 120b206..8a81c9c 100644 --- a/pubsub/README.md +++ b/pubsub/README.md @@ -198,15 +198,6 @@ on the [signature policy](#signature-policy) configured for the topic.** Whichever the choice, it is crucial that **all peers** participating in a topic implement identical message ID calculation logic, or the topic will malfunction. -> **[[ Implementation note ]]:** At the time of writing this section, -> go-libp2p-pubsub (reference implementation of this spec) only allows -> configuring a single top-level `message_id_fn`. This function may, however, -> vary its behaviour based on the topic (contained inside its `Message`) -> argument. Thus, it's feasible to implement a per-topic policy using branch -> selection control flow logic. In the near future, go-libp2p-pubsub plans to -> push down the configuration of the `message_id_fn` to the topic level. Other -> implementations are encouraged to do the same. - ## Message Signing Signature behavior is configured in two axes: signature creation, and signature