36 Commits

Author SHA1 Message Date
Marco Munizaga
2e77be6f76 Merge pull request #506 from libp2p/marco/proto3
Recommend proto3
2023-01-23 10:24:22 -08:00
Danny Salman
1ec40b3f9c refactor: use rfc6890 special-purpose addresses (#505) 2023-01-23 15:02:20 +01:00
Marco Munizaga
c733210b3a Make existing protocols explicit about proto2 2023-01-20 17:13:13 -08:00
Danny Salman
ae6399b1e7 chore(rendezvous): Typo in rendezvous TTL upper-bound + writing style updates (#490) 2022-12-14 17:11:30 +01:00
Danny Salman
946441e549 minor tweak to lifestyle doc phrase (#494) 2022-12-14 17:09:28 +01:00
Thomas Eizinger
da57d78c48 rendezvous/: Clarify UNREGISTER behaviour and remove id (#348)
* Remove `id` field from `Unregister` message

All connections in libp2p are authenticated. As such, we don't have
to include the PeerId in the `Unregister` message. We only allow
peers to unregister themselves and therefore, this `id` would always
be equal to the one we are learn from the authentication layer. Having
to compare those and ensure they are equal is an unnecessary error
path.

To be backwards-compatible with existing deployments of the rendezvous
protocol, the field is only commented out. If this record ever gets
extended, the next field should use id `3`.

* Clarify absence of `UNREGISTER` response
2021-07-22 12:00:27 +02:00
Thomas Eizinger
512accdd81 rendezvous/: Remove PoW from the spec (#342)
Relates to https://github.com/libp2p/specs/pull/334.
Fixes https://github.com/libp2p/specs/issues/337.
2021-07-11 22:44:40 +02:00
Thomas Eizinger
ed021a9980 rendezvous: Change ttl and limit to uint64 (#338)
To be meaningful, TTL has to be a positive integer hence the use of
an signed integer does not bring any value and only introduces
unnecessary error handling.

Limiting the number of responses makes only sense if it is a positive
integer.
2021-06-28 11:00:48 +02:00
Vasco Santos
fecbe3c189 rendezvous/README: Add recommendations (#302)
This commit adds recommendations to the rendezvous spec regarding how a rendezvous
point should be configured. These were based on the discussions on the go
implementation PR and current code.

Co-authored-by: Max Inden <mail@max-inden.de>
2021-04-30 14:01:20 +02:00
Vasco Santos
3753c2fb30 chore: add link to signed peer record spec 2020-07-21 19:53:30 +02:00
Vasco Santos
0cf5c06fce chore: replace peerInfo by signed peer record 2020-07-21 15:14:08 +02:00
Vasco Santos
35d8ad7bfd fix: rendezvous spec 2020-07-20 11:54:38 +02:00
Yusef Napora
9473de8c8e add header to rendezvous spec 2019-06-21 14:26:54 -04:00
vyzo
e1083c1f9d add section on proof of work 2019-01-18 13:17:23 +02:00
vyzo
aba06e7f95 add author and revision 2019-01-18 13:13:35 +02:00
vyzo
84cf2fd317 wording 2019-01-18 13:11:41 +02:00
vyzo
4fa61c2d63 add ttl in registration response 2019-01-18 13:09:10 +02:00
vyzo
9f355780aa add E_UNAVAILABLE error 2019-01-18 13:05:42 +02:00
vyzo
709356938f add wording regarding arbitrary registrations 2019-01-18 13:03:03 +02:00
vyzo
4059338ff0 protobuf cosmetics -- move response status enum up 2018-04-21 11:57:10 +03:00
vyzo
9bdee4fffb add error reporting to DiscoverResponse; status text for errors.
and some more error codes.
2018-04-21 11:43:04 +03:00
vyzo
81e5078580 default TTL of 2hrs instead of persist until disconneciton semantics
Also specify a minimum upper bound of 72hrs and an E_INVALID_TTL status
code.
2018-04-20 10:31:00 +03:00
vyzo
9d061e18d5 RegisterStatus field should be called status 2018-04-18 18:26:01 +03:00
vyzo
ec7a5797fa add closing backticks 2018-04-18 18:22:26 +03:00
vyzo
7036720241 use a cookie for progressive discovery and pagination, not a timestamp. 2018-04-15 17:29:17 +03:00
vyzo
3423e159d8 fix typo, limit should be int64 2018-04-15 13:55:08 +03:00
vyzo
af5ba414c2 add RegisterResponse to convey registration success or errors.
also, peer ids in unregistrations.
2018-04-15 13:35:37 +03:00
vyzo
ed7c068226 add timestamp to discover queries and responses 2018-04-12 20:54:27 +03:00
vyzo
219dc409c1 add section on registration lifetime 2018-04-12 10:06:28 +03:00
vyzo
6dbbd4b36b protobuf fix: specific messages are optional, not repeated 2018-04-11 20:19:10 +03:00
vyzo
b19d4939fb rev2: drop push discovery, only polling. 2018-04-11 20:10:02 +03:00
vyzo
00fa97ba13 add limit to Discover message, better wording around bootstrap 2018-03-13 14:20:01 +02:00
vyzo
3330b69ef5 consistent naming for namespace field 2018-03-12 12:28:34 +02:00
vyzo
2ba1ad5111 peer discovery for bootstrap 2018-03-12 12:26:01 +02:00
vyzo
dcbd0b4806 cosmetics 2018-03-12 11:33:46 +02:00
vyzo
696ca3489a rendezvous protocol 2018-03-12 11:23:30 +02:00