From d454d1287afcfd58069f220fba6be1d2cd4bfa9f Mon Sep 17 00:00:00 2001 From: Sally MacFarlane Date: Thu, 27 Feb 2025 15:36:01 +1000 Subject: [PATCH] [CHANGELOG] tidy up changelog et al (#8360) * tidy up changelog Signed-off-by: Sally MacFarlane * typo defaut Signed-off-by: Sally MacFarlane --------- Signed-off-by: Sally MacFarlane --- CHANGELOG.md | 28 +++++++++++++------ .../besu/config/GenesisConfigOptionsTest.java | 15 +++++----- .../core/MessageFrameTestFixture.java | 10 +++---- .../ExtDelegateCallOperationTest.java | 4 +-- .../testutils/TestMessageFrameBuilder.java | 10 +++---- 5 files changed, 39 insertions(+), 28 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 28c0df398..4278ca658 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,7 +3,7 @@ ## Unreleased ### Breaking Changes - k8s (KUBERNETES) Nat method is removed. Use docker or none instead. [#8289](https://github.com/hyperledger/besu/pull/8289) -- Change "Invalid block, unable to parse RLP" RPC error message to "Invalid block param (block not found)" [#8328](https://github.com/hyperledger/besu/pull/8328) +- Change `Invalid block, unable to parse RLP` RPC error message to `Invalid block param (block not found)` [#8328](https://github.com/hyperledger/besu/pull/8328) ### Upcoming Breaking Changes - `MetricSystem::createLabelledGauge` is deprecated and will be removed in a future release, replace it with `MetricSystem::createLabelledSuppliedGauge` @@ -18,16 +18,28 @@ - Fast Sync - Transaction indexing will be disabled by default in a future release for snap sync and checkpoint sync modes. This will break RPCs that use transaction hash for historical queries. - Support for block creation on networks running a pre-Byzantium fork is deprecated for removal in a future release, after that in order to update Besu on nodes that build blocks, your network needs to be upgraded at least to the Byzantium fork. The main reason is to simplify world state management during block creation, since before Byzantium for each selected transaction, the receipt must contain the root hash of the modified world state, and this does not play well with the new plugin features and future work on parallelism. + ### Additions and Improvements -- Update the jc-kzg-4844 dependency from 1.0.0 to 2.0.0, which is now available on Maven Central [#7849](https://github.com/hyperledger/besu/pull/7849) -- Add TLS/mTLS options and configure the GraphQL HTTP service[#7910](https://github.com/hyperledger/besu/pull/7910) +#### Prague +- Increase mainnet and Sepolia gas limit to 36M [#8249](https://github.com/hyperledger/besu/pull/8249) +- Update Holesky and Sepolia deposit contract addresses [#8346](https://github.com/hyperledger/besu/pull/8346) +#### Plugins - Allow plugins to propose transactions during block creation [#8268](https://github.com/hyperledger/besu/pull/8268) -- Update `eth_getLogs` to return a `Block not found` error when the requested block is not found. [#8290](https://github.com/hyperledger/besu/pull/8290) -- Improve Conflict Detection in Parallelization by Considering Slots to Reduce False Positives. [#7923](https://github.com/hyperledger/besu/pull/7923) -- Change "Invalid block, unable to parse RLP" RPC error message to "Invalid block param (block not found)" [#8328](https://github.com/hyperledger/besu/pull/8328) -### Bug fixes +#### Parallelization +- Improve conflict detection by considering slots to reduce false positives [#7923](https://github.com/hyperledger/besu/pull/7923) +#### Dependencies - Upgrade Netty to version 4.1.118 to fix CVE-2025-24970 [#8275](https://github.com/hyperledger/besu/pull/8275) -- Add missing RPC method `debug_accountRange` to `RpcMethod.java` and implemented its handler. [#8153](https://github.com/hyperledger/besu/issues/8153) +- Update the jc-kzg-4844 dependency from 1.0.0 to 2.0.0, which is now available on Maven Central [#7849](https://github.com/hyperledger/besu/pull/7849) +- Other dependency updates [#8293](https://github.com/hyperledger/besu/pull/8293) [#8315](https://github.com/hyperledger/besu/pull/8315) [#8350](https://github.com/hyperledger/besu/pull/8350) +- Update to gradle 8.11 [#8294](https://github.com/hyperledger/besu/pull/8294) and update usage of some deprecated features [#8295](https://github.com/hyperledger/besu/pull/8295) [#8340](https://github.com/hyperledger/besu/pull/8340) +- Update gradle plugins [#8296](https://github.com/hyperledger/besu/pull/8296) [#8333](https://github.com/hyperledger/besu/pull/8333) [#8334](https://github.com/hyperledger/besu/pull/8334) +#### Other improvements +- Add TLS/mTLS options and configure the GraphQL HTTP service[#7910](https://github.com/hyperledger/besu/pull/7910) +- Update `eth_getLogs` to return a `Block not found` error when the requested block is not found. [#8290](https://github.com/hyperledger/besu/pull/8290) +- Change `Invalid block, unable to parse RLP` RPC error message to `Invalid block param (block not found)` [#8328](https://github.com/hyperledger/besu/pull/8328) + +### Bug fixes +- Add missing RPC method `debug_accountRange` to `RpcMethod.java` so this method can be used with `--rpc-http-api-method-no-auth` [#8153](https://github.com/hyperledger/besu/issues/8153) ## 25.2.1 hotfix - Pectra - update Holesky and Sepolia deposit contract addresses [#8346](https://github.com/hyperledger/besu/pull/8346) diff --git a/config/src/test/java/org/hyperledger/besu/config/GenesisConfigOptionsTest.java b/config/src/test/java/org/hyperledger/besu/config/GenesisConfigOptionsTest.java index d30146249..b2c92e22e 100644 --- a/config/src/test/java/org/hyperledger/besu/config/GenesisConfigOptionsTest.java +++ b/config/src/test/java/org/hyperledger/besu/config/GenesisConfigOptionsTest.java @@ -333,12 +333,12 @@ class GenesisConfigOptionsTest { @Test void shouldGetWithdrawalRequestContractAddress() { + + final String address = "0x0000000000000000111111119cbe0530deadbeef"; final GenesisConfigOptions config = - fromConfigOptions( - singletonMap( - "withdrawalRequestContractAddress", "0x00000000219ab540356cbb839cbe05303d7705fa")); + fromConfigOptions(singletonMap("withdrawalRequestContractAddress", address)); assertThat(config.getWithdrawalRequestContractAddress()) - .hasValue(Address.fromHexString("0x00000000219ab540356cbb839cbe05303d7705fa")); + .hasValue(Address.fromHexString(address)); } @Test @@ -359,11 +359,10 @@ class GenesisConfigOptionsTest { @Test void shouldGetDepositContractAddress() { + final String address = "0x00000000deadbeefdeadbeef0000000011111111"; final GenesisConfigOptions config = - fromConfigOptions( - singletonMap("depositContractAddress", "0x00000000219ab540356cbb839cbe05303d7705fa")); - assertThat(config.getDepositContractAddress()) - .hasValue(Address.fromHexString("0x00000000219ab540356cbb839cbe05303d7705fa")); + fromConfigOptions(singletonMap("depositContractAddress", address)); + assertThat(config.getDepositContractAddress()).hasValue(Address.fromHexString(address)); } @Test diff --git a/ethereum/core/src/test-support/java/org/hyperledger/besu/ethereum/core/MessageFrameTestFixture.java b/ethereum/core/src/test-support/java/org/hyperledger/besu/ethereum/core/MessageFrameTestFixture.java index f8c5749d5..8cef2cfea 100644 --- a/ethereum/core/src/test-support/java/org/hyperledger/besu/ethereum/core/MessageFrameTestFixture.java +++ b/ethereum/core/src/test-support/java/org/hyperledger/besu/ethereum/core/MessageFrameTestFixture.java @@ -35,7 +35,7 @@ import org.apache.tuweni.units.bigints.UInt256; public class MessageFrameTestFixture { - public static final Address DEFAUT_ADDRESS = AddressHelpers.ofValue(244259721); + public static final Address DEFAULT_ADDRESS = AddressHelpers.ofValue(244259721); private static final int maxStackSize = DEFAULT_MAX_STACK_SIZE; private MessageFrame parentFrame; @@ -43,10 +43,10 @@ public class MessageFrameTestFixture { private Optional blockchain = Optional.empty(); private Optional worldUpdater = Optional.empty(); private long initialGas = Long.MAX_VALUE; - private Address address = DEFAUT_ADDRESS; - private Address sender = DEFAUT_ADDRESS; - private Address originator = DEFAUT_ADDRESS; - private Address contract = DEFAUT_ADDRESS; + private Address address = DEFAULT_ADDRESS; + private Address sender = DEFAULT_ADDRESS; + private Address originator = DEFAULT_ADDRESS; + private Address contract = DEFAULT_ADDRESS; private Wei gasPrice = Wei.ZERO; private Wei blobGasPrice = Wei.ZERO; private Wei value = Wei.ZERO; diff --git a/evm/src/test/java/org/hyperledger/besu/evm/operation/ExtDelegateCallOperationTest.java b/evm/src/test/java/org/hyperledger/besu/evm/operation/ExtDelegateCallOperationTest.java index b08635748..21b469932 100644 --- a/evm/src/test/java/org/hyperledger/besu/evm/operation/ExtDelegateCallOperationTest.java +++ b/evm/src/test/java/org/hyperledger/besu/evm/operation/ExtDelegateCallOperationTest.java @@ -194,8 +194,8 @@ public class ExtDelegateCallOperationTest { .build(); messageFrame.warmUpAddress(CONTRACT_ADDRESS); when(account.getBalance()).thenReturn(Wei.ZERO); - when(worldUpdater.get(TestMessageFrameBuilder.DEFAUT_ADDRESS)).thenReturn(account); - when(worldUpdater.getAccount(TestMessageFrameBuilder.DEFAUT_ADDRESS)).thenReturn(account); + when(worldUpdater.get(TestMessageFrameBuilder.DEFAULT_ADDRESS)).thenReturn(account); + when(worldUpdater.getAccount(TestMessageFrameBuilder.DEFAULT_ADDRESS)).thenReturn(account); Code code = switch (name) { diff --git a/evm/src/test/java/org/hyperledger/besu/evm/testutils/TestMessageFrameBuilder.java b/evm/src/test/java/org/hyperledger/besu/evm/testutils/TestMessageFrameBuilder.java index 60eb91537..0439a56c0 100644 --- a/evm/src/test/java/org/hyperledger/besu/evm/testutils/TestMessageFrameBuilder.java +++ b/evm/src/test/java/org/hyperledger/besu/evm/testutils/TestMessageFrameBuilder.java @@ -36,16 +36,16 @@ import org.apache.tuweni.bytes.Bytes; public class TestMessageFrameBuilder { - public static final Address DEFAUT_ADDRESS = Address.fromHexString("0xe8f1b89"); + public static final Address DEFAULT_ADDRESS = Address.fromHexString("0xe8f1b89"); private static final int maxStackSize = DEFAULT_MAX_STACK_SIZE; private Optional blockValues = Optional.empty(); private Optional worldUpdater = Optional.empty(); private long initialGas = Long.MAX_VALUE; - private Address address = DEFAUT_ADDRESS; - private Address sender = DEFAUT_ADDRESS; - private Address originator = DEFAUT_ADDRESS; - private Address contract = DEFAUT_ADDRESS; + private Address address = DEFAULT_ADDRESS; + private Address sender = DEFAULT_ADDRESS; + private Address originator = DEFAULT_ADDRESS; + private Address contract = DEFAULT_ADDRESS; private Wei gasPrice = Wei.ZERO; private Wei blobGasPrice = Wei.ZERO; private Wei value = Wei.ZERO;