Files
status-linea-besu/consensus
Gabriel Fukushima 66521cb3f2 Stop adding bad proposed block to bad block manager (#5082)
* Add flag to distinguish when bad block is a proposed block

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* Add flag to distinguish when bad block is a proposed block

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* javadoc

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* Add shouldRecordBadBlock flag to stop adding proposed bad blocks to the bad block manager

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* Add overload to validateAndProcessBlock with shouldRecordBadBlock flag

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* Add unit test to ensure flag is being used to add blocks to bad block manager

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* Add unit test to ensure we don't add our own proposed bad block to the bad block manager

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* Add debug log when badBlock is not added

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* Undo change done in the first approach

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* Improve log

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* Improve test names

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* Improve javadoc of validateProposedBlock method

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* Remove method from interface

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* Change validateProposedBlock access modifier to private

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

---------

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
2023-02-22 11:15:12 +11:00
..