From 4bfd6c887025e5b20c8a99e961fd6cc5299fa647 Mon Sep 17 00:00:00 2001 From: Zamil Majdy Date: Fri, 13 Feb 2026 15:41:45 +0400 Subject: [PATCH] fix(chat/sdk): address additional PR review feedback - transcript: compare bytes-to-bytes in size guard (not str vs bytes) - service: move user message preview from INFO to DEBUG level (PII) --- .../backend/backend/api/features/chat/sdk/service.py | 4 ++-- .../backend/api/features/chat/sdk/transcript.py | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/autogpt_platform/backend/backend/api/features/chat/sdk/service.py b/autogpt_platform/backend/backend/api/features/chat/sdk/service.py index dd3bdf0c6d..4ae1e0ee90 100644 --- a/autogpt_platform/backend/backend/api/features/chat/sdk/service.py +++ b/autogpt_platform/backend/backend/api/features/chat/sdk/service.py @@ -586,9 +586,9 @@ async def stream_chat_completion_sdk( ) logger.info( - f"[SDK] Sending query: {current_message[:80]!r}" - f" ({len(session.messages)} msgs in session)" + f"[SDK] Sending query ({len(session.messages)} msgs in session)" ) + logger.debug(f"[SDK] Query preview: {current_message[:80]!r}") await client.query(query_message, session_id=session_id) assistant_response = ChatMessage(role="assistant", content="") diff --git a/autogpt_platform/backend/backend/api/features/chat/sdk/transcript.py b/autogpt_platform/backend/backend/api/features/chat/sdk/transcript.py index d14de167a3..f865f8cd09 100644 --- a/autogpt_platform/backend/backend/api/features/chat/sdk/transcript.py +++ b/autogpt_platform/backend/backend/api/features/chat/sdk/transcript.py @@ -252,17 +252,17 @@ async def upload_transcript(user_id: str, session_id: str, content: str) -> None storage = await get_workspace_storage() wid, fid, fname = _storage_path_parts(user_id, session_id) - new_size = len(stripped) + encoded = stripped.encode("utf-8") + new_size = len(encoded) # Check existing transcript size to avoid overwriting newer with older path = _build_storage_path(user_id, session_id, storage) try: existing = await storage.retrieve(path) - existing_size = len(existing) - if existing_size >= new_size: + if len(existing) >= new_size: logger.info( f"[Transcript] Skipping upload — existing transcript " - f"({existing_size}B) >= new ({new_size}B) for session " + f"({len(existing)}B) >= new ({new_size}B) for session " f"{session_id}" ) return @@ -273,7 +273,7 @@ async def upload_transcript(user_id: str, session_id: str, content: str) -> None workspace_id=wid, file_id=fid, filename=fname, - content=stripped.encode("utf-8"), + content=encoded, ) logger.info( f"[Transcript] Uploaded {new_size} bytes "