From fa8930da4cf5b0456e369b7b8993e00e6ce5816e Mon Sep 17 00:00:00 2001 From: Otto-AGPT Date: Wed, 11 Feb 2026 17:38:47 +0000 Subject: [PATCH] fix: Address CodeRabbit review feedback MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Node version 21 → 22 (matches frontend package.json engines) - Add language specifier to README code block (MD040) - Add error handling to cd command in poststart.sh (SC2164) - Add PYTHONPATH to seed test data launch config - Use docker compose pull instead of hardcoded image tags --- .devcontainer/platform/README.md | 2 +- .devcontainer/platform/devcontainer.json | 2 +- .devcontainer/platform/scripts/oncreate.sh | 17 ++++++----------- .devcontainer/platform/scripts/poststart.sh | 2 +- .../platform/vscode-templates/launch.json | 3 +++ 5 files changed, 12 insertions(+), 14 deletions(-) diff --git a/.devcontainer/platform/README.md b/.devcontainer/platform/README.md index f1d0f2656f..f7b79b788c 100644 --- a/.devcontainer/platform/README.md +++ b/.devcontainer/platform/README.md @@ -118,7 +118,7 @@ Press `Ctrl+Shift+P` → "Tasks: Run Task": ## 📁 Project Structure -``` +```text autogpt_platform/ # This folder ├── .devcontainer/ # Codespaces/devcontainer config ├── .vscode/ # VS Code settings diff --git a/.devcontainer/platform/devcontainer.json b/.devcontainer/platform/devcontainer.json index 6aa1e06c7e..d66017c57b 100644 --- a/.devcontainer/platform/devcontainer.json +++ b/.devcontainer/platform/devcontainer.json @@ -15,7 +15,7 @@ }, "ghcr.io/devcontainers/features/github-cli:1": {}, "ghcr.io/devcontainers/features/node:1": { - "version": "21", + "version": "22", "nodeGypDependencies": true }, "ghcr.io/devcontainers/features/python:1": { diff --git a/.devcontainer/platform/scripts/oncreate.sh b/.devcontainer/platform/scripts/oncreate.sh index a4f074e5fb..b7fc0882db 100755 --- a/.devcontainer/platform/scripts/oncreate.sh +++ b/.devcontainer/platform/scripts/oncreate.sh @@ -94,7 +94,10 @@ pnpm install --frozen-lockfile cd .. # ============================================================================= -# Pull Dependency Docker Images ONLY +# Pull Dependency Docker Images +# ============================================================================= +# Use docker compose pull to get exact versions from compose files +# (single source of truth, no version drift) # ============================================================================= echo "🐳 Pulling dependency Docker images..." @@ -105,16 +108,8 @@ fi # Check if Docker is available if command -v docker &> /dev/null && docker info &> /dev/null; then - # Pull dependency images in parallel - docker pull supabase/gotrue:v2.170.0 & - docker pull supabase/studio:20250224-d10db0f & - docker pull kong:2.8.1 & - docker pull supabase/postgres:15.8.1.060 & - docker pull redis:latest & - docker pull rabbitmq:management & - - # Wait for all pulls to complete - wait + # Pull images defined in docker-compose.yml (single source of truth) + docker compose pull db redis rabbitmq kong auth || echo "⚠️ Some images may not have pulled" echo "✅ Dependency images pulled" else echo "⚠️ Docker not available during prebuild, images will be pulled on first start" diff --git a/.devcontainer/platform/scripts/poststart.sh b/.devcontainer/platform/scripts/poststart.sh index d72992fd19..e6e1f881c8 100755 --- a/.devcontainer/platform/scripts/poststart.sh +++ b/.devcontainer/platform/scripts/poststart.sh @@ -13,7 +13,7 @@ echo "🔄 Starting dependency services..." -cd /workspaces/AutoGPT/autogpt_platform +cd /workspaces/AutoGPT/autogpt_platform || { echo "❌ Failed to cd to workspace"; exit 1; } # Ensure Docker socket is available if [ -e /var/run/docker-host.sock ]; then diff --git a/.devcontainer/platform/vscode-templates/launch.json b/.devcontainer/platform/vscode-templates/launch.json index c88ddebd3a..623e117a71 100644 --- a/.devcontainer/platform/vscode-templates/launch.json +++ b/.devcontainer/platform/vscode-templates/launch.json @@ -94,6 +94,9 @@ "request": "launch", "program": "${workspaceFolder}/backend/test/e2e_test_data.py", "cwd": "${workspaceFolder}/backend", + "env": { + "PYTHONPATH": "${workspaceFolder}/backend" + }, "console": "integratedTerminal" } ],