From 21f44a8a934b40bb6bc3c1bdcfe7ffe26ded59da Mon Sep 17 00:00:00 2001 From: mikekaganski Date: Sat, 7 Mar 2015 16:50:45 +1000 Subject: [PATCH] Fix Coverity CID 38579 --- .../Helmholtz/HelmholtzEOSMixtureBackend.cpp | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/Backends/Helmholtz/HelmholtzEOSMixtureBackend.cpp b/src/Backends/Helmholtz/HelmholtzEOSMixtureBackend.cpp index 5c9d71b5..21316375 100644 --- a/src/Backends/Helmholtz/HelmholtzEOSMixtureBackend.cpp +++ b/src/Backends/Helmholtz/HelmholtzEOSMixtureBackend.cpp @@ -1642,14 +1642,13 @@ CoolPropDbl HelmholtzEOSMixtureBackend::solver_for_rho_given_T_oneof_HSU(CoolPro { public: int other; - CoolPropDbl T, value, r, eos, rhomolar; + CoolPropDbl T, value; HelmholtzEOSMixtureBackend *HEOS; - solver_resid(HelmholtzEOSMixtureBackend *HEOS, CoolPropDbl T, CoolPropDbl value, int other){ - this->HEOS = HEOS; this->T = T; this->value = value; this->other = other; - }; + solver_resid(HelmholtzEOSMixtureBackend *HEOS, CoolPropDbl T, CoolPropDbl value, int other) + : HEOS(HEOS),T(T),value(value),other(other){} double call(double rhomolar){ - this->rhomolar = rhomolar; + CoolPropDbl eos; switch(other) { case iSmolar: @@ -1662,8 +1661,7 @@ CoolPropDbl HelmholtzEOSMixtureBackend::solver_for_rho_given_T_oneof_HSU(CoolPro throw ValueError(format("Input not supported")); } - r = eos-value; - return r; + return eos-value; }; }; solver_resid resid(this, T, value, other);