Ian Bell
a431b2f6bf
Use IF97 to do all the flash calls for Humid air properties
2015-04-28 22:40:44 -06:00
Ian Bell
ae1f033e5c
Fix W = 0 for HAPropsSI; closes #628
2015-04-27 19:02:27 -06:00
Ian Bell
295f9a2b3f
Fixed #586
2015-04-10 20:52:20 -06:00
Ian Bell
1e5e465fa4
Clear AbstractState classes for HAPropsSI at every call; closes #585
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-04-10 20:27:59 -06:00
Ian Bell
fe631f575a
Revert one of the IF97 updates
2015-04-04 12:14:57 -06:00
Ian Bell
daa6138104
Increase robustness of HAPropsSI when W is provided; closes #548
2015-04-04 00:09:18 -06:00
Ian Bell
a340663025
Two more psat(Tsat) or Tsat(psat) for humid air
2015-04-03 23:15:16 -06:00
Ian Bell
0bfef6f0f8
Replaced all psat(Tsat) and Tsat(psat) calls using IF97
2015-04-03 23:11:21 -06:00
Ian Bell
c934bae64b
Handle partial pressure of water in unit conversion switch
2015-03-14 19:52:30 -06:00
Ian Bell
eadee7eba3
Added partial pressure of water ("P_w") in HAPropsSI; Closes #490
2015-03-13 17:14:34 -06:00
mikekaganski
7ff4610524
Fix Coverity CID 38538
2015-03-09 19:40:42 +10:00
mikekaganski
67a0439a68
Fix Coverity CID 38542
2015-03-09 18:04:32 +10:00
mikekaganski
9d9be5e641
Fix Coverity CID 38563
2015-03-09 12:17:20 +10:00
mikekaganski
cc0dc74f5a
Fix Coverity CID 38528
...
iter cannot ever become greater than 100; useless check
2015-03-08 23:53:59 +10:00
mikekaganski
c99805cc79
Fix Coverity CID 38566
2015-03-07 23:04:07 +10:00
Ian Bell
c674ff5aa8
Merge pull request #510 from mikekaganski/master
...
const, ref and iterator optimization
2015-02-28 19:55:10 -07:00
Ian Bell
c3026be768
Added compressibility factor for humid air; closes #503
2015-02-28 19:52:37 -07:00
mikekaganski
28691e8e75
const, ref and iterator optimization
...
1. Another set of arguments optimized:
* args-by-val converted to args-by-ref
* in some cases, reverse has been done, if that is better: if the
object's copy is modified in the func, it's better to avoid extra copy
from arg to local var
2. some const functions marked as such (this is just a beginning)
3. iterators were replaced with const_iterators where applicable
4. catches that catch std::exception& changed to catch (...) - that is
safer; if exception handling is restructured, this will have to be
reconsidered anyway
5. removed some basic structures' constructors; changed them to hold
const char*s to avoid unnecessary string constructions;
6. in some places, moved variable declarations to their definitions, to
avoid calling default constructors and then assigning
7. removed some unnecessary shared_pointers in favor of local objects;
8. in FORTRAN-style functions, added const specifiers to input doubles;
9. fixed a place where values were inserted into a map while iterating
through it
10. fixed is_valid_*_derivative: they could accept incorrect values and
throw when upper index is less than lower
2015-03-01 10:51:01 +10:00
Ian Bell
09f8976605
Back to PQ for water for humid air visc and conductivity
...
Closes #470
Closes #498
2015-02-28 16:00:04 -07:00
mikekaganski
869d1afc71
More ref args
2015-02-27 00:56:38 +10:00
mikekaganski
f94a249895
tidy _HAPropsSI_inputs
...
avoided double lookup for input key (match_input_key + get_input_key);
unified MoleFractionWater call;
if ((key = get_input_key(input_keys, GIVEN_HUMRAT)) && key >= 0) may
give false negatives if get_input_key returns 0;
added throw
2015-02-24 09:26:12 +10:00
Ian Bell
7361d715ef
Refactored HAPropsSI and broke up into inputs and outputs parts; Closes #485
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-02-22 22:57:49 -07:00
Ian Bell
e2110153aa
Finished cleanup of HAPropsSI internal code for now; Closes #468
...
Removed a lot of string comparisons, more can still be removed by making a function _HAPropsSI that takes enum values. Should do this anyway
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-02-21 12:58:10 -07:00
Ian Bell
82277c4f44
Remove unused variable; See #479
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-02-20 21:14:15 -07:00
Ian Bell
4b07026b36
Humid air transport evaluated at T,P for both water and air; Closes #470
2015-02-19 22:30:11 -05:00
Ian Bell
485f296fcd
Fix bug with relative humidity
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-02-19 22:05:54 -05:00
Ian Bell
ff614a923b
Clean up relative humidity function; closes #479
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-02-19 22:02:01 -05:00
Ian Bell
6bf6e27e77
Fix Sda alias in HAPropsSI
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-02-18 20:25:03 -05:00
Ian Bell
e05e64b22d
Fix aliases for Hha and Hda
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-02-17 15:50:10 -07:00
Ian Bell
dedcbbe886
Sanitized return values from HAPropsSI; see #468
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-02-15 10:53:48 -07:00
Ian Bell
70d076afe3
Initialize fluids in HAProps_Aux; Closes #469
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-02-15 10:17:42 -07:00
Ian Bell
f60a76e025
Re-implement CP as output for HAPropsSI; Closes #467
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-02-15 09:57:38 -07:00
Ian Bell
f81ac8fec2
Wetbulb solver T,B,P works better now; Closes #419 and #427
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-02-09 22:03:35 -07:00
Ian Bell
4ebe23ed95
Comment out the HAPropsSI code consistency test
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-01-19 17:28:54 -07:00
Ian Bell
de2105fafb
Add tests for HAPropsSI
...
Also, if an output is the same as the input, return the input directly
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-01-19 16:34:24 -07:00
Ian Bell
0bb60b6ed9
Refactored HAPropsSI to handle better weird inputs
...
Closes #400
Closes #398
Closes #403
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-01-12 23:38:29 -07:00
Ian Bell
5208b32995
Fixed bug with different output for different order of inputs to HAPropsSI; Closes #399
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-01-12 21:58:40 -07:00
Ian Bell
02987937ef
Clean up HAPropsSI
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-01-11 20:07:57 -07:00
Ian Bell
f7cb65305a
Fix bug with humid air properties; Closes #389
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2015-01-07 14:02:34 -07:00
Ian Bell
16ffbed7b0
Fixed bug when relative humidity was input, but T not provided. Closed #320
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2014-12-09 11:16:27 -05:00
Ian Bell
e0e2591d73
Fixed problems with HAPropsSI when wetbulb is an input by converting call to Brent. Slow but steady.
...
Closes https://github.com/CoolProp/CoolProp/issues/311
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2014-12-09 00:08:27 -05:00
Ian Bell
4960842476
A better step size in secant solver for low W
...
Closes https://github.com/CoolProp/CoolProp/issues/254
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2014-12-04 12:09:06 -05:00
Ian Bell
6b98b80d7b
Relaxed convergence criterion for dewpoint.
...
Closes https://github.com/CoolProp/CoolProp/issues/251
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2014-11-27 14:54:01 -05:00
Ian Bell
8327d54ea2
Replaced all tabs with spaces (finally) in C++ files
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2014-11-19 12:16:14 -05:00
Ian Bell
9299cb8e07
Re-implements HAProps function at the C++ level.
...
Closes https://github.com/CoolProp/CoolProp/issues/182
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2014-10-22 21:32:22 +00:00
Ian Bell
540da38842
Fixed problem with S as input for humid air
...
Closes https://github.com/CoolProp/CoolProp/issues/181
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2014-10-22 21:08:36 +00:00
Ian Bell
7bf4216240
Repaired humid air properties. Validation runs now
...
Closes https://github.com/CoolProp/CoolProp/issues/125
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2014-09-10 10:14:29 +02:00
Ian Bell
4b082029c4
Finally repaired flash routines.
...
Some edge cases remain
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2014-08-24 13:40:46 +02:00
Ian Bell
d3261395bf
Replaced all fabs() with std::abs()
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2014-08-23 14:56:07 +02:00
Ian Bell
f43a0b792b
Humid air properties now use string instead of char*
...
Signed-off-by: Ian Bell <ian.h.bell@gmail.com >
2014-08-19 21:55:23 +02:00