Commit Graph

39 Commits

Author SHA1 Message Date
mikekaganski
1b7ccca9a3 Fix Coverity CID 38552
Add some const method qualifiers
2015-03-09 17:12:34 +10:00
mikekaganski
869d1afc71 More ref args 2015-02-27 00:56:38 +10:00
mikekaganski
1068b724c3 CoolPropDbl
Introduce CoolPropDbl to replace long doubles. This may help to overcome
possible portability problems, and test for efficiency and precision.
2015-02-24 13:24:51 +10:00
mikekaganski
0e3a9fe9af Fix static analyzer warnings "Local declaration hides local"
C6246 Local declaration hides local Local declaration of 'z' hides
declaration of the same name in outer scope. For additional information,
see previous declaration at line '187' of
'd:\documents\github\coolprop\src\coolprop.cpp'. CoolProp coolprop.cpp
230
C6246 Local declaration hides local Local declaration of 'fluid' hides
declaration of the same name in outer scope. For additional information,
see previous declaration at line '852' of
'd:\documents\github\coolprop\src\coolprop.cpp'. CoolProp coolprop.cpp
871
C6246 Local declaration hides local Local declaration of 'options' hides
declaration of the same name in outer scope. For additional information,
see previous declaration at line '743' of
'd:\documents\github\coolprop\src\backends\helmholtz\flashroutines.cpp'.
CoolProp flashroutines.cpp 778
C6246 Local declaration hides local Local declaration of 'h1' hides
declaration of the same name in outer scope. For additional information,
see previous declaration at line '1338' of
'd:\documents\github\coolprop\src\backends\helmholtz\flashroutines.cpp'.
CoolProp flashroutines.cpp 1367
C6246 Local declaration hides local Local declaration of 'el' hides
declaration of the same name in outer scope. For additional information,
see previous declaration at line '250' of
'd:\documents\github\coolprop\src\helmholtz.cpp'. CoolProp helmholtz.cpp
259
C6246 Local declaration hides local Local declaration of 'y' hides
declaration of the same name in outer scope. For additional information,
see previous declaration at line '1649' of
'd:\documents\github\coolprop\src\backends\helmholtz\helmholtzeosmixturebackend.cpp'.
CoolProp helmholtzeosmixturebackend.cpp 1756
C6246 Local declaration hides local Local declaration of 'iclosest'
hides declaration of the same name in outer scope. For additional
information, see previous declaration at line '415' of
'd:\documents\github\coolprop\src\backends\helmholtz\phaseenveloperoutines.cpp'.
CoolProp phaseenveloperoutines.cpp 467
C6246 Local declaration hides local Local declaration of 'crit' hides
declaration of the same name in outer scope. For additional information,
see previous declaration at line '181' of
'd:\documents\github\coolprop\src\backends\helmholtz\vleroutines.cpp'.
CoolProp vleroutines.cpp 284
C6246 Local declaration hides local Local declaration of 'crit' hides
declaration of the same name in outer scope. For additional information,
see previous declaration at line '925' of
'd:\documents\github\coolprop\src\backends\helmholtz\vleroutines.cpp'.
CoolProp vleroutines.cpp 950
2015-02-22 14:43:57 +10:00
Ian Bell
37bfd34d23 Update a few tests
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-12-02 01:36:43 -05:00
Ian Bell
f0bf588358 Relaxed some more convergence criteria
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-11-29 21:31:03 -05:00
Ian Bell
d3261395bf Replaced all fabs() with std::abs()
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-08-23 14:56:07 +02:00
Ian Bell
04beedd13a Disabled Eigen all function (so slow to compile)
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-08-23 11:11:31 +02:00
Ian Bell
ad15288c23 Byebye to Armadillo (maybe reconsider later on)
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-08-18 19:28:00 +02:00
Ian Bell
9293c6355c For posterity's sake, a version using armadillo - not an improvement... slower than Eigen
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-08-18 09:47:02 +02:00
Ian Bell
f7464fcaa2 Implemented Eigen solution for all() function, speed testing next
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-08-17 21:09:27 +02:00
Ian Bell
10f23992e7 Cleanup of all function - not any faster though
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-08-16 18:45:24 +02:00
Ian Bell
fc2e618fb7 Speed optimizations for saturation routines
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-08-16 17:50:04 +02:00
Ian Bell
9a1a0122e3 Renamed Derivatives to HelmholtzDerivatives; they all check fine
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-08-16 14:26:25 +02:00
Ian Bell
5cad463158 Parallel derivatives finished for NonAnalytic term
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-08-16 14:11:27 +02:00
Ian Bell
68d3725ffd Added tests for undefined parameters; documented undocumented parameters
Closes https://github.com/CoolProp/CoolProp/issues/97

Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-08-16 12:40:35 +02:00
Ian Bell
eee8139306 SAFT has transitioned to parallel evaluation of derivatives, though it isn't truly parallel since there is some duplication
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-08-15 22:34:24 +02:00
Ian Bell
29632c72e6 Transition complete to generalized exponential term
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-08-15 22:03:40 +02:00
Ian Bell
2270f9f076 Helmholtz derivatives are all calculated using parallel code - next step is to remove classes from Helmholtz
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-08-15 21:16:41 +02:00
Ian Bell
c3508c3f55 Added parallel evaluation of residual helmholtz terms
Should in the end only slow down by 1.2x, but calculate at least up to second order derivatives all at once, so net speedup of 5 if calculating all first and second order partials !!

Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-08-15 15:42:47 +02:00
Ian Bell
b7bd58d986 More work on flash routines, number of failures is rapidly decreasing - still have problems for low pressure sat_p calcs
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-08-12 11:21:12 +02:00
Ian Bell
e4c6e83728 Fixed Helmholtz dTau2 term for NonAnalytic 2014-07-10 15:07:12 +02:00
Ian Bell
fa3fe63c44 Removed references to std::tr1 2014-07-06 20:53:15 +02:00
Ian Bell
50ca26842e Decreased step size in numerical derivative for Helmholtz tester
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-06-06 21:19:42 +02:00
Ian Bell
514e406eea Fixed dDelta3 for Gaussian Helmholtz term (70 tests fail)
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-06-06 19:05:13 +02:00
Ian Bell
da7b9c7793 docs for dTau3 derivation from Lemmon2005
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-06-06 18:54:35 +02:00
Ian Bell
69c21800bb Fixed derivatives for Lemmon2005
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-06-06 18:51:39 +02:00
Ian Bell
a82160c4bf Clean up shared_ptr mess
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-06-03 21:34:26 +02:00
Ian Bell
bffb36cc41 Merge branch 'master' of https://github.com/coolprop/coolprop
Conflicts:
	src/Helmholtz.cpp
	src/main.cxx

Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-06-03 21:01:50 +02:00
Ian Bell
cb497b443c Added crossplatform_shared_ptr to allow shared_ptr cleanly on all architectures without needing variable namespace definition 2014-06-03 20:58:24 +02:00
Ian Bell
331690de8c Water viscosity can now be evaluated at the critical point
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-06-03 17:49:23 +02:00
Ian Bell
6e7cf60aee Fixed bug in Helmholtz energy Lemon2005 term (was using integer powers rather than the correct power)
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-06-03 14:32:02 +02:00
Ian Bell
b78439b72c Added passing tests for generalized PE term 2014-06-03 12:54:26 +02:00
Ian Bell
bff7e2afeb PlanckEinstein and PlanckEinstein2 classes replaced with PlanckEinsteinGeneralized. Docs to follow.
Aly-Lee not yet removed.  Next step.

Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-06-03 12:04:16 +02:00
Ian Bell
3168f15efc Implemented dDelta3; test passes
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-06-01 19:46:30 +02:00
Ian Bell
c468339768 Implemented test for GERG 2008 residual term and changed include from <tr1/memory> to <memory>
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-06-01 19:29:09 +02:00
Ian Bell
873eab5baa Helmholtz derivative testing gives almost 100% coverage - missing HS offset term
Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-05-30 17:13:23 +02:00
Ian Bell
7b8606f323 No more deletes used anywhere in the codebase. Only std::tr1::shared_ptr are used. Should be portable solution.
All tests run, no memory leaks according to VLD

Signed-off-by: Ian Bell <ian.h.bell@gmail.com>
2014-05-28 19:45:04 +02:00
Ian bell
b3847c7522 Initial commit for v5, but this time with the right line endings
Signed-off-by: Ian bell <ian.h.bell@gmail.com>
2014-05-14 12:46:24 +02:00