mirror of
https://github.com/CoolProp/CoolProp.git
synced 2026-01-10 22:48:05 -05:00
57584a7254
* Added first working version of VTPR; * Get VTPR building hopefully * Remove more constant iterators * Make VTPR accessible through factory * One last const iterator * Fix a_alpha bug and make sqrt(2) into sqrt(2.0) * Added analytic first derivative for VTPR * Fix another set of sqrt(2) -> sqrt(2.0) * Add some info on the derivatives for VTPR Looks less hopeless than I had feared * gE/RT needs to be multiplied by RT; closes #1161 * Added first working version of VTPR; * Get VTPR building hopefully * Remove more constant iterators * Make VTPR accessible through factory * One last const iterator * Fix a_alpha bug and make sqrt(2) into sqrt(2.0) * Added analytic first derivative for VTPR * Fix another set of sqrt(2) -> sqrt(2.0) * Add some info on the derivatives for VTPR Looks less hopeless than I had feared * gE/RT needs to be multiplied by RT; closes #1161 * Add VTPR code from @JonWel (#1194) * 1rst draft to implement a simple volume translation to cubics * A bit more of VT * Derivatives for volume translation * Better cm initialisation * Solves the cubic equation with volume translation * Correct the volume translation analytic development Looks good now * Update VTPR to be able to use volume translation * Unprotect cm_term This allows it to be used from the VTPR backend * Update CoolPropLib.def * Better derrivative of PI_12 The expression is simpler this way * Solves #1176 Thanks @ibell * Change the way the volume translation parrameter is set * Start the bm derivatives for VTPR * Correct one derivative * Small bug * Better bm derivatives for VTPR * Add am and bm component derivatives for VTPR @ibell I did not check yet the component derivatives of this commit, bu I checked the other ones with your code. I'll have to addapt your code to also check these ones. I separate the `am_term` and `bm_term` as the `am_bm_term` function was called twice. This reduce the call to the am_term part as this part ends up being called only once, and this helped writing the component derivatives. The tau derivative is done numerically untill we find time to develop the analytical one. The `am_bm_term` function started with a `set_temperature()`. I did not checked yet why this is needed and put this set temperature at the beginning of each of the `am_term` component derivatives. I'll try to addapt the checking code tomorow. * tab to spaces * Re-writing of cubic coefficients Introducing 3 intermediary varriables that simplify the cubic's coefficient with the volume translation. * 1rst draft to implement a simple volume translation to cubics * A bit more of VT * Derivatives for volume translation * Better cm initialisation * Solves the cubic equation with volume translation * Correct the volume translation analytic development Looks good now * Update VTPR to be able to use volume translation * Unprotect cm_term This allows it to be used from the VTPR backend * Update CoolPropLib.def * Better derrivative of PI_12 The expression is simpler this way * Solves #1176 Thanks @ibell * Change the way the volume translation parrameter is set * Start the bm derivatives for VTPR * Correct one derivative * Small bug * Better bm derivatives for VTPR * Add am and bm component derivatives for VTPR @ibell I did not check yet the component derivatives of this commit, bu I checked the other ones with your code. I'll have to addapt your code to also check these ones. I separate the `am_term` and `bm_term` as the `am_bm_term` function was called twice. This reduce the call to the am_term part as this part ends up being called only once, and this helped writing the component derivatives. The tau derivative is done numerically untill we find time to develop the analytical one. The `am_bm_term` function started with a `set_temperature()`. I did not checked yet why this is needed and put this set temperature at the beginning of each of the `am_term` component derivatives. I'll try to addapt the checking code tomorow. * tab to spaces * Re-writing of cubic coefficients Introducing 3 intermediary varriables that simplify the cubic's coefficient with the volume translation.