mirror of
https://github.com/CoolProp/CoolProp.git
synced 2026-04-23 03:00:17 -04:00
f0b988236f
* build: replace git submodules with CPM.cmake All 11 submodules (Eigen, fmtlib, msgpack-c, rapidjson, IF97, REFPROP-headers, multicomplex, Catch2, pybind11, ExcelAddinInstaller, FindMathematica) are now fetched by CPM.cmake at configure time. Set CPM_SOURCE_CACHE (e.g. ~/.cache/CPM) to share the download cache across git worktrees and build directories — no more per-worktree `git submodule update --init --recursive`. Vendored deps that have no upstream release cycle (miniz, nlohmann-json, incbin) remain in externals/ as before. Source-level changes: angle-bracket includes for rapidjson, IF97, and REFPROP-headers now that their directories are on the include path via CPM-provided source dirs rather than relative paths from the repo root. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(python): wire up CPM.cmake in Python wrapper, fix include paths The Python wrapper CMakeLists.txt was still referencing submodule paths (externals/Eigen, externals/fmtlib, externals/msgpack-c) removed by the CPM migration. Include CPM.cmake + dependencies.cmake from the root and use the ${Pkg_SOURCE_DIR} variables instead. Also adds missing rapidjson, IF97, and REFPROP_headers include dirs required by CoolProp sources. CI workflows drop the now-meaningless `submodules: recursive` checkout option and add a CPM source-cache step to avoid re-downloading on each macOS/Windows runner. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs: remove git submodule references after CPM.cmake migration Dependencies are now managed by CPM.cmake (fetched automatically at CMake configure time), so git submodules no longer exist. - Drop `--recursive` from all `git clone` commands in Web docs and wrapper READMEs (26 .rst/.md files) - Remove `submodules: recursive` from all CI workflow checkout steps (13 workflow files) - Remove `git submodule foreach/update` calls from release.bsh and delete the now-dead pybind11 security-workaround lines - Drop `--recursive` from build_swigged_matlab.sh and gitMirror.bsh - Update CONTRIBUTING.md: drop "and its submodules" phrasing Changelog entries referencing old submodule PRs are left intact as historical records. The --recursive in buildbot.rst is for the Dockerfiles repo (unrelated) and is also left unchanged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(ci): remove empty 'with:' blocks after submodule removal, apply clang-format After removing 'submodules: recursive' from checkout steps, some workflow files were left with dangling empty 'with:' blocks that GitHub Actions rejects as workflow file errors. Remove the empty 'with:' in 9 workflows. Also apply clang-format to fix spacing in REFPROPMixtureBackend.cpp, HumidAirProp.cpp, and Helmholtz.cpp. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
81 lines
2.6 KiB
YAML
81 lines
2.6 KiB
YAML
# This workflow uses actions that are not certified by GitHub.
|
|
# They are provided by a third-party and are governed by
|
|
# separate terms of service, privacy policy, and support
|
|
# documentation.
|
|
#
|
|
# Find more information at:
|
|
# https://github.com/microsoft/msvc-code-analysis-action
|
|
|
|
name: Development Microsoft C++ Code Analysis
|
|
|
|
on:
|
|
push:
|
|
branches: [ 'dev_checks' ]
|
|
# branches: [ 'master', 'main', 'develop', 'dev_checks' ]
|
|
# tags: [ 'v*' ]
|
|
#pull_request:
|
|
# branches: [ 'master', 'main', 'develop' ]
|
|
schedule:
|
|
- cron: '15 8 * * 0,4' # Run twice a week
|
|
workflow_dispatch:
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
env:
|
|
# Path to the CMake build directory.
|
|
build: '${{ github.workspace }}/build'
|
|
config: 'Release'
|
|
|
|
jobs:
|
|
analyze:
|
|
permissions:
|
|
contents: read # for actions/checkout to fetch code
|
|
security-events: write # for github/codeql-action/upload-sarif to upload SARIF results
|
|
actions: read # only required for a private repository by github/codeql-action/upload-sarif to get the Action run status
|
|
name: Analyze
|
|
runs-on: windows-latest
|
|
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@v3
|
|
|
|
- name: Configure CMake
|
|
run: cmake
|
|
-DCOOLPROP_MY_MAIN=dev/ci/main.cpp
|
|
-B ${{github.workspace}}/build
|
|
-S .
|
|
|
|
# Build is not required unless generated source files are used
|
|
# For CoolProp: Needed to build dynamic fluids JSON header
|
|
- name: Build CMake
|
|
run: cmake
|
|
--build ${{github.workspace}}/build
|
|
--config Release
|
|
|
|
- name: Initialize MSVC Code Analysis
|
|
uses: microsoft/msvc-code-analysis-action@v0.0.1
|
|
# Provide a unique ID to access the sarif output path
|
|
id: run-analysis
|
|
with:
|
|
cmakeBuildDirectory: ${{github.workspace}}/build
|
|
# Ruleset file that will determine what checks will be run
|
|
ruleset: NativeRecommendedRules.ruleset
|
|
|
|
|
|
# Upload SARIF file to GitHub Code Scanning Alerts
|
|
# NOTE: Too many runs (47 cpp files) to upload to Github (LIMIT = 20)
|
|
# Commenting and uploading as an artifact below for download
|
|
# and viewing off-line.
|
|
# - name: Upload SARIF to GitHub
|
|
# uses: github/codeql-action/upload-sarif@v3
|
|
# with:
|
|
# sarif_file: ${{ steps.run-analysis.outputs.sarif }}
|
|
|
|
# Upload SARIF file as an Artifact to download and view
|
|
- name: Upload SARIF as an Artifact
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: sarif-file
|
|
path: ${{ steps.run-analysis.outputs.sarif }}
|