From 3d88f8e2fcafa43d1224d267e5b14fa4ab77cf2c Mon Sep 17 00:00:00 2001 From: Kayvan Sylvan Date: Sat, 3 Jan 2026 23:23:19 -0800 Subject: [PATCH 1/2] fix: update `SetLastPRSync` to use version date instead of current time - Change last_pr_sync to use versionDate instead of time.Now() - Ensure future runs fetch PRs merged after the version date - Add clarifying comments explaining the sync timing logic --- cmd/generate_changelog/internal/changelog/processing.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cmd/generate_changelog/internal/changelog/processing.go b/cmd/generate_changelog/internal/changelog/processing.go index 560df64b..bb888cd1 100644 --- a/cmd/generate_changelog/internal/changelog/processing.go +++ b/cmd/generate_changelog/internal/changelog/processing.go @@ -291,8 +291,9 @@ func (g *Generator) CreateNewChangelogEntry(version string) error { fmt.Fprintf(os.Stderr, "Warning: Failed to update last_processed_tag: %v\n", err) } - // Update last_pr_sync to current time - if err := g.cache.SetLastPRSync(time.Now()); err != nil { + // Update last_pr_sync to the version date (not current time) + // This ensures future runs will fetch PRs merged after this version + if err := g.cache.SetLastPRSync(versionDate); err != nil { fmt.Fprintf(os.Stderr, "Warning: Failed to update last_pr_sync: %v\n", err) } } From 96ce0838b5cca3649c4fc76f80feb5d98124b233 Mon Sep 17 00:00:00 2001 From: Kayvan Sylvan Date: Sat, 3 Jan 2026 23:28:42 -0800 Subject: [PATCH 2/2] chore: incoming 1919 changelog entry --- cmd/generate_changelog/incoming/1919.txt | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 cmd/generate_changelog/incoming/1919.txt diff --git a/cmd/generate_changelog/incoming/1919.txt b/cmd/generate_changelog/incoming/1919.txt new file mode 100644 index 00000000..a9e8db16 --- /dev/null +++ b/cmd/generate_changelog/incoming/1919.txt @@ -0,0 +1,6 @@ +### PR [#1919](https://github.com/danielmiessler/Fabric/pull/1919) by [ksylvan](https://github.com/ksylvan): Fix the `last_pr_sync` setting during PR incoming processing + +- Fix: update `SetLastPRSync` to use version date instead of current time +- Change last_pr_sync to use versionDate instead of time.Now() +- Ensure future runs fetch PRs merged after the version date +- Add clarifying comments explaining the sync timing logic