fix(ui): race condition that causes non-user-facing error when handling canvas filter cancelations

The abortController could be null by the time we attempt to abort it
This commit is contained in:
psychedelicious
2025-02-16 07:59:30 +10:00
parent 700ad78f87
commit abbb3609c8

View File

@@ -284,8 +284,8 @@ export class CanvasEntityFilterer extends CanvasModuleBase {
this.log.error({ error: serializeError(filterResult.error) }, 'Error filtering');
this.$isProcessing.set(false);
// Clean up the abort controller as needed
if (!this.abortController.signal.aborted) {
this.abortController.abort();
if (!controller.signal.aborted) {
controller.abort();
}
this.abortController = null;
return;
@@ -324,8 +324,8 @@ export class CanvasEntityFilterer extends CanvasModuleBase {
this.$isProcessing.set(false);
// Clean up the abort controller as needed
if (!this.abortController.signal.aborted) {
this.abortController.abort();
if (!controller.signal.aborted) {
controller.abort();
}
this.abortController = null;