* Added If node
* Added stricter type checking on inputs
* feat(nodes): make if-node type checks cardinality-aware without loosening global AnyField
* chore: typegen
* Initial plan
* Warn user when credentials have expired in multiuser mode
Agent-Logs-Url: https://github.com/lstein/InvokeAI/sessions/f0947cda-b15c-475d-b7f4-2d553bdf2cd6
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Address code review: avoid multiple localStorage reads in base query
Agent-Logs-Url: https://github.com/lstein/InvokeAI/sessions/f0947cda-b15c-475d-b7f4-2d553bdf2cd6
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* bugfix(multiuser): ask user to log back in when authentication token expires
* feat: sliding window session expiry with token refresh
Backend:
- SlidingWindowTokenMiddleware refreshes JWT on each mutating request
(POST/PUT/PATCH/DELETE), returning a new token in X-Refreshed-Token
response header. GET requests don't refresh (they're often background
fetches that shouldn't reset the inactivity timer).
- CORS expose_headers updated to allow X-Refreshed-Token.
Frontend:
- dynamicBaseQuery picks up X-Refreshed-Token from responses and
updates localStorage so subsequent requests use the fresh expiry.
- 401 handler only triggers sessionExpiredLogout when a token was
actually sent (not for unauthenticated background requests).
- ProtectedRoute polls localStorage every 5s and listens for storage
events to detect token removal (e.g. manual deletion, other tabs).
Result: session expires after TOKEN_EXPIRATION_NORMAL (1 day) of
inactivity, not a fixed time after login. Any user-initiated action
resets the clock.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* chore(backend): ruff
* fix: address review feedback on auth token handling
Bug fixes:
- ProtectedRoute: only treat 401 errors as session expiry, not
transient 500/network errors that should not force logout
- Token refresh: use explicit remember_me claim in JWT instead of
inferring from remaining lifetime, preventing silent downgrade of
7-day tokens to 1-day when <24h remains
- TokenData: add remember_me field, set during login
Tests (6 new):
- Mutating requests (POST/PUT/DELETE) return X-Refreshed-Token
- GET requests do not return X-Refreshed-Token
- Unauthenticated requests do not return X-Refreshed-Token
- Remember-me token refreshes to 7-day duration even near expiry
- Normal token refreshes to 1-day duration
- remember_me claim preserved through refresh cycle
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* chore(backend): ruff
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Jonathan <34005131+JPPhoto@users.noreply.github.com>
* feat: add bulk reidentify action for models (#8951)
Add a "Reidentify Models" bulk action to the model manager, allowing
users to re-probe multiple models at once instead of one by one.
- Backend: POST /api/v2/models/i/bulk_reidentify endpoint with partial
failure handling (returns succeeded/failed lists)
- Frontend: bulk reidentify mutation, confirmation modal with warning
about custom settings reset, toast notifications for all outcomes
- i18n: new translation keys for bulk reidentify UI strings
* fix typgen
* Fix bulk reidentify failing for models without trigger_phrases
The bulk reidentify endpoint was directly assigning trigger_phrases
without checking if the config type supports it, causing an
AttributeError for ControlNet models. Added the same hasattr guard
used by the individual reidentify endpoint. Also restored the
missing path preservation that the individual endpoint has.
- Remove negative_prompt, steps, guidance, reference_image_weights,
reference_image_modes from external model nodes (unused by any provider)
- Remove supports_negative_prompt, supports_steps, supports_guidance
from ExternalModelCapabilities
- Add provider_options dict to ExternalGenerationRequest for
provider-specific parameters
- Add OpenAI-specific fields: quality, background, input_fidelity
- Add Gemini-specific fields: temperature, thinking_level
- Add new OpenAI starter models: GPT Image 1.5, GPT Image 1 Mini,
DALL-E 3, DALL-E 2
- Fix OpenAI provider to use output_format (GPT Image) vs
response_format (DALL-E) and send model ID in requests
- Add fixed aspect ratio sizes for OpenAI models (bucketing)
- Add ExternalProviderRateLimitError with retry logic for 429 responses
- Add provider-specific UI components in ExternalSettingsAccordion
- Simplify ParamSteps/ParamGuidance by removing dead external overrides
- Update all backend and frontend tests
Add combined resolution preset selector for external models that maps
aspect ratio + image size to fixed dimensions. Gemini 3 Pro and 3.1 Flash
now send imageConfig (aspectRatio + imageSize) via generationConfig instead
of text-based aspect ratio hints used by Gemini 2.5 Flash.
Backend: ExternalResolutionPreset model, resolution_presets capability field,
image_size on ExternalGenerationRequest, and Gemini provider imageConfig logic.
Frontend: ExternalSettingsAccordion with combo resolution select, dimension
slider disabling for fixed-size models, and panel schema constraint wiring
for Steps/Guidance/Seed controls.
Add 'external', 'external_image_generator', and 'external_api' to Zod
enum schemas (zBaseModelType, zModelType, zModelFormat) to match the
generated OpenAPI types. Remove redundant union workarounds from
component prop types and Record definitions.
Fix type errors in ModelEdit (react-hook-form Control invariance),
parsing.tsx (model identifier narrowing), buildExternalGraph (edge
typing), and ModelSettings import/export buttons.
Move external_gemini_base_url and external_openai_base_url into
api_keys.yaml alongside the API keys so all external provider config
lives in one dedicated file, separate from invokeai.yaml.
* Repair partially loaded Qwen models after cancel to avoid device mismatches
* ruff
* Repair CogView4 text encoder after canceled partial loads
* Avoid MPS CI crash in repair regression test
* Fix MPS device assertion in repair test
* fix(ui): resolve models by name+base+type when recalling metadata for reinstalled models
When a model (IP Adapter, ControlNet, etc.) is deleted and reinstalled,
it gets a new UUID key. Previously, metadata recall would fail because
it only looked up models by their stored UUID key. Now the recall falls
back to searching by name+base+type, allowing reinstalled models with
the same name to be correctly resolved.
https://claude.ai/code/session_01XYubzMK363BXGTvfJJqFnX
* Add hash-based model recall fallback for reinstalled models
When a model is deleted and reinstalled, it gets a new UUID key but
retains the same BLAKE3 content hash. This adds hash as a middle
fallback stage in model resolution (key → hash → name+base+type),
making recall more robust.
Changes:
- Add /api/v2/models/get_by_hash backend endpoint (uses existing
search_by_hash from model records store)
- Add getModelConfigByHash RTK Query endpoint in frontend
- Add hash fallback to both resolveModel and parseModelIdentifier
https://claude.ai/code/session_01XYubzMK363BXGTvfJJqFnX
* Chore pnpm fix
* Chore typegen
---------
Co-authored-by: Claude <noreply@anthropic.com>
When deleting a file-based model (e.g. LoRA), the previous logic used
rmtree on the parent directory, which would delete all files in that
folder — even unrelated ones. Now only the specific model file is
removed, and the parent directory is cleaned up only if empty afterward.
* feat: add strict_password_checking config option to relax password requirements
- Add `strict_password_checking: bool = Field(default=False)` to InvokeAIAppConfig
- Add `get_password_strength()` function to password_utils.py (returns weak/moderate/strong)
- Add `strict_password_checking` field to SetupStatusResponse API endpoint
- Update users_base.py and users_default.py to accept `strict_password_checking` param
- Update auth.py router to pass config.strict_password_checking to all user service calls
- Create shared frontend utility passwordUtils.ts for password strength validation
- Update AdministratorSetup, UserProfile, UserManagement components to:
- Fetch strict_password_checking from setup status endpoint
- Show colored strength indicators (red/yellow/blue) in non-strict mode
- Allow any non-empty password in non-strict mode
- Maintain strict validation behavior when strict_password_checking=True
- Update SetupStatusResponse type in auth.ts endpoint
- Add passwordStrength and passwordHelperRelaxed translation keys to en.json
- Add tests for new get_password_strength() function
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Changes before error encountered
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore(backend): docstrings
* chore(frontend): typegen
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Jonathan <34005131+JPPhoto@users.noreply.github.com>
* perf(flux2): optimize model loading order to prevent cache eviction (fixes#7513)
* Update flux2_klein_text_encoder.py
* Update flux2_klein_text_encoder.py version
---------
Co-authored-by: Alexander Eichhorn <alex@eichhorn.dev>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
The reidentify endpoint overwrote the model's relative path with an
absolute path from the prober, and unconditionally accessed
trigger_phrases which doesn't exist on all config types (e.g. IP
Adapters), causing an AttributeError.
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* Fix: Kill the server with one keyboard interrupt (#94)
* Initial plan
* Handle KeyboardInterrupt in run_app to allow single Ctrl+C shutdown
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Force os._exit(0) on KeyboardInterrupt to avoid hanging on background threads
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Fix graceful shutdown to wait for download/install worker threads (#102)
* Initial plan
* Replace os._exit(0) with ApiDependencies.shutdown() on KeyboardInterrupt
Instead of immediately force-exiting the process on CTRL+C, call
ApiDependencies.shutdown() to gracefully stop the download and install
manager services, allowing active work to complete or cancel cleanly
before the process exits.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Make stop() idempotent in download and model install services
When CTRL+C is pressed, uvicorn's graceful shutdown triggers the FastAPI
lifespan which calls ApiDependencies.shutdown(), then a KeyboardInterrupt
propagates from run_until_complete() hitting the except block which tries
to call ApiDependencies.shutdown() a second time.
Change both stop() methods to return silently (instead of raising) when
the service is not running. This handles:
- Double-shutdown: lifespan already stopped the services
- Early interrupt: services were never fully started
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Fix shutdown hang on session processor thread lock (#108)
* Initial plan
* Fix shutdown hang: wake session processor thread on stop() and mark daemon
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix: shut down asyncio executor on KeyboardInterrupt to prevent post-generation hang (#112)
Fix: cancel pending asyncio tasks before loop.close() to suppress destroyed-task warnings
Fix: suppress stack trace when dispatching events after event loop is closed on shutdown
Fix: cancel in-progress generation on stop() to prevent core dump during mid-flight Ctrl+C
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
`get_token_permission` is deprecated and will be removed in huggingface_hub 1.0.
Use `whoami()` to validate the token instead, as recommended by the deprecation warning.
* Add comprehensive multi-user support specification and implementation plan
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Clarify Python tooling transition state
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add executive summary for multi-user support specification
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Reorganize multiuser docs into subfolder and update with approved design decisions
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* docs: fix mkdocs syntax issues
* Fix Z-Image VAE operations not reserving working memory for OOM prevention (#8)
* Initial plan
* Fix Z-Image VAE encode/decode to request working memory
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add test for Z-Image working memory estimation
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix unit test: only set config attribute for AutoencoderKL, not FluxAutoEncoder
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* style: fix ruff errors
* Fix test: use model_construct to bypass Pydantic validation for mock fields
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore(ruff): fix ruff errors
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* Phase 1: Add multi-user database schema and authentication foundation (#6)
* Initial plan
* Add Phase 1: Database schema, authentication utilities, and user service
- Added dependencies: passlib[bcrypt], python-jose[cryptography], email-validator
- Created migration_25 for multi-user support database schema
- users table with authentication fields
- user_sessions, user_invitations, shared_boards tables
- Added user_id columns to boards, images, workflows, session_queue, style_presets
- Created system user for backward compatibility
- Implemented authentication utilities
- Password hashing and validation (password_utils.py)
- JWT token generation and verification (token_service.py)
- Implemented user service
- Abstract base class (users_base.py)
- SQLite implementation (users_default.py)
- Full CRUD operations for users
- Authentication and admin management
- Added comprehensive tests for all components
- All code passes ruff linting and mypy type checking
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Refactor user service to use transaction pattern and improve security documentation
- Changed all database operations to use self._db.transaction() context manager
- Follows the same pattern as other services like board_records
- Improves thread safety and transaction management
- Added detailed security warnings for the hardcoded JWT secret key
- Documented that it must be moved to config before production
- Fixed whitespace linting issues
- All tests still pass with the refactored code
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix system user email to use valid domain
- Changed system user email from system@invokeai.local to system@system.invokeai
- .local domains are rejected by email-validator as special-use/reserved
- All end-to-end tests now pass successfully
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix test failures: password length, migration chain, and table existence checks
- Fixed bcrypt 72-byte password limit by truncating long passwords in hash_password and verify_password
- Fixed test_migration_25 to use callback directly instead of migrator to avoid fragmented chain error
- Updated system user email assertion in test from @invokeai.local to @system.invokeai
- Added table existence checks for boards, images, workflows, and session_queue before altering them
- This prevents "no such table" errors when migration runs in environments without all tables
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* (chore) fix ruff errors
* (chore) fix ruff errors (2)
* Fix test failures: use _conn instead of conn and improve password truncation
- Fixed test_user_service.py to use db._conn instead of db.conn (SqliteDatabase uses private _conn)
- Simplified password truncation logic in password_utils.py for better clarity
- Ensured UTF-8 decoding handles truncated bytes properly with errors="ignore"
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore(uv): updated uv lockfile
* Fix bcrypt password length errors by configuring passlib properly
- Added bcrypt__relax_truncate_checks=True to CryptContext to prevent errors on long passwords
- Removed min_length=8 constraint from pydantic models to allow service-level validation
- Service-level validation provides better error messages and more control
- Manual truncation code kept as safety net for passwords >72 bytes
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix bcrypt parameter name: use truncate_error instead of relax_truncate_checks
- Changed bcrypt__relax_truncate_checks=True to bcrypt__truncate_error=False
- The correct passlib parameter is truncate_error (not relax_truncate_checks)
- Setting it to False allows passwords >72 bytes without raising an error
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* fix(passwords) downgrade bcrypt to work with current passlib
* chore(uv): update locks file
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* Implement Phase 2: Authentication Service with JWT and FastAPI Integration (#11)
* Initial plan
* Add Phase 2 authentication service - auth dependencies, router, and service integration
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Address code review feedback - add token expiration constants and improve documentation
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix email validation to allow special-use domains like .local for testing
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix system user to not be admin - allows /auth/setup to work on fresh database
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore: typegen
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* Add Phase 3 integration tests and documentation for authentication middleware (#15)
* Initial plan
* Add Phase 3 integration tests for auth router endpoints
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add Phase 3 completion documentation and testing guide
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore: ruff
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* chore: fix unresolved merged conflict markers
* Phase 4: Add multi-tenancy to boards and session queue services (#17)
* Initial plan
* Update boards service for multi-user support
- Add user_id parameter to board creation and filtering
- Update board_records base and SQLite implementation to filter by user
- Include shared boards and public boards in user queries
- Update boards router to require authentication
- Update invocation context to pass user_id from queue item
- Add user_id field to SessionQueueItem model
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Update session_queue service for multi-user support
- Add user_id parameter to enqueue_batch method
- Update ValueToInsertTuple to include user_id
- Update prepare_values_to_insert to accept and use user_id
- Update SQL INSERT statements to include user_id column
- Update session_queue router to require authentication
- Update retry_items_by_id to preserve user_id when retrying
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add authentication imports to images, workflows, and style_presets routers
- Import CurrentUser dependency in all three routers
- Add CurrentUser parameter to upload_image endpoint
- Prepare for further authentication requirements in these services
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add multiuser tests and Phase 4 documentation
- Create test_boards_multiuser.py with authentication tests
- Verify board operations require authentication
- Test board creation and listing with auth tokens
- Add comprehensive Phase 4 implementation summary
- Document all changes, data flows, and security considerations
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add authentication to remaining board endpoints
- Add CurrentUser to get_board endpoint
- Add CurrentUser to update_board endpoint
- Add CurrentUser to delete_board endpoint
- Ensures all board operations require authentication
- Addresses code review feedback
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Feature(image boards): Implement per-user board isolation
- Complete verification report with all checks passed
- Document code quality, security, and testing results
- List all achievements and sign-off criteria
- Mark phase as READY FOR MERGE
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore: ruff
* chore: resolve conflicts in z_image_working_memory test
* chore: ruff
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* feat: Implement Phase 5 of multiuser plan - Frontend authentication (#19)
* Phase 5: Implement frontend authentication infrastructure
- Created auth slice with Redux state management for authentication
- Created auth API endpoints (login, logout, setup, me)
- Created LoginPage component for user authentication
- Created AdministratorSetup component for initial admin setup
- Created ProtectedRoute wrapper for route authentication checking
- Updated API configuration to include Authorization headers
- Installed and configured react-router-dom for routing
- Updated App component with authentication routes
- All TypeScript checks passing
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore(style): prettier, typegen and add convenience targets to makefile
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* feat: Implement Phase 6 frontend UI updates - UserMenu and admin restrictions
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
docs: Add comprehensive testing and verification documentation for Phase 6
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
docs: Add Phase 6 summary document
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* feat: Add user management script for testing multiuser features
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* feat: Implement read-only model manager access for non-admin users
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
feat: Add admin authorization to model management API endpoints
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
docs: Update specification and implementation plan for read-only model manager
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Phase 7: Comprehensive testing and security validation for multiuser authentication (#23)
* Initial plan
* Phase 7: Complete test suite with 88 comprehensive tests
- Add password utils tests (31 tests): hashing, verification, validation
- Add token service tests (20 tests): JWT creation, verification, security
- Add security tests (13 tests): SQL injection, XSS, auth bypass prevention
- Add data isolation tests (11 tests): multi-user data separation
- Add performance tests (13 tests): benchmarks and scalability
- Add comprehensive testing documentation
- Add phase 7 verification report
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* bugfix(backend): Fix issues with authentication token expiration handling
- Remove time.sleep from token uniqueness test (use different expiration instead)
- Increase token expiration test time from 1 microsecond to 10 milliseconds
- More reliable test timing to prevent flakiness
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Add Phase 7 summary documentation
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Fix test_performance.py missing logger fixture
Add missing logger fixture to test_performance.py that was causing test failures.
The fixture creates a Logger instance needed by the user_service fixture.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Add board isolation issue specification document
Document the three board isolation issues that need to be addressed:
1. Board list not updating when switching users
2. "Uncategorized" board shared among users
3. Admin cannot access all users' boards
Includes technical details, implementation plan, and acceptance criteria.
This document will be used to create a separate GitHub issue and PR.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Fix test failures in Phase 7 tests
- Fix board service API calls to use enum values (BoardRecordOrderBy, SQLiteDirection) instead of strings
- Fix board deletion test to use get_dto() instead of non-existent get() method
- Add exception handling to verify_password() for invalid hash formats
- Update SQL injection test to accept both 401 and 422 status codes (Pydantic validation)
All fixes ensure tests match actual API signatures and handle edge cases properly.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Fix token forgery test to properly decode and modify JWT payload
The test was attempting to modify the JWT payload by string replacement on the
base64-encoded data, which doesn't work since "false" doesn't appear literally
in the base64 encoding. Fixed to:
- Properly decode the base64 payload
- Parse the JSON
- Modify the is_admin field
- Re-encode the payload
- Create a forged token with the modified payload and original signature
- Verify it's rejected with 401 status
This properly tests that JWT signature verification prevents token forgery.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Fix test_verify_expired_token timing issue
Increased token expiration from 10ms to 100ms and wait time from 20ms to 200ms
to make the test more reliable. The previous timing was too tight and could
cause race conditions where the token hadn't actually expired yet when verified.
This ensures the test reliably validates that expired tokens are properly rejected.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Fix token verification to properly validate signatures and expiration
The verify_token() function was not explicitly enabling JWT verification options,
causing it to accept expired tokens and tokens with modified signatures/payloads.
Fixed by explicitly setting verification options:
- verify_signature: True (reject modified tokens)
- verify_exp: True (reject expired tokens)
- verify_nbf: True (verify "not before" claim)
- verify_iat: True (verify "issued at" claim)
- verify_aud: False (we don't use audience claims)
Also added catch-all exception handler for other validation errors.
This ensures all token security tests pass properly.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Revert to default python-jose verification behavior
Removed explicit options parameter from jwt.decode() call since python-jose
verifies signatures and expiration by default. The explicit options may have
been causing issues or conflicts with the library's default behavior.
Added comments clarifying that python-jose defaults are secure and handle
verification properly. Need user to test and provide debugging output if
issues persist.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Fix JWT expiration verification for python-jose 3.5.0
python-jose 3.5.0 has a bug where expiration verification doesn't work properly
by default. The jwt.decode() function is not rejecting expired tokens even when
they should be rejected.
Workaround implemented:
1. First, get unverified claims to extract the 'exp' timestamp
2. Manually check if current time >= exp time (token is expired)
3. Return None immediately if expired
4. Then verify signature with jwt.decode() for tokens that aren't expired
This ensures:
- Expired tokens are properly rejected
- Signature verification still happens for non-expired tokens
- Modified tokens are rejected due to signature mismatch
All three failing tests should now pass:
- test_verify_expired_token
- test_verify_token_with_modified_payload
- test_token_signature_verification
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix race condition in token verification - verify signature before expiration
Changed the order of verification in verify_token():
1. First verify signature with jwt.decode() - rejects modified/forged tokens
2. Then manually check expiration timestamp
Previous implementation checked expiration first using get_unverified_claims(),
which could cause a race condition where:
- Token with valid payload but INVALID signature would pass expiration check
- If expiration check happened to return None due to timing, signature was never verified
- Modified tokens could be accepted intermittently
New implementation ensures signature is ALWAYS verified first, preventing any
modified tokens from being accepted, while still working around the python-jose
3.5.0 expiration bug by manually checking expiration after signature verification.
This eliminates the non-deterministic test failures in test_verify_token_with_modified_payload.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore(app): ruff
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* Backend: Add admin board filtering and uncategorized board isolation
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix intermittent token service test failures caused by Base64 padding (#32)
* Initial plan
* Fix intermittent token service test failures due to Base64 padding
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Address code review: add constants for magic numbers in tests
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore(tests): ruff
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* Implement user isolation for session queue and socket events (WIP - debugging queue visibility) (#30)
* Add user isolation for queue events and field values filtering
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add user column to queue list UI
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add field values privacy indicator and implementation documentation
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Allow all users to see queue item status events while keeping invocation events private
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore(backend): ruff
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* Fix Queue tab not updating for other users in real-time (#34)
* Initial plan
* Add SessionQueueItemIdList invalidation to queue socket events
This ensures the queue item list updates in real-time for all users when
queue events occur (status changes, batch enqueued, queue cleared).
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add SessionQueueItemIdList invalidation to queue_items_retried event
Ensures queue list updates when items are retried.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Improve queue_items_retried event and mutation invalidation
- Add individual item invalidation to queue_items_retried event handler
- Add SessionQueueStatus and BatchStatus tags to retryItemsById mutation
- Ensure consistency between event handler and mutation invalidation patterns
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add privacy check for batch field values in Queue tab
Displays "Hidden for privacy" message for non-admin users viewing
queue items they don't own, instead of showing the actual field values.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* i18n(frontend): change wording of queue values suppressed message
* Add SessionQueueItemIdList cache invalidation to queue events
Ensures real-time queue updates for all users by invalidating the
SessionQueueItemIdList cache tag when queue events occur.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* Fix multiuser information leakage in Queue panel detail view (#38)
* Initial plan
* Implement multiuser queue information leakage fix
- Backend: Update sanitize_queue_item_for_user to clear session graph and workflow
- Frontend: Add permission check to disable detail view for unauthorized users
- Add test for sanitization logic
- Add translation key for permission denied message
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix prettier formatting for QueueItemComponent
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Address code review feedback
- Move Graph and GraphExecutionState imports to top of file
- Remove dependency on test_nodes in sanitization test
- Create minimal test invocation directly in test file
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Address additional code review feedback
- Create shallow copy to avoid mutating original queue_item
- Extract 'system' user_id to constant (SYSTEM_USER_ID)
- Add constant to both backend and frontend for consistency
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix pydantic validation error in test fixture
Add required timestamp fields (created_at, updated_at, started_at, completed_at) to SessionQueueItem in test fixture
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* fix(queue): Enforce user permissions for queue operations in multiuser mode (#36)
* Initial plan
* Add backend authorization checks for queue operations
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix linting issues in authorization changes
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add frontend authorization checks for queue operations
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add access denied messages for cancel and clear operations
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix access denied messages for all cancel/delete operations
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix merge conflict duplicates in QueueItemComponent
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore(frontend): typegen
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* fix(multiuser): Isolate client state per user to prevent data leakage (#40)
* Implement per-user client state storage to fix multiuser leakage
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix: Make authentication optional for client_state endpoints to support single-user mode
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Clear params state on logout/login to prevent user data leakage
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* feat(queue): show user/total pending jobs in multiuser mode badge (#43)
* Initial plan
* Add multiuser queue badge support - show X/Y format in multiuser mode
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Format openapi.json with Prettier
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Address code review feedback - optimize DB queries and improve code clarity
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* translationBot(ui): update translation files (#8767)
Updated by "Cleanup translation files" hook in Weblate.
Translate-URL: https://hosted.weblate.org/projects/invokeai/web-ui/
Translation: InvokeAI/Web UI
* Limit automated issue closure to bug issues only (#8776)
* Initial plan
* Add only-labels parameter to limit automated issue closure to bugs only
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* fix(multiuser): Isolate client state per user to prevent data leakage (#40)
* Implement per-user client state storage to fix multiuser leakage
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix: Make authentication optional for client_state endpoints to support single-user mode
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Clear params state on logout/login to prevent user data leakage
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Initial plan
* chore(backend) ruff & typegen
* Fix real-time badge updates by invalidating SessionQueueStatus on queue events
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Weblate (bot) <hosted@weblate.org>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* Convert session queue isolation logs from info to debug level
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add JWT secret storage in database and app_settings service
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add multiuser configuration option with default false
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Update token service tests to initialize JWT secret
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix app_settings_service to use proper database transaction pattern
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore(backend): typegen and ruff
* chore(docs): update docstrings
* Fix frontend to bypass authentication in single-user mode
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix auth tests to enable multiuser mode
Auth tests were failing because the login and setup endpoints now return 403 when multiuser mode is disabled (the default). Updated test fixtures to enable multiuser mode for all auth-related tests.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix model manager UI visibility in single-user mode
Model manager UI for adding, deleting and modifying models is now:
- Visible in single-user mode (multiuser: false, the default)
- Hidden in multiuser mode for non-admin users
- Visible in multiuser mode for admin users
Created useIsModelManagerEnabled hook that checks multiuser_enabled status
and returns true when multiuser is disabled OR when user is admin.
Updated all model manager components to use this hook instead of direct
is_admin checks.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore(backend): ruff
* chore(frontend): typegen
* Fix TypeScript lint errors
- Added multiuser_enabled field to SetupStatusResponse type in auth.ts
- Removed unused user variable reference in MainModelDefaultSettings.tsx
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix test_data_isolation to enable multiuser mode
Added fixture to enable multiuser mode for data isolation tests, similar to other auth tests.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Redirect login and setup pages to app in single-user mode
When multiuser mode is disabled, the LoginPage and AdministratorSetup components now redirect to /app instead of showing the login/setup forms. This prevents users from being stuck on the login page after browser refresh in single-user mode.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix test_auth.py to initialize JWT secret
Added setup_jwt_secret fixture to test_auth.py to initialize the JWT secret before running auth tests. This fixture was missing, causing token creation/verification to fail in auth router tests.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Prevent login form flash in single-user mode
Show loading spinner instead of login/setup forms when multiuser mode is disabled or when redirecting is about to happen. This prevents the unattractive flash of the login dialog when refreshing the page in single-user mode.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix board and queue operations in single-user mode
Changed boards, session_queue, and images routers to use CurrentUserOrDefault instead of CurrentUser. This allows these endpoints to work without authentication when multiuser mode is disabled (default), fixing the issue where users couldn't create boards or add jobs to the queue in single-user mode.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add user management utilities and rename add_user.py
Created three user management scripts in the scripts/ directory:
- useradd.py (renamed from add_user.py) - add users with admin privileges
- userdel.py - delete users by email address with confirmation
- usermod.py - modify user details (name, password, admin status)
All scripts support both CLI and interactive modes for flexibility.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix ESLint errors in frontend code
- Fixed brace-style issue in App.tsx (else-if on same line)
- Removed unused useAppSelector imports from model manager components
- Fixed import sorting in ControlAdapterModelDefaultSettings.tsx
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add userlist.py script for viewing database users
Created scripts/userlist.py to display all users in the database. Supports:
- Table format (default): Shows ID, email, display name, admin status, and active status
- JSON format (--json flag): Outputs user data as JSON for scripting/automation
Example usage:
python scripts/userlist.py # Table view
python scripts/userlist.py --json # JSON output
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix test_boards_multiuser.py test failures
Fixed test failures caused by ApiDependencies.invoker not being set properly:
- Added setup_jwt_secret fixture to initialize JWT secret for token generation
- Added enable_multiuser_for_tests fixture that sets ApiDependencies.invoker as a class attribute
- Updated tests to use enable_multiuser_for_tests fixture to ensure ApiDependencies is properly configured
- Removed MockApiDependencies class approach in favor of directly setting the class attribute
This fixes the AttributeError and ensures all tests have the proper setup.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore(backend): ruff
* Fix userlist.py SqliteDatabase initialization
Fixed AttributeError in userlist.py where SqliteDatabase was being passed the config object instead of config.db_path. The constructor expects a Path object (db_path) as the first argument, not the entire config object.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix test_boards_multiuser.py by adding app_settings service to mock
Added AppSettingsService initialization to the mock_services fixture in tests/conftest.py. The test was failing because setup_jwt_secret fixture expected mock_invoker.services.app_settings to exist, but it wasn't being initialized in the mock services.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* bugfix(scripts): fix crash in userlist.py script
* Fix test_boards_multiuser.py JWT secret initialization
Fixed setup_jwt_secret fixture to call set_jwt_secret() directly instead of trying to access non-existent app_settings service. Removed incorrect app_settings parameter from InvocationServices initialization in tests/conftest.py since app_settings is not an attribute of InvocationServices.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix CurrentUserOrDefault to require auth in multiuser mode
Changed get_current_user_or_default to raise HTTP 401 when multiuser mode is enabled and credentials are missing, invalid, or the user is inactive. This ensures that board/queue/image operations require authentication in multiuser mode while still working without authentication in single-user mode (default).
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore(front & backend): ruff and lint
* Add AdminUserOrDefault and fix model settings in single-user mode
Created AdminUserOrDefault dependency that allows admin operations to work without authentication in single-user mode while requiring admin privileges in multiuser mode. Updated model_manager router to use AdminUserOrDefault for update_model_record, update_model_image, and reidentify_model endpoints. This fixes the "Missing authentication credentials" error when saving model default settings in single-user mode.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix model manager operations in single-user mode
Changed all model manager endpoints from AdminUser to AdminUserOrDefault to allow model installation, deletion, conversion, and cache management operations to work without authentication in single-user mode. This fixes the issue where users couldn't add or delete models in single-user mode.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix syntax error in model_manager.py
Added Depends(AdminUserOrDefault) to all AdminUserOrDefault dependency parameters to fix Python syntax error where parameters without defaults were following parameters with defaults. Imported Depends from fastapi.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix FastAPI dependency injection syntax error
Removed type annotations from AdminUserOrDefault dependency parameters. FastAPI doesn't allow both Annotated type hints and = Depends() default values together. Changed from `_: AdminUserOrDefault = Depends(AdminUserOrDefault)` to `_ = Depends(AdminUserOrDefault)` throughout model_manager.py.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix delete_model endpoint parameter annotation
Changed delete_model endpoint to use Annotated[str, Path(...)] instead of str = Path(...) to match FastAPI's preferred syntax and fix the 422 Unprocessable Entity error when deleting models in single-user mode.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix parameter annotations for all AdminUserOrDefault endpoints
Changed all endpoints using AdminUserOrDefault from old syntax (key: str = Path(...)) to FastAPI's preferred Annotated syntax (key: Annotated[str, Path(...)]). This fixes 422 Unprocessable Entity errors when updating model settings and deleting models in single-user mode. Updated endpoints: delete_model_image, install_model, install_hugging_face_model, and convert_model.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Revert to correct AdminUserOrDefault usage pattern
Reverted model_manager.py to state before commit c47af8f and reapplied AdminUserOrDefault correctly. Changed from `_: AdminUser` to `current_admin: AdminUserOrDefault` using the same pattern as boards.py (`current_user: CurrentUserOrDefault`). This fixes all 422 errors in single-user mode while maintaining proper admin authentication in multiuser mode.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix parameter order for AdminUserOrDefault in model manager
Moved current_admin: AdminUserOrDefault parameter before all parameters with default values in model_manager.py endpoints. Python requires parameters without defaults to come before parameters with defaults. Fixed 8 endpoints: delete_model, bulk_delete_models, delete_model_image, install_model, install_hugging_face_model, cancel_model_install_job, convert_model, and do_hf_login.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore(frontend): typegen
* chore(frontend): typegen again
* Docs(app): Comprehensive Documentation of Multiuser Features (#50)
* Implement Phase 8: Complete multiuser documentation (user, admin, and API guides)
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Update multiuser documentation for single-user mode and CLI scripts
- Document multiuser config option (true/false/absent)
- Explain single-user mode behavior (no login required)
- Document mode switching and legacy "system" user
- Update user management to reference CLI scripts (useradd, userdel, usermod, userlist)
- Note that web UI for user management is coming in future release
- Add adaptive API client example for both modes
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* docs(multiuser): bring user guide documentation up to date
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* docs(app): update multiuser documentation
* bugfix(app): fix misaligned database migration calls
* chore(tests): update migration test to accommodate resequencing of migrations
* fix(frontend): prevent caching of static pages
* chore(backend): ruff
* fix(backend): fix incorrect migration import
* Fix: Admin users can see image previews from other users' generations (#61)
* Initial plan
* Fix: strip image preview from InvocationProgressEvent sent to admin room
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore: ruff
* fix(backend): add migration_29 file
* chore(tests): fix migration_29 test
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* fix(queue): System user queue items show blank instead of `<hidden>` for non-admin users (#63)
* Initial plan
* fix(queue): System user queue items show blank instead of `<hidden>` for non-admin users
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore(backend): ruff
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* Hide "Use Cache" checkbox in node editor for non-admin users in multiuser mode (#65)
* Initial plan
* Hide use cache checkbox for non-admin users in multiuser mode
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix node loading hang when invoke URL ends with /app (#67)
* Initial plan
* Fix node loading hang when URL ends with /app
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Move user management scripts to installable module with CLI entry points (#69)
* Initial plan
* Add user management module with invoke-useradd/userdel/userlist/usermod entry points
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* chore(util): remove superceded user administration scripts
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* chore(backend): reorganized migrations, but something still broken
* Fix migration 28 crash when `client_state.data` column is absent (#70)
* Initial plan
* Fix migration 28 to handle missing data column in client_state table
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Consolidate multiuser DB migrations 27–29 into a single migration step (#71)
* Initial plan
* Consolidate migrations 27, 28, and 29 into a single migration step
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add `--root` option to user management CLI utilities (#81)
* Initial plan
* Add --root option to user management CLI utilities
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix queue clear() endpoint to respect user_id for multi-tenancy (#75)
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Add tests for session queue clear() user_id scoping
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
chore(frontend): rebuild typegen
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
* fix: use AdminUserOrDefault for pause and resume queue endpoints (#77)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* fix: queue pause/resume buttons disabled in single-user mode (#83)
In single-user mode, currentUser is never populated (no auth), so
`currentUser?.is_admin ?? false` always returns false, disabling the buttons.
Follow the same pattern as useIsModelManagerEnabled: treat as admin
when multiuser mode is disabled, and check is_admin flag when enabled.
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* fix: enforce board ownership checks in multiuser mode (#84)
- get_board: verify current user owns the board (or is admin), return 403 otherwise
- update_board: verify ownership before updating, 404 if not found, 403 if unauthorized
- delete_board: verify ownership before deleting, 404 if not found, 403 if unauthorized
- list_all_board_image_names: add CurrentUserOrDefault auth and ownership check for non-'none' board IDs
test: add ownership enforcement tests for board endpoints in multiuser mode
- Auth requirement tests for get, update, delete, and list_image_names
- Cross-user 403 forbidden tests (non-owner cannot access/modify/delete)
- Admin bypass tests (admin can access/update/delete any user's board)
- Board listing isolation test (users only see their own boards)
- Refactored fixtures to use monkeypatch (consistent with other test files)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix: Clear auth state when switching from multiuser to single-user mode (#86)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix race conditions in download queue and model install service (#98)
* Initial plan
* Fix race conditions in download queue and model install service
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: Weblate (bot) <hosted@weblate.org>
Co-authored-by: Jonathan <34005131+JPPhoto@users.noreply.github.com>
* WIP: Add FLUX.2 Klein LoRA support (BFL PEFT format)
Initial implementation for loading and applying LoRA models trained
with BFL's PEFT format for FLUX.2 Klein transformers.
Changes:
- Add LoRA_Diffusers_Flux2_Config and LoRA_LyCORIS_Flux2_Config
- Add BflPeft format to FluxLoRAFormat taxonomy
- Add flux_bfl_peft_lora_conversion_utils for weight conversion
- Add Flux2KleinLoraLoaderInvocation node
Status: Work in progress - not yet fully tested
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(flux2): add LoRA support for FLUX.2 Klein models
Add BFL PEFT LoRA support for FLUX.2 Klein, including runtime conversion
of BFL-format keys to diffusers format with fused QKV splitting, improved
detection of Klein 4B LoRAs via MLP ratio check, and frontend graph wiring.
* feat(flux2): detect Klein LoRA variant (4B/9B) and filter by compatibility
Auto-detect FLUX.2 Klein LoRA variant from tensor dimensions during model
probe, warn on variant mismatch at load time, and filter the LoRA picker
to only show variant-compatible LoRAs.
* Chore Ruff
* Chore pnpm
* Fix detection and loading of 3 unrecognized Flux.2 Klein LoRA formats
Three Flux.2 Klein LoRAs were either unrecognized or misclassified due to
format detection gaps:
1. PEFT-wrapped BFL format (base_model.model.* prefix) was not recognized
because the detector only accepted the diffusion_model.* prefix.
2. Klein 4B LoRAs with hidden_size=3072 were misidentified as Flux.1 due to
a break statement exiting the detection loop before txt_in/vector_in
dimensions could be checked.
3. Flux2 native diffusers format (to_qkv_mlp_proj, ff.linear_in) was not
detected because the detector only checked for Flux.1 diffusers keys.
Also handles mixed PEFT/standard LoRA suffix formats within the same file.
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* Fix bare except clauses and mutable default arguments
Replace bare `except:` with `except Exception:` in sqlite_database.py
and mlsd/utils.py to avoid catching KeyboardInterrupt and SystemExit,
which can prevent graceful shutdowns and mask critical errors (PEP 8
E722).
Replace mutable default arguments (lists) with None in
imwatermark/vendor.py to prevent shared state between calls, which
is a known Python gotcha that can cause subtle bugs when default
mutable objects are modified in place.
* add tests for mutable defaults and bare except fixes
* Simplify exception propagation tests
* Remove unused db initialization in error propagation tests
Removed unused database initialization in tests for KeyboardInterrupt and SystemExit.
---------
Co-authored-by: Jonathan <34005131+JPPhoto@users.noreply.github.com>
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
* feat(z-image): add Z-Image Base (undistilled) model variant support
- Add ZImageVariantType enum with 'turbo' and 'zbase' variants
- Auto-detect variant on import via scheduler_config.json shift value (3.0=turbo, 6.0=zbase)
- Add database migration to populate variant field for existing Z-Image models
- Re-add LCM scheduler with variant-aware filtering (LCM hidden for zbase)
- Auto-reset scheduler to Euler when switching to zbase model if LCM selected
- Update frontend to show/hide LCM option based on model variant
- Add toast notification when scheduler is auto-reset
Z-Image Base models are undistilled and require more steps (28-50) with higher
guidance (3.0-5.0), while Z-Image Turbo is distilled for ~8 steps with CFG 1.0.
LCM scheduler only works with distilled (Turbo) models.
* Chore ruff format
* Chore fix windows path
* feat(z-image): filter LoRAs by variant compatibility and warn on mismatch
LoRA picker now hides Z-Image LoRAs with incompatible variants (e.g. ZBase
LoRAs when using Turbo model). LoRAs without a variant are always shown.
Backend loaders warn at runtime if a LoRA variant doesn't match the
transformer variant.
* Chore typegen
---------
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
The FLUX.2 Klein transformer operates in BN-normalized latent space,
but init_latents from VAE encode were not being normalized before
being passed to the InpaintExtension. This caused a scale mismatch
when merging intermediate_latents (normalized) with noised_init_latents
(unnormalized), resulting in visible artifacts at mask blur boundaries.
Now normalize:
- init_latents_packed before passing to InpaintExtension
- noise_packed for correct interpolation in normalized space
- x (starting latents) for img2img/inpainting workflows
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Jonathan <34005131+JPPhoto@users.noreply.github.com>
* Add script and UI to remove orphaned model files
- This commit adds command-line and Web GUI functionality for
identifying and optionally removing models in the models directory
that are not referenced in the database.
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Add backend service and API routes for orphaned models sync
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Add expandable file list to orphaned models dialog
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* Fix cache invalidation after deleting orphaned models
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
* (bugfix) improve status messages
* docs(backend): add info on the orphaned model detection/removal feature
* Update docs/features/orphaned_model_removal.md
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Co-authored-by: dunkeroni <dunkeroni@gmail.com>
* fix(flux2): Fix image quality degradation at resolutions > 1024x1024
This commit addresses severe quality degradation and artifacts when
generating images larger than 1024x1024 with FLUX.2 Klein models.
Root causes fixed:
1. Dynamic max_image_seq_len in scheduler (flux2_denoise.py)
- Previously hardcoded to 4096 (1024x1024 only)
- Now dynamically calculated based on actual resolution
- Allows proper schedule shifting at all resolutions
2. Smoothed mu calculation discontinuity (sampling_utils.py)
- Eliminated 40-50% mu value drop at seq_len 4300 threshold
- Implemented smooth cosine interpolation (4096-4500 transition zone)
- Gradual blend between low-res and high-res formulas
Impact:
- FLUX.2 Klein 9B: Major quality improvement at high resolutions
- FLUX.2 Klein 4B: Improved quality at high resolutions
- Baseline 1024x1024: Unchanged (no regression)
- All generation modes: T2I and Kontext (reference images)
Fixes: Community-reported quality degradation issue
See: Discord discussions in #garbage-bin and #devchat
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* fix(flux2): Fix high-resolution quality degradation for FLUX.2 Klein
Fixes grid/diamond artifacts and color loss at resolutions > 1024x1024.
Root causes identified and fixed:
- BN normalization was incorrectly applied to random noise input
(diffusers only normalizes image latents from VAE.encode)
- BN denormalization must be applied to output before VAE decode
- mu parameter was resolution-dependent causing over-shifted schedules
at high resolutions (now fixed to 2.02, matching ComfyUI)
Changes:
- Remove BN normalization on noise input (not needed for N(0,1) noise)
- Preserve BN denormalization on denoised output (required for VAE)
- Fix mu to constant 2.02 for all resolutions (matches ComfyUI)
Tested at 2048x2048 with FLUX.2 Klein 4B
* Chore Ruff
---------
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-authored-by: Jonathan <34005131+JPPhoto@users.noreply.github.com>
* fix(flux2): support Heun scheduler for FLUX.2 Klein models
FlowMatchHeunDiscreteScheduler does not support dynamic shifting parameters
(use_dynamic_shifting, base_shift, max_shift, etc.) or sigmas/mu in set_timesteps.
This caused FLUX.2 Klein to fail when using Heun scheduler.
- Create Heun scheduler with only num_train_timesteps and shift parameters
- Use num_inference_steps instead of sigmas for Heun's set_timesteps call
- Euler and LCM schedulers continue to use full dynamic shifting support
* fix(flux2): fix Heun scheduler detection using inspect.signature
The previous hasattr check for state_in_first_order failed because
the attribute doesn't exist before set_timesteps() is called. Now
using inspect.signature to check for sigmas parameter support,
matching the FLUX1 implementation.
---------
Co-authored-by: Jonathan <34005131+JPPhoto@users.noreply.github.com>
* Implemented ordering for expanded iterators
* Update test_graph_execution_state.py
Added a test for nested iterator execution ordering. (Failing at commit time!)
* Filter invalid nested-iterator parent mappings in _prepare()
When a graph has nested iterators, some "ready to run" node combinations do not actually belong together. Previously, the scheduler would still try to build nodes for those mismatched combinations, which could cause the same work to run more than once. This change skips any combination that is missing a valid iterator parent, so nested iterator expansions run once per intended item.
* Fixed Collect node ordering
* ruff
* Removed ordering guarantees from test_node_graph.py
* Fix iterator prep and type compatibility in graph execution
Include iterator nodes in nx_graph_flat so iterators are prepared/expanded correctly. Fix connection type checks to allow subclass-to-base via issubclass. Harden iterator/collector validation to fail cleanly instead of crashing on missing edges. Remove unused nx_graph_with_data(). Added tests to verify proper functionality.
