mirror of
https://github.com/invoke-ai/InvokeAI.git
synced 2026-02-02 20:55:09 -05:00
7d110cc9d3
Dynamic prompts string generators can cause an infinite feedback loop when added to the linear view. The root cause is how these generators handle "resolving" their collections. They hit the dynamic prompts HTTP API within the view component to get the prompts, then set the batch node's internal state with those values. When the same generator is rendered in both the node editor view and linear view and the timing is just right, that state update causes an infinite feedback loop between the two components as they respond to the state updates from the other component. The other generators never store the generated values in the batch node's internal state. The values are "resolved" just-in-time as they are needed. To fix this, the batch value "resolver" utilities could be made async and hit the API. But there's a problem - the resolver utilities are used within the "are we ready to invoke? are there any problems with the current settings?" redux selectors, which are strictly synchronous. To fix that, we can refactor that "are we ready to invoke?" logic to not use redux selectors, so the whole thing could be async. It's not a big change but I'm not going to spend time on it at the moment. So, until I address this, the dynamic prompts generators are disabled.