From 01ac207b92e393182c41726480f9502b6168934e Mon Sep 17 00:00:00 2001 From: tofarr Date: Mon, 13 Jan 2025 14:15:13 -0700 Subject: [PATCH] Fix remove dead code (#6249) --- openhands/server/listen_socket.py | 11 +++-------- openhands/server/session/manager.py | 4 ---- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/openhands/server/listen_socket.py b/openhands/server/listen_socket.py index 027c243288..81816a1325 100644 --- a/openhands/server/listen_socket.py +++ b/openhands/server/listen_socket.py @@ -15,7 +15,6 @@ from openhands.events.observation.agent import AgentStateChangedObservation from openhands.events.serialization import event_to_dict from openhands.events.stream import AsyncEventStreamWrapper from openhands.server.routes.settings import ConversationStoreImpl, SettingsStoreImpl -from openhands.server.session.manager import ConversationDoesNotExistError from openhands.server.shared import config, openhands_config, session_manager, sio from openhands.server.types import AppMode @@ -61,13 +60,9 @@ async def connect(connection_id: str, environ, auth): 'Settings not found', {'msg_id': 'CONFIGURATION$SETTINGS_NOT_FOUND'} ) - try: - event_stream = await session_manager.join_conversation( - conversation_id, connection_id, settings, user_id - ) - except ConversationDoesNotExistError: - logger.error(f'Conversation {conversation_id} does not exist') - raise ConnectionRefusedError(f'Conversation {conversation_id} does not exist') + event_stream = await session_manager.join_conversation( + conversation_id, connection_id, settings, user_id + ) agent_state_changed = None async_stream = AsyncEventStreamWrapper(event_stream, latest_event_id + 1) diff --git a/openhands/server/session/manager.py b/openhands/server/session/manager.py index aa3fec0b3c..45b75805e4 100644 --- a/openhands/server/session/manager.py +++ b/openhands/server/session/manager.py @@ -24,10 +24,6 @@ _CLEANUP_INTERVAL = 15 _CLEANUP_EXCEPTION_WAIT_TIME = 15 -class ConversationDoesNotExistError(Exception): - pass - - @dataclass class _SessionIsRunningCheck: request_id: str