From 91fff77ffe0eeac17f80b9443e91b5ccc4dda9d2 Mon Sep 17 00:00:00 2001 From: Engel Nyst Date: Thu, 24 Apr 2025 16:34:22 +0200 Subject: [PATCH] Fix lint (#8060) --- .../components/features/home/repo-connector.test.tsx | 2 +- openhands/runtime/impl/local/local_runtime.py | 2 +- tests/unit/resolver/github/test_send_pull_request.py | 5 ++--- tests/unit/resolver/gitlab/test_gitlab_send_pull_request.py | 3 +-- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/frontend/__tests__/components/features/home/repo-connector.test.tsx b/frontend/__tests__/components/features/home/repo-connector.test.tsx index 04ae0640fa..13260e6933 100644 --- a/frontend/__tests__/components/features/home/repo-connector.test.tsx +++ b/frontend/__tests__/components/features/home/repo-connector.test.tsx @@ -154,7 +154,7 @@ describe("RepoConnector", () => { expect(createConversationSpy).not.toHaveBeenCalled(); // select a repository from the dropdown - const dropdown = await waitFor(() => + const dropdown = await waitFor(() => within(repoConnector).getByTestId("repo-dropdown") ); await userEvent.click(dropdown); diff --git a/openhands/runtime/impl/local/local_runtime.py b/openhands/runtime/impl/local/local_runtime.py index 3acc4d1886..10a71c3d6c 100644 --- a/openhands/runtime/impl/local/local_runtime.py +++ b/openhands/runtime/impl/local/local_runtime.py @@ -70,7 +70,7 @@ def check_dependencies(code_repo_path: str, poetry_venvs_path: str): server = libtmux.Server() try: session = server.new_session(session_name='test-session') - except Exception as e: + except Exception: raise ValueError('tmux is not properly installed or available on the path.') pane = session.attached_pane pane.send_keys('echo "test"') diff --git a/tests/unit/resolver/github/test_send_pull_request.py b/tests/unit/resolver/github/test_send_pull_request.py index c44e11594c..a5b68e68ca 100644 --- a/tests/unit/resolver/github/test_send_pull_request.py +++ b/tests/unit/resolver/github/test_send_pull_request.py @@ -13,12 +13,13 @@ from openhands.resolver.send_pull_request import ( apply_patch, initialize_repo, load_single_resolver_output, + main, make_commit, process_single_issue, send_pull_request, update_existing_pull_request, ) -from openhands.resolver.send_pull_request import main + @pytest.fixture def mock_output_dir(): @@ -1104,7 +1105,6 @@ def test_main( mock_process_single_issue, mock_parser, ): - # Setup mock parser mock_args = MagicMock() mock_args.token = None @@ -1171,7 +1171,6 @@ def test_main( mock_path_exists.assert_called_with('/mock/output') mock_load_single_resolver_output.assert_called_with('/mock/output/output.jsonl', 42) - # Test for invalid issue number mock_args.issue_number = 'invalid' with pytest.raises(ValueError): diff --git a/tests/unit/resolver/gitlab/test_gitlab_send_pull_request.py b/tests/unit/resolver/gitlab/test_gitlab_send_pull_request.py index 188265ee73..7fe48aec1d 100644 --- a/tests/unit/resolver/gitlab/test_gitlab_send_pull_request.py +++ b/tests/unit/resolver/gitlab/test_gitlab_send_pull_request.py @@ -14,12 +14,12 @@ from openhands.resolver.send_pull_request import ( apply_patch, initialize_repo, load_single_resolver_output, + main, make_commit, process_single_issue, send_pull_request, update_existing_pull_request, ) -from openhands.resolver.send_pull_request import main @pytest.fixture @@ -1007,7 +1007,6 @@ def test_main( mock_process_single_issue, mock_parser, ): - # Setup mock parser mock_args = MagicMock() mock_args.token = None