fix potential flake8 miss checking (#3124)

* fix potential flake8 miss checking * Add unit test for edit_file_by_replace function with problematic file * Add unit test for edit_file_by_replace function with problematic file * Add unit test for edit_file_by_replace function with problematic file * Add unit test for edit_file_by_replace function with problematic file * Add unit test for edit_file function with problematic file * Add unit test for edit_file function with problematic file * Add unit test for edit_file function with problematic file * Add unit test for edit_file function with problematic file * Add unit test for edit_file function with problematic file * Update opendevin/runtime/plugins/agent_skills/agentskills.py Co-authored-by: Boxuan Li <liboxuan@connect.hku.hk> * add test intention description * fix potential flake8 miss checking * fix potential flake8 miss checking * fix potential flake8 miss checking * fix potential flake8 miss checking * fix potential flake8 miss checking --------- Co-authored-by: Boxuan Li <liboxuan@connect.hku.hk> Co-authored-by: Graham Neubig <neubig@gmail.com> Co-authored-by: tobitege <tobitege@gmx.de>
2026-01-10 07:18:10 -05:00 · 2024-08-15 18:23:55 -07:00
parent eab7ea3d37
commit ae5f130881
2 changed files with 74 additions and 1 deletions
--- a/tests/unit/test_agent_skill.py
+++ b/tests/unit/test_agent_skill.py
@@ -604,6 +604,50 @@ check(any_int)"""
            assert result == expected


+def test_edit_file_by_replace_with_multiple_errors(tmp_path):
+    # If the file has multiple errors, but the suggested modification can only fix one error, make sure it is applied.
+    with patch.dict(os.environ, {'ENABLE_AUTO_LINT': 'True'}):
+        content = """def Sum(a,b):
+    try:
+        answer = a + b
+        return answer
+    except Exception:
+        answer = ANOTHER_CONSTANT
+        return answer
+Sum(1,1)
+"""
+
+        temp_file_path = tmp_path / 'problematic-file-test.py'
+        temp_file_path.write_text(content)
+
+        open_file(str(temp_file_path))
+
+        with io.StringIO() as buf:
+            with contextlib.redirect_stdout(buf):
+                edit_file_by_replace(
+                    str(temp_file_path),
+                    to_replace='        answer = a + b',
+                    new_content='        answer = a+b',
+                )
+            result = buf.getvalue()
+            expected = (
+                f'[File: {temp_file_path} (8 lines total after edit)]\n'
+                '(this is the beginning of the file)\n'
+                '1|def Sum(a,b):\n'
+                '2|    try:\n'
+                '3|        answer = a+b\n'
+                '4|        return answer\n'
+                '5|    except Exception:\n'
+                '6|        answer = ANOTHER_CONSTANT\n'
+                '7|        return answer\n'
+                '8|Sum(1,1)\n'
+                '(this is the end of the file)\n'
+                + MSG_FILE_UPDATED.format(line_number=3)
+                + '\n'
+            )
+            assert result.split('\n') == expected.split('\n')
+
+
 # ================================