From b7bbf0f5eb8523ceeb06d5d596cf47ad7aac4f94 Mon Sep 17 00:00:00 2001 From: Xingyao Wang Date: Sat, 4 Jan 2025 23:57:07 -0500 Subject: [PATCH] fix(agent controller): missing await (#6040) --- openhands/controller/agent_controller.py | 2 +- tests/unit/test_agent_controller.py | 13 +------------ 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/openhands/controller/agent_controller.py b/openhands/controller/agent_controller.py index 625d64280c..9c5cae6faa 100644 --- a/openhands/controller/agent_controller.py +++ b/openhands/controller/agent_controller.py @@ -390,7 +390,7 @@ class AgentController: if new_state in (AgentState.STOPPED, AgentState.ERROR): # sync existing metrics BEFORE resetting the agent - self.update_state_after_step() + await self.update_state_after_step() self.state.metrics.merge(self.state.local_metrics) self._reset() elif ( diff --git a/tests/unit/test_agent_controller.py b/tests/unit/test_agent_controller.py index 0eba74edd1..7232757073 100644 --- a/tests/unit/test_agent_controller.py +++ b/tests/unit/test_agent_controller.py @@ -39,11 +39,7 @@ def event_loop(): def mock_agent(): agent = MagicMock(spec=Agent) agent.llm = MagicMock(spec=LLM) - metrics = MagicMock(spec=Metrics) - metrics.costs = [] - metrics.accumulated_cost = 0.0 - metrics.response_latencies = [] - agent.llm.metrics = metrics + agent.llm.metrics = Metrics() return agent @@ -297,13 +293,6 @@ async def test_max_iterations_extension(mock_agent, mock_event_stream): # Test with headless_mode=False - should extend max_iterations initial_state = State(max_iterations=10) - # Set up proper metrics mock with required attributes - metrics = MagicMock(spec=Metrics) - metrics._costs = [] - metrics._response_latencies = [] - metrics.accumulated_cost = 0.0 - mock_agent.llm.metrics = metrics - controller = AgentController( agent=mock_agent, event_stream=mock_event_stream,