github/OpenHands
1
1
Fork 0
mirror of https://github.com/All-Hands-AI/OpenHands.git synced 2026-01-09 23:08:04 -05:00
Code Issues Packages Projects Releases Wiki Activity

Making sure verify_repo_provider is_optional so log is debug not error (#12302)

Browse Source 
Co-authored-by: openhands <openhands@all-hands.dev>
This commit is contained in:
Tim O'Farrell
2026-01-07 22:15:00 -07:00
committed by GitHub
parent cb9e6fde24
commit c97e7082f7
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
openhands/app_server/app_conversation/skill_loader.py
View File

@@ -134,7 +134,9 @@ async def _is_gitlab_repository(repo_name: str, user_context: UserContext) -> bo
"""
try:
provider_handler = await user_context.get_provider_handler() # type: ignore[attr-defined]
repository = await provider_handler.verify_repo_provider(repo_name)
repository = await provider_handler.verify_repo_provider(
repo_name, is_optional=True
)
return repository.git_provider == ProviderType.GITLAB
except Exception:
# If we can't determine the provider, assume it's not GitLab
@@ -156,7 +158,9 @@ async def _is_azure_devops_repository(
"""
try:
provider_handler = await user_context.get_provider_handler() # type: ignore[attr-defined]
repository = await provider_handler.verify_repo_provider(repo_name)
repository = await provider_handler.verify_repo_provider(
repo_name, is_optional=True
)
return repository.git_provider == ProviderType.AZURE_DEVOPS
except Exception:
# If we can't determine the provider, assume it's not Azure DevOps

6
tests/unit/app_server/test_skill_loader.py
View File

@@ -702,7 +702,9 @@ class TestIsGitlabRepository:
# Assert
assert result is True
mock_provider_handler.verify_repo_provider.assert_called_once_with('owner/repo')
mock_provider_handler.verify_repo_provider.assert_called_once_with(
'owner/repo', is_optional=True
)
@pytest.mark.asyncio
async def test_is_gitlab_repository_false(self):
@@ -759,7 +761,7 @@ class TestIsAzureDevOpsRepository:
# Assert
assert result is True
mock_provider_handler.verify_repo_provider.assert_called_once_with(
'org/project/repo'
'org/project/repo', is_optional=True
)
@pytest.mark.asyncio