github/OpenHands
1
1
Fork 0
mirror of https://github.com/All-Hands-AI/OpenHands.git synced 2026-01-09 14:57:59 -05:00
Code Issues Packages Projects Releases Wiki Activity

Property 'message' sent to llm (#1198)

Browse Source 
* Add action with content, no message, to history

* fix to_memory(), add it to serialization tests

* Actions without 'message' in completion too
This commit is contained in:
Engel Nyst
2024-04-18 12:51:07 +02:00
committed by GitHub
parent 51149780ac
commit caabfab7e2
4 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
agenthub/monologue_agent/agent.py
View File

@@ -188,7 +188,7 @@ class MonologueAgent(Agent):
output_type = ActionType.BROWSE output_type = ActionType.BROWSE
else: else:
action = AgentThinkAction(thought=thought) action = AgentThinkAction(thought=thought)
self._add_event(action.to_dict()) self._add_event(action.to_memory())
self._initialized = True self._initialized = True
def step(self, state: State) -> Action: def step(self, state: State) -> Action:
@@ -203,7 +203,7 @@ class MonologueAgent(Agent):
""" """
self._initialize(state.plan.main_goal) self._initialize(state.plan.main_goal)
for prev_action, obs in state.updated_info: for prev_action, obs in state.updated_info:
self._add_event(prev_action.to_dict()) self._add_event(prev_action.to_memory())
self._add_event(obs.to_dict()) self._add_event(obs.to_dict())
state.updated_info = [] state.updated_info = []

2
agenthub/planner_agent/prompt.py
View File

@@ -149,7 +149,7 @@ def get_prompt(plan: Plan, history: List[Tuple[Action, Observation]]) -> str:
latest_action: Action = NullAction() latest_action: Action = NullAction()
for action, observation in sub_history: for action, observation in sub_history:
if not isinstance(action, NullAction): if not isinstance(action, NullAction):
history_dicts.append(action.to_dict()) history_dicts.append(action.to_memory())
latest_action = action latest_action = action
if not isinstance(observation, NullObservation): if not isinstance(observation, NullObservation):
observation_dict = observation.to_dict() observation_dict = observation.to_dict()

9
opendevin/action/base.py
View File

@@ -12,13 +12,18 @@ class Action:
async def run(self, controller: 'AgentController') -> 'Observation': async def run(self, controller: 'AgentController') -> 'Observation':
raise NotImplementedError raise NotImplementedError
def to_dict(self): def to_memory(self):
d = asdict(self) d = asdict(self)
try: try:
v = d.pop('action') v = d.pop('action')
except KeyError: except KeyError:
raise NotImplementedError(f'{self=} does not have action attribute set') raise NotImplementedError(f'{self=} does not have action attribute set')
return {'action': v, 'args': d, 'message': self.message} return {'action': v, 'args': d}
def to_dict(self):
d = self.to_memory()
d['message'] = self.message
return d
@property @property
def executable(self) -> bool: def executable(self) -> bool:

2
tests/test_action_serialization.py
View File

@@ -21,8 +21,10 @@ def serialization_deserialization(original_action_dict, cls):
assert isinstance( assert isinstance(
action_instance, cls), f'The action instance should be an instance of {cls.__name__}.' action_instance, cls), f'The action instance should be an instance of {cls.__name__}.'
serialized_action_dict = action_instance.to_dict() serialized_action_dict = action_instance.to_dict()
serialized_action_memory = action_instance.to_memory()
serialized_action_dict.pop('message') serialized_action_dict.pop('message')
assert serialized_action_dict == original_action_dict, 'The serialized action should match the original action dict.' assert serialized_action_dict == original_action_dict, 'The serialized action should match the original action dict.'
assert serialized_action_memory == original_action_dict, 'The serialized action in memory should match the original action dict.'
def test_agent_think_action_serialization_deserialization(): def test_agent_think_action_serialization_deserialization():