github/OpenHands
1
1
Fork 0
mirror of https://github.com/All-Hands-AI/OpenHands.git synced 2026-01-10 07:18:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

startup handling and logging of docker images tweaked (#3645)

Browse Source
This commit is contained in:
tobitege
2024-08-29 00:17:58 +02:00
committed by GitHub
parent 978951ef88
commit daeff3dfaf
2 changed files with 30 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
openhands/runtime/builder/docker.py
View File

@@ -61,22 +61,29 @@ class DockerRuntimeBuilder(RuntimeBuilder):
return target_image_hash_name
def image_exists(self, image_name: str) -> bool:
"""Check if the image exists in the registry (try to pull it first) AND in the local store.
"""Check if the image exists in the registry (try to pull it first) or in the local store.
Args:
image_name (str): The Docker image to check (<image repo>:<image tag>)
Returns:
bool: Whether the Docker image exists in the registry and in the local store
bool: Whether the Docker image exists in the registry or in the local store
"""
# Try to pull the Docker image from the registry
try:
self.docker_client.images.pull(image_name)
except Exception:
logger.info(f'Cannot pull image {image_name} directly')
images = self.docker_client.images.list()
if images:
for image in images:
if image_name in image.tags:
return True
return False
logger.info(f'Checking, if image {image_name} exists locally.')
self.docker_client.images.get(image_name)
logger.info(f'Image {image_name} found locally.')
return True
except docker.errors.ImageNotFound:
try:
logger.info(
'Image not found locally. Trying to pull it, please wait...'
)
self.docker_client.images.pull(image_name)
logger.info(f'Image {image_name} pulled successfully.')
return True
except docker.errors.ImageNotFound:
logger.info('Could not find image locally or in registry.')
return False
except Exception:
logger.info('Could not pull image directly.')
return False