From fa5395a1a63c0fa78124e483e3b6aef42a89d01b Mon Sep 17 00:00:00 2001 From: David Dixon <165835255+ellosel@users.noreply.github.com> Date: Tue, 29 Jul 2025 18:47:25 -0600 Subject: [PATCH 01/17] Drop lapack install script --- .azuredevops/components/hipBLASLt.yml | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/.azuredevops/components/hipBLASLt.yml b/.azuredevops/components/hipBLASLt.yml index 5afc3f2fe..dcf7ae34f 100644 --- a/.azuredevops/components/hipBLASLt.yml +++ b/.azuredevops/components/hipBLASLt.yml @@ -36,8 +36,10 @@ parameters: - gfortran - git - libdrm-dev + - liblapack-dev - libmsgpack-dev - libnuma-dev + - libopenblas-dev - ninja-build - python3-pip - python3-venv @@ -160,17 +162,6 @@ jobs: script: | echo "##vso[task.prependpath]$(Agent.BuildDirectory)/rocm/bin" echo "##vso[task.prependpath]$(Agent.BuildDirectory)/rocm/llvm/bin" - - task: Bash@3 - displayName: Build and install LAPACK - inputs: - targetType: inline - script: | - mkdir -p $(Agent.BuildDirectory)/temp-deps - cd $(Agent.BuildDirectory)/temp-deps - # position-independent LAPACK is required for almalinux8 builds - cmake -DBUILD_GTEST=OFF -DBUILD_LAPACK=ON -DCMAKE_POSITION_INDEPENDENT_CODE=ON $(Agent.BuildDirectory)/s/deps - make - sudo make install - script: | mkdir -p $(CCACHE_DIR) echo "##vso[task.prependpath]/usr/lib/ccache" From 20762b9a9649ccfb1fe23ceeb55f780d6911ac87 Mon Sep 17 00:00:00 2001 From: Daniel Su Date: Wed, 30 Jul 2025 10:30:00 -0400 Subject: [PATCH 02/17] Add blas and lapack to dnf map --- .azuredevops/templates/steps/dependencies-dnf.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.azuredevops/templates/steps/dependencies-dnf.yml b/.azuredevops/templates/steps/dependencies-dnf.yml index cc48f3ee8..432408cf7 100644 --- a/.azuredevops/templates/steps/dependencies-dnf.yml +++ b/.azuredevops/templates/steps/dependencies-dnf.yml @@ -54,11 +54,13 @@ parameters: libfftw3-dev: fftw-devel libfmt-dev: fmt-devel libgmp-dev: gmp-devel + liblapack-dev: lapack-devel liblzma-dev: xz-devel libmpfr-dev: mpfr-devel libmsgpack-dev: msgpack-devel libncurses5-dev: ncurses-devel libnuma-dev: numactl-devel + libopenblas-dev: openblas-devel libopenmpi-dev: openmpi-devel libpci-dev: libpciaccess-devel libssl-dev: openssl-devel From 6bc408d051d92e3dc05248cfc5c2b6891a0e0fe2 Mon Sep 17 00:00:00 2001 From: Daniel Su Date: Wed, 30 Jul 2025 10:32:52 -0400 Subject: [PATCH 03/17] Change to GPU_TARGETS --- .azuredevops/components/hipBLASLt.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.azuredevops/components/hipBLASLt.yml b/.azuredevops/components/hipBLASLt.yml index dcf7ae34f..cb137d977 100644 --- a/.azuredevops/components/hipBLASLt.yml +++ b/.azuredevops/components/hipBLASLt.yml @@ -185,7 +185,7 @@ jobs: -DCMAKE_C_COMPILER=$(Agent.BuildDirectory)/rocm/llvm/bin/amdclang -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_C_COMPILER_LAUNCHER=ccache - -DAMDGPU_TARGETS=${{ job.target }} + -DGPU_TARGETS=${{ job.target }} -DBUILD_CLIENTS_TESTS=ON -GNinja - template: ${{ variables.CI_TEMPLATE_PATH }}/steps/manifest.yml From 5bbe8ecdcc8eefd6c518c415fb85a5e9765a3698 Mon Sep 17 00:00:00 2001 From: David Dixon <165835255+ellosel@users.noreply.github.com> Date: Wed, 30 Jul 2025 13:34:09 -0600 Subject: [PATCH 04/17] add deps install back --- .azuredevops/components/hipBLASLt.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.azuredevops/components/hipBLASLt.yml b/.azuredevops/components/hipBLASLt.yml index cb137d977..718765321 100644 --- a/.azuredevops/components/hipBLASLt.yml +++ b/.azuredevops/components/hipBLASLt.yml @@ -162,6 +162,17 @@ jobs: script: | echo "##vso[task.prependpath]$(Agent.BuildDirectory)/rocm/bin" echo "##vso[task.prependpath]$(Agent.BuildDirectory)/rocm/llvm/bin" + - task: Bash@3 + displayName: Build and install LAPACK + inputs: + targetType: inline + script: | + mkdir -p $(Agent.BuildDirectory)/temp-deps + cd $(Agent.BuildDirectory)/temp-deps + # position-independent LAPACK is required for almalinux8 builds + cmake -DBUILD_GTEST=OFF -DBUILD_LAPACK=ON -DCMAKE_POSITION_INDEPENDENT_CODE=ON $(Agent.BuildDirectory)/s/deps + make + sudo make install - script: | mkdir -p $(CCACHE_DIR) echo "##vso[task.prependpath]/usr/lib/ccache" From 68bc7f83da2b6e90c2bdc474cb10390eb19d75a1 Mon Sep 17 00:00:00 2001 From: David Dixon <165835255+ellosel@users.noreply.github.com> Date: Wed, 30 Jul 2025 16:11:37 -0600 Subject: [PATCH 05/17] Need both target options while transitioning between build systems --- .azuredevops/components/hipBLASLt.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.azuredevops/components/hipBLASLt.yml b/.azuredevops/components/hipBLASLt.yml index 718765321..b38320d63 100644 --- a/.azuredevops/components/hipBLASLt.yml +++ b/.azuredevops/components/hipBLASLt.yml @@ -196,6 +196,7 @@ jobs: -DCMAKE_C_COMPILER=$(Agent.BuildDirectory)/rocm/llvm/bin/amdclang -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_C_COMPILER_LAUNCHER=ccache + -DAMDGPU_TARGETS=${{ job.target }} -DGPU_TARGETS=${{ job.target }} -DBUILD_CLIENTS_TESTS=ON -GNinja From ac0b72497e8a420588d1ef14681e156280fe6746 Mon Sep 17 00:00:00 2001 From: David Dixon <165835255+ellosel@users.noreply.github.com> Date: Wed, 30 Jul 2025 17:15:13 -0600 Subject: [PATCH 06/17] add python deps for hipblaslt --- .azuredevops/components/hipBLASLt.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.azuredevops/components/hipBLASLt.yml b/.azuredevops/components/hipBLASLt.yml index b38320d63..2b29925dd 100644 --- a/.azuredevops/components/hipBLASLt.yml +++ b/.azuredevops/components/hipBLASLt.yml @@ -49,6 +49,15 @@ parameters: - joblib - "packaging>=22.0" - --upgrade + - "dataclasses;python_version == '3.6'" + - pyyaml + - msgpack + - "joblib>=1.4.0; python_version >= '3.8'" + - "joblib>=1.1.1; python_version < '3.8'" + - simplejson + - ujson + - orjson + - yappi - name: rocmDependencies type: object default: From 7c111269385ecb369bbd615d991a186d5cd9defd Mon Sep 17 00:00:00 2001 From: David Dixon <165835255+ellosel@users.noreply.github.com> Date: Thu, 31 Jul 2025 08:30:25 -0600 Subject: [PATCH 07/17] Fix pip args --- .azuredevops/components/hipBLASLt.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.azuredevops/components/hipBLASLt.yml b/.azuredevops/components/hipBLASLt.yml index 2b29925dd..5de54781e 100644 --- a/.azuredevops/components/hipBLASLt.yml +++ b/.azuredevops/components/hipBLASLt.yml @@ -48,16 +48,13 @@ parameters: default: - joblib - "packaging>=22.0" - - --upgrade - - "dataclasses;python_version == '3.6'" - pyyaml - msgpack - - "joblib>=1.4.0; python_version >= '3.8'" - - "joblib>=1.1.1; python_version < '3.8'" - simplejson - ujson - orjson - yappi + - --upgrade - name: rocmDependencies type: object default: From b6b7b32e6da6c8e10ec8cfbeabbf38c5e0b60770 Mon Sep 17 00:00:00 2001 From: David Dixon <165835255+ellosel@users.noreply.github.com> Date: Thu, 31 Jul 2025 17:40:03 -0600 Subject: [PATCH 08/17] Disable blis for new build system --- .azuredevops/components/hipBLASLt.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.azuredevops/components/hipBLASLt.yml b/.azuredevops/components/hipBLASLt.yml index 5de54781e..aab22a298 100644 --- a/.azuredevops/components/hipBLASLt.yml +++ b/.azuredevops/components/hipBLASLt.yml @@ -205,6 +205,7 @@ jobs: -DAMDGPU_TARGETS=${{ job.target }} -DGPU_TARGETS=${{ job.target }} -DBUILD_CLIENTS_TESTS=ON + -DHIPBLASLT_ENABLE_BLIS=OFF -GNinja - template: ${{ variables.CI_TEMPLATE_PATH }}/steps/manifest.yml parameters: From 6a37323fe718b8161ef1e0061f68744b4d79bef9 Mon Sep 17 00:00:00 2001 From: David Dixon <165835255+ellosel@users.noreply.github.com> Date: Sat, 2 Aug 2025 08:00:38 -0600 Subject: [PATCH 09/17] Enable rocroller and use fetch content --- .azuredevops/components/hipBLASLt.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.azuredevops/components/hipBLASLt.yml b/.azuredevops/components/hipBLASLt.yml index aab22a298..1a0289ced 100644 --- a/.azuredevops/components/hipBLASLt.yml +++ b/.azuredevops/components/hipBLASLt.yml @@ -205,6 +205,8 @@ jobs: -DAMDGPU_TARGETS=${{ job.target }} -DGPU_TARGETS=${{ job.target }} -DBUILD_CLIENTS_TESTS=ON + -DHIPBLASLT_ENABLE_ROCROLLER=ON + -DHIPBLASLT_ENABLE_FETCH=ON -DHIPBLASLT_ENABLE_BLIS=OFF -GNinja - template: ${{ variables.CI_TEMPLATE_PATH }}/steps/manifest.yml From d63db0be41bf9357d75e1452ace329e73d144f5e Mon Sep 17 00:00:00 2001 From: David Dixon <165835255+ellosel@users.noreply.github.com> Date: Wed, 6 Aug 2025 08:28:47 -0600 Subject: [PATCH 10/17] debug commit --- .azuredevops/components/hipBLASLt.yml | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/.azuredevops/components/hipBLASLt.yml b/.azuredevops/components/hipBLASLt.yml index 1a0289ced..4e7471d4a 100644 --- a/.azuredevops/components/hipBLASLt.yml +++ b/.azuredevops/components/hipBLASLt.yml @@ -97,16 +97,16 @@ parameters: #- { pool: rocm-ci_medium_build_pool, os: almalinux8, packageManager: dnf, target: gfx1030 } testJobs: - { os: ubuntu2204, packageManager: apt, target: gfx942 } - - { os: ubuntu2204, packageManager: apt, target: gfx90a } -- name: downstreamComponentMatrix - type: object - default: - - rocBLAS: - name: rocBLAS - sparseCheckoutDir: projects/rocblas - skipUnifiedBuild: 'false' - buildDependsOn: - - hipBLASLt_build + #- { os: ubuntu2204, packageManager: apt, target: gfx90a } +#- name: downstreamComponentMatrix +# type: object +# default: +# - rocBLAS: +# name: rocBLAS +# sparseCheckoutDir: projects/rocblas +# skipUnifiedBuild: 'false' +# buildDependsOn: +# - hipBLASLt_build jobs: - ${{ each job in parameters.jobMatrix.buildJobs }}: @@ -208,6 +208,7 @@ jobs: -DHIPBLASLT_ENABLE_ROCROLLER=ON -DHIPBLASLT_ENABLE_FETCH=ON -DHIPBLASLT_ENABLE_BLIS=OFF + -DTENSILELITE_LOGIC_FILTER="gfx942/GridBased/*Bljk_DB_UserArgs" -GNinja - template: ${{ variables.CI_TEMPLATE_PATH }}/steps/manifest.yml parameters: @@ -285,7 +286,7 @@ jobs: componentName: ${{ parameters.componentName }} os: ${{ job.os }} testDir: '$(Agent.BuildDirectory)/rocm/bin' - testExecutable: './hipblaslt-test' + testExecutable: 'TENSILE_DB=0xFFFF ./hipblaslt-test' testParameters: '--gtest_output=xml:./test_output.xml --gtest_color=yes --gtest_filter=*pre_checkin*' - template: ${{ variables.CI_TEMPLATE_PATH }}/steps/docker-container.yml parameters: From ee4287fdd73e5cb8ff25715c0378578a362ea355 Mon Sep 17 00:00:00 2001 From: David Dixon <165835255+ellosel@users.noreply.github.com> Date: Wed, 6 Aug 2025 08:55:28 -0600 Subject: [PATCH 11/17] parallellize lapack build --- .azuredevops/components/hipBLASLt.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.azuredevops/components/hipBLASLt.yml b/.azuredevops/components/hipBLASLt.yml index 4e7471d4a..0dd8456d1 100644 --- a/.azuredevops/components/hipBLASLt.yml +++ b/.azuredevops/components/hipBLASLt.yml @@ -177,7 +177,7 @@ jobs: cd $(Agent.BuildDirectory)/temp-deps # position-independent LAPACK is required for almalinux8 builds cmake -DBUILD_GTEST=OFF -DBUILD_LAPACK=ON -DCMAKE_POSITION_INDEPENDENT_CODE=ON $(Agent.BuildDirectory)/s/deps - make + make -j sudo make install - script: | mkdir -p $(CCACHE_DIR) From 3f2c1d65eb8dcc6efb9baa4af69c5d84afa4885a Mon Sep 17 00:00:00 2001 From: David Dixon <165835255+ellosel@users.noreply.github.com> Date: Wed, 6 Aug 2025 10:09:49 -0600 Subject: [PATCH 12/17] only run one test --- .azuredevops/components/hipBLASLt.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.azuredevops/components/hipBLASLt.yml b/.azuredevops/components/hipBLASLt.yml index 0dd8456d1..5e09a2c8f 100644 --- a/.azuredevops/components/hipBLASLt.yml +++ b/.azuredevops/components/hipBLASLt.yml @@ -287,7 +287,7 @@ jobs: os: ${{ job.os }} testDir: '$(Agent.BuildDirectory)/rocm/bin' testExecutable: 'TENSILE_DB=0xFFFF ./hipblaslt-test' - testParameters: '--gtest_output=xml:./test_output.xml --gtest_color=yes --gtest_filter=*pre_checkin*' + testParameters: '--gtest_output=xml:./test_output.xml --gtest_color=yes --gtest_filter="_/matmul_test.matmul/pre_checkin_matmul_large_nt_f64_dst_f64_gfx942_f64_rf64_rf64_rf64_rf64_r_NT_4096_4096_2048_2_4096_4096_2_4096_4096_1"' - template: ${{ variables.CI_TEMPLATE_PATH }}/steps/docker-container.yml parameters: aptPackages: ${{ parameters.aptPackages }} From b9218832bc260aface3aea1c519c60d00465276b Mon Sep 17 00:00:00 2001 From: David Dixon <165835255+ellosel@users.noreply.github.com> Date: Wed, 6 Aug 2025 10:50:03 -0600 Subject: [PATCH 13/17] Update hipBLASLt.yml --- .azuredevops/components/hipBLASLt.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.azuredevops/components/hipBLASLt.yml b/.azuredevops/components/hipBLASLt.yml index 5e09a2c8f..61e763a46 100644 --- a/.azuredevops/components/hipBLASLt.yml +++ b/.azuredevops/components/hipBLASLt.yml @@ -208,7 +208,7 @@ jobs: -DHIPBLASLT_ENABLE_ROCROLLER=ON -DHIPBLASLT_ENABLE_FETCH=ON -DHIPBLASLT_ENABLE_BLIS=OFF - -DTENSILELITE_LOGIC_FILTER="gfx942/GridBased/*Bljk_DB_UserArgs" + -DTENSILELITE_LOGIC_FILTER="gfx942/GridBased/*_DB_UserArgs" -GNinja - template: ${{ variables.CI_TEMPLATE_PATH }}/steps/manifest.yml parameters: From af4f2910058a42f269f0d8ebbf903aca76b67d64 Mon Sep 17 00:00:00 2001 From: Daniel Su Date: Thu, 7 Aug 2025 10:43:03 -0400 Subject: [PATCH 14/17] Compress and upload build files --- .azuredevops/components/hipBLASLt.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.azuredevops/components/hipBLASLt.yml b/.azuredevops/components/hipBLASLt.yml index 61e763a46..fd66abc43 100644 --- a/.azuredevops/components/hipBLASLt.yml +++ b/.azuredevops/components/hipBLASLt.yml @@ -210,6 +210,12 @@ jobs: -DHIPBLASLT_ENABLE_BLIS=OFF -DTENSILELITE_LOGIC_FILTER="gfx942/GridBased/*_DB_UserArgs" -GNinja + - task: Bash@3 + displayName: Compress build dir + inputs: + targetType: inline + script: | + tar -czf $(Build.ArtifactStagingDirectory)/hipblaslt-build-files.tar.gz $(Agent.BuildDirectory)/s/build - template: ${{ variables.CI_TEMPLATE_PATH }}/steps/manifest.yml parameters: componentName: ${{ parameters.componentName }} From 7e0efaa6b0e6ec7e00e91a653b6d60ae67c9ce41 Mon Sep 17 00:00:00 2001 From: David Dixon <165835255+ellosel@users.noreply.github.com> Date: Thu, 7 Aug 2025 11:35:37 -0600 Subject: [PATCH 15/17] build all kernels --- .azuredevops/components/hipBLASLt.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.azuredevops/components/hipBLASLt.yml b/.azuredevops/components/hipBLASLt.yml index fd66abc43..6695362ed 100644 --- a/.azuredevops/components/hipBLASLt.yml +++ b/.azuredevops/components/hipBLASLt.yml @@ -208,7 +208,6 @@ jobs: -DHIPBLASLT_ENABLE_ROCROLLER=ON -DHIPBLASLT_ENABLE_FETCH=ON -DHIPBLASLT_ENABLE_BLIS=OFF - -DTENSILELITE_LOGIC_FILTER="gfx942/GridBased/*_DB_UserArgs" -GNinja - task: Bash@3 displayName: Compress build dir From 16e96caf8029b3e47554d3c7f186778d50ac382c Mon Sep 17 00:00:00 2001 From: David Dixon <165835255+ellosel@users.noreply.github.com> Date: Thu, 7 Aug 2025 17:26:12 -0600 Subject: [PATCH 16/17] Restore commented code --- .azuredevops/components/hipBLASLt.yml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.azuredevops/components/hipBLASLt.yml b/.azuredevops/components/hipBLASLt.yml index 6695362ed..5f7756d0f 100644 --- a/.azuredevops/components/hipBLASLt.yml +++ b/.azuredevops/components/hipBLASLt.yml @@ -97,16 +97,16 @@ parameters: #- { pool: rocm-ci_medium_build_pool, os: almalinux8, packageManager: dnf, target: gfx1030 } testJobs: - { os: ubuntu2204, packageManager: apt, target: gfx942 } - #- { os: ubuntu2204, packageManager: apt, target: gfx90a } -#- name: downstreamComponentMatrix -# type: object -# default: -# - rocBLAS: -# name: rocBLAS -# sparseCheckoutDir: projects/rocblas -# skipUnifiedBuild: 'false' -# buildDependsOn: -# - hipBLASLt_build + - { os: ubuntu2204, packageManager: apt, target: gfx90a } +- name: downstreamComponentMatrix + type: object + default: + - rocBLAS: + name: rocBLAS + sparseCheckoutDir: projects/rocblas + skipUnifiedBuild: 'false' + buildDependsOn: + - hipBLASLt_build jobs: - ${{ each job in parameters.jobMatrix.buildJobs }}: @@ -291,8 +291,8 @@ jobs: componentName: ${{ parameters.componentName }} os: ${{ job.os }} testDir: '$(Agent.BuildDirectory)/rocm/bin' - testExecutable: 'TENSILE_DB=0xFFFF ./hipblaslt-test' - testParameters: '--gtest_output=xml:./test_output.xml --gtest_color=yes --gtest_filter="_/matmul_test.matmul/pre_checkin_matmul_large_nt_f64_dst_f64_gfx942_f64_rf64_rf64_rf64_rf64_r_NT_4096_4096_2048_2_4096_4096_2_4096_4096_1"' + testExecutable: './hipblaslt-test' + testParameters: '--gtest_output=xml:./test_output.xml --gtest_color=yes' - template: ${{ variables.CI_TEMPLATE_PATH }}/steps/docker-container.yml parameters: aptPackages: ${{ parameters.aptPackages }} From e9bb2fca360082843427702261c829d4067f96ea Mon Sep 17 00:00:00 2001 From: David Dixon <165835255+ellosel@users.noreply.github.com> Date: Thu, 7 Aug 2025 17:29:22 -0600 Subject: [PATCH 17/17] Remove build dir artifact creation --- .azuredevops/components/hipBLASLt.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.azuredevops/components/hipBLASLt.yml b/.azuredevops/components/hipBLASLt.yml index 5f7756d0f..d8bfbd0bb 100644 --- a/.azuredevops/components/hipBLASLt.yml +++ b/.azuredevops/components/hipBLASLt.yml @@ -209,12 +209,6 @@ jobs: -DHIPBLASLT_ENABLE_FETCH=ON -DHIPBLASLT_ENABLE_BLIS=OFF -GNinja - - task: Bash@3 - displayName: Compress build dir - inputs: - targetType: inline - script: | - tar -czf $(Build.ArtifactStagingDirectory)/hipblaslt-build-files.tar.gz $(Agent.BuildDirectory)/s/build - template: ${{ variables.CI_TEMPLATE_PATH }}/steps/manifest.yml parameters: componentName: ${{ parameters.componentName }} @@ -292,7 +286,7 @@ jobs: os: ${{ job.os }} testDir: '$(Agent.BuildDirectory)/rocm/bin' testExecutable: './hipblaslt-test' - testParameters: '--gtest_output=xml:./test_output.xml --gtest_color=yes' + testParameters: '--gtest_output=xml:./test_output.xml --gtest_color=yes --gtest_filter=*pre_checkin*' - template: ${{ variables.CI_TEMPLATE_PATH }}/steps/docker-container.yml parameters: aptPackages: ${{ parameters.aptPackages }}