mirror of
https://github.com/ROCm/ROCm.git
synced 2026-04-05 03:01:17 -04:00
5231d57c71
Prior to this PR, matmul on sm_89 (RTX 4070) (`test/unit/operators/test_matmul.py::test_op`) would result in test failure due to too strict atol/rtol. To avoid having to choose strictness ourselves, and to have better defaults based on dtype, use the non-deprecated torch testing util. See: https://github.com/pytorch/pytorch/issues/61844 Replace: https://github.com/openai/triton/pull/2242
103 lines
4.4 KiB
Python
103 lines
4.4 KiB
Python
import pytest
|
|
import torch
|
|
|
|
import triton
|
|
import triton.language as tl
|
|
|
|
|
|
@triton.jit
|
|
def block_copy_kernel(a_ptr, b_ptr, N, BLOCK_SIZE: tl.constexpr, padding_option: tl.constexpr):
|
|
pid = tl.program_id(0)
|
|
# We only copy half of the data to see if the padding works
|
|
a_block_ptr = tl.make_block_ptr(base=a_ptr, shape=(N // 2, ), strides=(1, ), offsets=(pid * BLOCK_SIZE, ),
|
|
block_shape=(BLOCK_SIZE, ), order=(0, ))
|
|
b_block_ptr = tl.make_block_ptr(base=b_ptr, shape=(N, ), strides=(1, ), offsets=(pid * BLOCK_SIZE, ),
|
|
block_shape=(BLOCK_SIZE, ), order=(0, ))
|
|
a = tl.load(a_block_ptr, boundary_check=(0, ), padding_option=padding_option)
|
|
tl.store(b_block_ptr, a, boundary_check=(0, ))
|
|
|
|
|
|
@pytest.mark.parametrize("dtype_str, n, padding_option",
|
|
[(dtype_str, n, padding) for dtype_str in ("bool", "int16", "float16")
|
|
for n in (64, 128, 256, 512, 1024)
|
|
for padding in ("zero", "nan")])
|
|
def test_block_copy(dtype_str, n, padding_option):
|
|
capability = torch.cuda.get_device_capability()
|
|
if capability[0] >= 9:
|
|
pytest.skip("Hopper support is working in progress")
|
|
|
|
dtype = getattr(torch, dtype_str)
|
|
if dtype_str in ("bool", "int16"):
|
|
if padding_option == "nan":
|
|
pytest.skip("Padding with NaN is not supported for integer types")
|
|
a = torch.randint(0, 2, (n, ), device="cuda", dtype=dtype)
|
|
else:
|
|
a = torch.randn((n, ), device="cuda", dtype=dtype)
|
|
b = torch.zeros((n, ), device="cuda", dtype=dtype)
|
|
|
|
grid = lambda meta: (triton.cdiv(n, meta["BLOCK_SIZE"]),)
|
|
block_copy_kernel[grid](a_ptr=a, b_ptr=b, N=n, BLOCK_SIZE=64, padding_option=padding_option)
|
|
|
|
assert torch.all(a[0: n // 2] == b[0: n // 2])
|
|
if padding_option == "zero":
|
|
assert torch.all(b[n // 2: n] == 0)
|
|
else:
|
|
assert torch.all(torch.isnan(b[n // 2: n]))
|
|
|
|
|
|
@triton.jit
|
|
def matmul_no_scf_with_advance_kernel(
|
|
a_ptr, b_ptr, c_ptr,
|
|
M, N, K,
|
|
stride_am, stride_ak,
|
|
stride_bk, stride_bn,
|
|
stride_cm, stride_cn,
|
|
BLOCK_M: tl.constexpr, BLOCK_N: tl.constexpr, BLOCK_K: tl.constexpr
|
|
):
|
|
offs_m = tl.arange(0, BLOCK_M)
|
|
offs_n = tl.arange(0, BLOCK_N)
|
|
a_block_ptr = tl.make_block_ptr(base=a_ptr, shape=(M, K), strides=(stride_am, stride_ak),
|
|
offsets=(0, 0), block_shape=(BLOCK_M, BLOCK_K), order=(1, 0))
|
|
b_block_ptr = tl.make_block_ptr(base=b_ptr, shape=(K, N), strides=(stride_bk, stride_bn),
|
|
offsets=(0, 0), block_shape=(BLOCK_K, BLOCK_N), order=(1, 0))
|
|
# Below two lines are just for testing negative offsets for the `advance` API, which could be removed
|
|
a_block_ptr = tl.advance(a_block_ptr, (BLOCK_M, -BLOCK_K))
|
|
a_block_ptr = tl.advance(a_block_ptr, (-BLOCK_M, BLOCK_K))
|
|
a = tl.load(a_block_ptr, boundary_check=(1, ), padding_option="zero")
|
|
b = tl.load(b_block_ptr, boundary_check=(0, ), padding_option="zero")
|
|
|
|
c = tl.dot(a, b)
|
|
c_ptrs = c_ptr + offs_m[:, None] * stride_cm + offs_n[None, :] * stride_cn
|
|
tl.store(c_ptrs, c)
|
|
|
|
|
|
@pytest.mark.parametrize("shape, num_warps", [
|
|
(shape, num_warps)
|
|
for shape in [
|
|
[64, 64, 16],
|
|
[64, 64, 32],
|
|
[64, 64, 64],
|
|
]
|
|
for num_warps in [4, 8]
|
|
])
|
|
def test_block_ptr_matmul_no_scf(shape, num_warps):
|
|
capability = torch.cuda.get_device_capability()
|
|
if capability[0] >= 9:
|
|
pytest.skip("Hopper support is working in progress")
|
|
|
|
m, n, k = shape
|
|
a = torch.randn((m, k), device="cuda", dtype=torch.float16)
|
|
b = torch.randn((k, n), device="cuda", dtype=torch.float16)
|
|
c = torch.empty((m, n), device="cuda", dtype=torch.float32)
|
|
|
|
grid = lambda META: (1, )
|
|
matmul_no_scf_with_advance_kernel[grid](a_ptr=a, b_ptr=b, c_ptr=c,
|
|
M=m, N=n, K=k,
|
|
stride_am=a.stride(0), stride_ak=a.stride(1),
|
|
stride_bk=b.stride(0), stride_bn=b.stride(1),
|
|
stride_cm=c.stride(0), stride_cn=c.stride(1),
|
|
BLOCK_M=m, BLOCK_N=n, BLOCK_K=k,
|
|
num_warps=num_warps)
|
|
golden = torch.matmul(a, b)
|
|
torch.testing.assert_close(c, golden, check_dtype=False)
|