github/ValueScript
1
1
Fork 0
mirror of https://github.com/voltrevo/ValueScript.git synced 2026-01-15 00:18:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

Use trunc instead of signum+abs+floor

Browse Source
This commit is contained in:
Andrew Morris
2022-05-22 21:43:15 +10:00
parent d1cfbd9dfe
commit 00729d0334
3 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/vstc/virtual_machine/math.rs
View File

@@ -339,7 +339,6 @@ static TANH: NativeFunction = NativeFunction {
static TRUNC: NativeFunction = NativeFunction {
fn_: |_this: &mut Val, params: Vec<Val>| -> Val {
let x = param_to_number(params.get(0));
// TODO: Use trunc to simplify signum * abs elsewhere
return Val::Number(x.trunc());
}
};

4
src/vstc/virtual_machine/operations.rs
View File

@@ -156,7 +156,7 @@ fn to_i32(x: f64) -> i32 {
return 0;
}
let int1 = ((x.signum() * x.abs().floor()) as i64) & 0xffffffff;
let int1 = (x.trunc() as i64) & 0xffffffff;
return int1 as i32;
}
@@ -166,7 +166,7 @@ pub fn to_u32(x: f64) -> u32 {
return 0;
}
let int1 = ((x.signum() * x.abs().floor()) as i64) & 0xffffffff;
let int1 = (x.trunc() as i64) & 0xffffffff;
return int1 as u32;
}

3
src/vstc/virtual_machine/vs_array.rs
View File

@@ -103,8 +103,7 @@ impl ValTrait for ArrayPrototype {
fn to_unchecked_wrapping_index(index: &Val, len: usize) -> isize {
let index_num = index.to_number();
let abs_index = index_num.abs();
let mut floored_index = index_num.signum() * abs_index.floor();
let mut floored_index = index_num.trunc();
let f64_len = len as f64;
if floored_index < 0_f64 {