github/ValueScript
1
1
Fork 0
mirror of https://github.com/voltrevo/ValueScript.git synced 2026-04-18 03:00:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

When a value is just a nested register, take it

Browse Source
This commit is contained in:
Andrew Morris
2023-06-22 08:55:52 +10:00
parent c1c5bd6f82
commit 1917bb51c6
3 changed files with 19 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
valuescript_compiler/src/function_compiler.rs
View File

@@ -1169,27 +1169,38 @@ impl FunctionCompiler {
}
pub fn use_(&mut self, mut compiled_expr: CompiledExpression) -> Value {
let asm = compiled_expr.value;
for reg in &compiled_expr.nested_registers {
self.release_reg(reg);
}
compiled_expr.release_checker.has_unreleased_registers = false;
return asm;
return Self::optimized_value(&compiled_expr);
}
pub fn use_ref(&mut self, compiled_expr: &mut CompiledExpression) -> Value {
let asm = compiled_expr.value.clone();
for reg in &compiled_expr.nested_registers {
self.release_reg(reg);
}
compiled_expr.release_checker.has_unreleased_registers = false;
return asm;
return Self::optimized_value(compiled_expr);
}
fn optimized_value(compiled_expr: &CompiledExpression) -> Value {
if let Value::Register(asm) = &compiled_expr.value {
if compiled_expr.nested_registers.first() == Some(asm) {
// Specialized optimization of common use case:
// - The value is a register and it's the only nested register.
// We can safely take this register when inserting it because it exists only for the
// purpose of supporting this value. A more generalized version is possible but it's
// duplicating the work of a proper optimizer anyway.
return Value::Register(asm.take());
}
}
compiled_expr.value.clone()
}
fn get_mutated_registers(&self, span: swc_common::Span) -> HashSet<Register> {