github/ValueScript
1
1
Fork 0
mirror of https://github.com/voltrevo/ValueScript.git synced 2026-04-18 03:00:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Avoid default match cases

Browse Source
This commit is contained in:
Andrew Morris
2023-03-01 09:10:26 +11:00
parent 2d7fb45106
commit 419ca62a03
1 changed files with 20 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
valuescript_compiler/src/function_compiler.rs
View File

@@ -266,17 +266,15 @@ impl FunctionCompiler {
Pat::Object(_) => self
.reg_allocator
.allocate_numbered(&"_object_pat".to_string()),
_ => {
self.diagnostics.push(Diagnostic {
level: DiagnosticLevel::InternalError,
message: "TODO: parameter destructuring".to_string(),
span: param_pat.span(),
});
self
.reg_allocator
.allocate_numbered(&"_todo_param_pattern".to_string())
}
Pat::Invalid(_) => self
.reg_allocator
.allocate_numbered(&"_invalid_pat".to_string()),
Pat::Rest(_) => self
.reg_allocator
.allocate_numbered(&"_rest_pat".to_string()),
Pat::Expr(_) => self
.reg_allocator
.allocate_numbered(&"_expr_pat".to_string()),
}
}
@@ -391,9 +389,19 @@ impl FunctionCompiler {
self.reg_allocator.release(register);
}
_ => {
Pat::Invalid(_) => {
// Diagnostic emitted elsewhere
}
Pat::Rest(_) => {
// TODO (Diagnostic emitted elsewhere)
}
Pat::Expr(_) => {
self.diagnostics.push(Diagnostic {
level: DiagnosticLevel::InternalError,
message: "Unexpected Pat::Expr in param/decl context".to_string(),
span: param_pat.span(),
});
}
}
}